mirror of
https://github.com/supabase/supabase.git
synced 2026-10-12 12:55:06 +03:00
The Y axis domain/range was being calculated incorrectly. Testing this is a bit painful. You need to: - using tweak-extension or similar overwrite the API response for the IOPS chart and add a really big value - reload the page - the Y axis should adapt to that really big value even if it goes over the disk max iops See screenshots below ## before - big data point wouldn't change the chart range - Y Axis max is 6k even tho we have a data point over 20k <img width="1204" height="714" alt="CleanShot 2026-02-25 at 18 47 14@2x" src="https://github.com/user-attachments/assets/881aff6e-22a2-408d-b2c4-5a27f3fda386" /> ## after - the Y axis shows the correct range <img width="932" height="786" alt="CleanShot 2026-02-25 at 18 47 57@2x" src="https://github.com/user-attachments/assets/6247c66e-4b3e-49e9-9f6b-086086913fab" />
175 lines
5.5 KiB
TypeScript
175 lines
5.5 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
|
|
import { computeYAxisDomain } from './Charts.utils'
|
|
|
|
const IOPS_DATA = [
|
|
{ timestamp: 1, disk_iops_write: 1200, disk_iops_read: 24203, disk_iops_max: 25000 },
|
|
{ timestamp: 2, disk_iops_write: 400, disk_iops_read: 3200, disk_iops_max: 25000 },
|
|
{ timestamp: 3, disk_iops_write: 100, disk_iops_read: 900, disk_iops_max: 25000 },
|
|
]
|
|
|
|
const IOPS_VISIBLE = ['disk_iops_write', 'disk_iops_read']
|
|
|
|
describe('computeYAxisDomain', () => {
|
|
describe('percentage charts with max line hidden', () => {
|
|
it('returns [0, yMaxFromVisible] to zoom in on the data', () => {
|
|
expect(
|
|
computeYAxisDomain({
|
|
isPercentage: true,
|
|
showMaxValue: false,
|
|
yMaxFromVisible: 75,
|
|
maxAttributeKey: 'cpu_usage_max',
|
|
showMaxLine: false,
|
|
data: [{ cpu_busy: 75, cpu_usage_max: 100 }],
|
|
visibleAttributeNames: ['cpu_busy'],
|
|
})
|
|
).toEqual([0, 75])
|
|
})
|
|
|
|
it('still zooms in even when a maxAttributeKey is present', () => {
|
|
expect(
|
|
computeYAxisDomain({
|
|
isPercentage: true,
|
|
showMaxValue: false,
|
|
yMaxFromVisible: 60,
|
|
maxAttributeKey: 'cpu_usage_max',
|
|
showMaxLine: true,
|
|
data: [{ cpu_busy: 60, cpu_usage_max: 100 }],
|
|
visibleAttributeNames: ['cpu_busy'],
|
|
})
|
|
).toEqual([0, 60])
|
|
})
|
|
})
|
|
|
|
describe('no max reference line', () => {
|
|
it('returns auto when maxAttributeKey is undefined', () => {
|
|
expect(
|
|
computeYAxisDomain({
|
|
isPercentage: false,
|
|
showMaxValue: false,
|
|
yMaxFromVisible: 5000,
|
|
maxAttributeKey: undefined,
|
|
showMaxLine: false,
|
|
data: IOPS_DATA,
|
|
visibleAttributeNames: IOPS_VISIBLE,
|
|
})
|
|
).toEqual(['auto', 'auto'])
|
|
})
|
|
|
|
it('returns auto when showMaxLine is false', () => {
|
|
expect(
|
|
computeYAxisDomain({
|
|
isPercentage: false,
|
|
showMaxValue: true,
|
|
yMaxFromVisible: 5000,
|
|
maxAttributeKey: 'disk_iops_max',
|
|
showMaxLine: false,
|
|
data: IOPS_DATA,
|
|
visibleAttributeNames: IOPS_VISIBLE,
|
|
})
|
|
).toEqual(['auto', 'auto'])
|
|
})
|
|
})
|
|
|
|
describe('max reference line not yet loaded (value is 0)', () => {
|
|
it('returns auto when diskConfig has not loaded and reference line value is 0', () => {
|
|
const dataWithZeroMax = IOPS_DATA.map((p) => ({ ...p, disk_iops_max: 0 }))
|
|
expect(
|
|
computeYAxisDomain({
|
|
isPercentage: false,
|
|
showMaxValue: true,
|
|
yMaxFromVisible: 5000,
|
|
maxAttributeKey: 'disk_iops_max',
|
|
showMaxLine: true,
|
|
data: dataWithZeroMax,
|
|
visibleAttributeNames: IOPS_VISIBLE,
|
|
})
|
|
).toEqual(['auto', 'auto'])
|
|
})
|
|
})
|
|
|
|
describe('explicit domain with reference line', () => {
|
|
it('uses the reference line value when bars stay below it', () => {
|
|
// All stacked bar totals (1000, 500) are well below maxRefValue (25000)
|
|
expect(
|
|
computeYAxisDomain({
|
|
isPercentage: false,
|
|
showMaxValue: true,
|
|
yMaxFromVisible: 800,
|
|
maxAttributeKey: 'disk_iops_max',
|
|
showMaxLine: true,
|
|
data: [
|
|
{ disk_iops_write: 400, disk_iops_read: 600, disk_iops_max: 25000 },
|
|
{ disk_iops_write: 200, disk_iops_read: 300, disk_iops_max: 25000 },
|
|
],
|
|
visibleAttributeNames: IOPS_VISIBLE,
|
|
})
|
|
).toEqual([0, 25000])
|
|
})
|
|
|
|
it('uses the stacked bar total when it exceeds the reference line', () => {
|
|
// Stacked total at first point: 24203 + 1200 = 25403 > 25000
|
|
expect(
|
|
computeYAxisDomain({
|
|
isPercentage: false,
|
|
showMaxValue: true,
|
|
yMaxFromVisible: 24203,
|
|
maxAttributeKey: 'disk_iops_max',
|
|
showMaxLine: true,
|
|
data: IOPS_DATA,
|
|
visibleAttributeNames: IOPS_VISIBLE,
|
|
})
|
|
).toEqual([0, 25403])
|
|
})
|
|
|
|
it('domain min is always 0', () => {
|
|
const [min] = computeYAxisDomain({
|
|
isPercentage: false,
|
|
showMaxValue: true,
|
|
yMaxFromVisible: 100,
|
|
maxAttributeKey: 'disk_iops_max',
|
|
showMaxLine: true,
|
|
data: IOPS_DATA,
|
|
visibleAttributeNames: IOPS_VISIBLE,
|
|
}) as [number, number]
|
|
expect(min).toBe(0)
|
|
})
|
|
|
|
it('works for database connections chart (single bar series, no stacking)', () => {
|
|
const data = [
|
|
{ pg_stat_database_num_backends: 45, max_db_connections: 60 },
|
|
{ pg_stat_database_num_backends: 52, max_db_connections: 60 },
|
|
]
|
|
expect(
|
|
computeYAxisDomain({
|
|
isPercentage: false,
|
|
showMaxValue: true,
|
|
yMaxFromVisible: 52,
|
|
maxAttributeKey: 'max_db_connections',
|
|
showMaxLine: true,
|
|
data,
|
|
visibleAttributeNames: ['pg_stat_database_num_backends'],
|
|
})
|
|
).toEqual([0, 60])
|
|
})
|
|
|
|
it('handles non-numeric values in data gracefully', () => {
|
|
const data = [
|
|
{ disk_iops_write: 'bad', disk_iops_read: null, disk_iops_max: 25000 },
|
|
{ disk_iops_write: 500, disk_iops_read: 1000, disk_iops_max: 25000 },
|
|
]
|
|
expect(
|
|
computeYAxisDomain({
|
|
isPercentage: false,
|
|
showMaxValue: true,
|
|
yMaxFromVisible: 1000,
|
|
maxAttributeKey: 'disk_iops_max',
|
|
showMaxLine: true,
|
|
data: data as Record<string, unknown>[],
|
|
visibleAttributeNames: IOPS_VISIBLE,
|
|
})
|
|
).toEqual([0, 25000])
|
|
})
|
|
})
|
|
})
|