mirror of
https://github.com/supabase/supabase.git
synced 2026-10-11 04:15:04 +03:00
## What kind of change does this PR introduce? Feature. Resolves DEPR-430. ## What is the current behaviour? The homepage Advisor summary, shared Advisor panel, and top-nav Advisor indicator only surface lints and notifications. Banned IPs are not represented as dismissible Advisor items, so network bans are easy to miss unless a user visits Database Settings directly. The `public bucket allows listing` warning is no longer part of this PR. That warning will move to a follow-up Splinter `WARN` lint so it can flow through the standard lint surfaces instead of a bespoke Studio signal path. ## What is the new behaviour? - adds a new Advisor `signal` source for banned IPs on the platform homepage, in the shared Advisor panel, and in the top-nav Advisor indicator - keeps dismissals client-side only for now, scoped by project and exact IP fingerprint - keeps banned IP signals at `warning` severity because they still indicate suspicious traffic and remain actionable if a user wants to review or remove a ban - leaves `/project/[ref]/advisors/security` as follow-up work because that surface is still lint-native, and banned IPs are management-plane signals rather than Splinter lints | After | | --- | | <img width="1728" height="997" alt="Mallet Toolshed Supabase-65A60B4A-107E-4D79-B9A8-23F754BEAB08" src="https://github.com/user-attachments/assets/c08ecbbb-c302-43bd-81bb-6ba7eb18b7b3" /> | ## Reviewer testing notes 1. Use a throwaway project. 2. Get the database connection string for that project. 3. Attempt to connect with the wrong password 3-4 times until you hit an `ECONNREFUSED`-style error, which should mean your IP has been banned. 4. Refresh Studio and confirm the project overview shows the new `Banned IP address` signal. 5. Open the Advisor Center and confirm: - the top-nav Advisor dot turns warning yellow - the signal detail shows `Entity`, `Issue`, and `Resolve` - `Edit network bans`, `Dismiss`, and `Learn more` are present 6. Open Database Settings > Network bans and confirm your banned IP appears there and can be unbanned. 7. Note that `/project/[ref]/advisors/security` will not show this item. That page is still lint-only, and this banned IP work is a short-term client-side signal rather than a true lint. Longer term, we likely want a more durable event model here so banned IPs can power notifications, webhooks, emails, and other project-level alerts. --------- Co-authored-by: kemal <hello@kemal.earth> Co-authored-by: Charis Lam <26616127+charislam@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
108 lines
3.9 KiB
TypeScript
108 lines
3.9 KiB
TypeScript
import { useParams } from 'common'
|
|
import { EyeOff, Globe } from 'lucide-react'
|
|
import Link from 'next/link'
|
|
import { Button, Tooltip, TooltipContent, TooltipTrigger } from 'ui'
|
|
|
|
import type { AdvisorSignalItem } from './AdvisorPanel.types'
|
|
import { useAdvisorSignals } from './useAdvisorSignals'
|
|
import { SIDEBAR_KEYS } from '@/components/layouts/ProjectLayout/LayoutSidebar/LayoutSidebarProvider'
|
|
import { AiAssistantDropdown } from '@/components/ui/AiAssistantDropdown'
|
|
import { InlineLink } from '@/components/ui/InlineLink'
|
|
import { useAdvisorStateSnapshot } from '@/state/advisor-state'
|
|
import { useAiAssistantStateSnapshot } from '@/state/ai-assistant-state'
|
|
import { useSidebarManagerSnapshot } from '@/state/sidebar-manager-state'
|
|
|
|
interface AdvisorSignalDetailProps {
|
|
item: AdvisorSignalItem
|
|
}
|
|
|
|
const buildSignalAssistantPrompt = (item: AdvisorSignalItem) => {
|
|
return [
|
|
`I'm reviewing an Advisor signal for a banned IP address: ${item.sourceData.ip}.`,
|
|
item.description ?? item.summary,
|
|
'Help me assess whether this ban should remain in place, what I should investigate before removing it, and what the safest next step is.',
|
|
'Please include when it is reasonable to dismiss this signal versus remove the ban.',
|
|
].join('\n\n')
|
|
}
|
|
|
|
export const AdvisorSignalDetail = ({ item }: AdvisorSignalDetailProps) => {
|
|
const { ref: projectRef } = useParams()
|
|
|
|
const snap = useAiAssistantStateSnapshot()
|
|
const { openSidebar } = useSidebarManagerSnapshot()
|
|
const { setSelectedItem } = useAdvisorStateSnapshot()
|
|
const { dismissSignal } = useAdvisorSignals({ projectRef })
|
|
|
|
const issueDescription = (
|
|
<>
|
|
The IP address <code className="text-code-inline">{item.sourceData.ip}</code> is temporarily
|
|
blocked because of suspicious traffic or repeated failed password attempts. If this block is
|
|
expected, you can dismiss this signal or remove the ban.
|
|
</>
|
|
)
|
|
|
|
const handleAskAssistant = () => {
|
|
openSidebar(SIDEBAR_KEYS.AI_ASSISTANT)
|
|
snap.newChat({
|
|
name: `Review ${item.title.toLowerCase()}`,
|
|
initialInput: buildSignalAssistantPrompt(item),
|
|
})
|
|
}
|
|
|
|
const onDismissSignal = () => {
|
|
dismissSignal(item.dismissalKey)
|
|
setSelectedItem(undefined)
|
|
}
|
|
|
|
return (
|
|
<div>
|
|
<h3 className="text-sm mb-2">Entity</h3>
|
|
<Tooltip>
|
|
<TooltipTrigger asChild>
|
|
<div className="flex items-center gap-2 px-2 py-0.5 bg-surface-200 border rounded-lg text-sm mb-6 w-fit">
|
|
<span className="flex items-center text-foreground-muted" aria-hidden="true">
|
|
<Globe size={15} className="text-foreground-muted" />
|
|
</span>
|
|
<span>{item.sourceData.ip}</span>
|
|
</div>
|
|
</TooltipTrigger>
|
|
<TooltipContent side="bottom">IP address currently blocked by network bans</TooltipContent>
|
|
</Tooltip>
|
|
|
|
<h3 className="text-sm mb-2">Issue</h3>
|
|
<p className="text-sm text-foreground-light mb-6">
|
|
{issueDescription}{' '}
|
|
{item.docsUrl !== undefined && (
|
|
<>
|
|
<InlineLink href={item.docsUrl}>Learn more</InlineLink>.
|
|
</>
|
|
)}
|
|
</p>
|
|
|
|
<h3 className="text-sm mb-2">Resolve</h3>
|
|
<div className="flex items-center gap-2">
|
|
<AiAssistantDropdown
|
|
label="Ask Assistant"
|
|
buildPrompt={() => buildSignalAssistantPrompt(item)}
|
|
onOpenAssistant={handleAskAssistant}
|
|
telemetrySource="advisor_signal_detail"
|
|
/>
|
|
{item.actions.map((action) => (
|
|
<Button key={`${item.dismissalKey}-${action.href}`} type="default" asChild>
|
|
<Link href={action.href}>
|
|
<span className="flex items-center gap-2">{action.label}</span>
|
|
</Link>
|
|
</Button>
|
|
))}
|
|
<Button
|
|
type="default"
|
|
icon={<EyeOff size={14} strokeWidth={1.5} />}
|
|
onClick={onDismissSignal}
|
|
>
|
|
Dismiss
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|