mirror of
https://github.com/supabase/supabase.git
synced 2026-10-08 02:45:07 +03:00
## What kind of change does this PR introduce? Accessibility cleanup (DEPR-628). ## What is the current behavior? Leftover call sites still use ad-hoc focus recipes (`ring-foreground-muted`, `outline-brand`, Dialog/Sheet `focus:` rings, etc.) instead of the shared utilities from #41575. ## What is the new behavior? Converts those leftovers across `packages/ui`, Studio, www, docs, and design-system to `focus-ring`, preferring `focus-visible`. Keeps documented exceptions (`group-focus-visible`, InputGroup `:has()`). ## To test Tab through controls (keyboard only). Expect a consistent offset ring on `:focus-visible`, not a green/brand/custom stack, and no ring animation. ### www (marketing) Preview: https://zone-www-dot-com-git-danny-depr-628-focus-ring-fbccf9-supabase.vercel.app - Global nav on `/`: Product, Developers, Solutions dropdowns; logo; hamburger + mobile menu - `/features`: view toggles and feature cards - `/company`: card links - `/changelog`: timeline / entry links - `/partners/catalog`: grid/list toggle and partner cards - `/pricing`: compute section expand control - Product / Modules / Solutions sticky navs on product pages (e.g. `/database`, `/storage`) - `/state-of-startups`: TwoOptionToggle if present ### docs Preview: https://docs-git-danny-depr-628-focus-ring-long-tail-supabase.vercel.app - Any guide page: top nav dropdowns and items - Narrow viewport: hamburger, then mobile menu links + close - Guide with PromptPanel / tabs: tab to prompt actions and tab list ### studio (dashboard) Preview: https://studio-staging-git-danny-depr-628-focus-ring-long-tail-supabase.vercel.app - Project home: Connect section tiles; drag-handle focus on sortable sections - Integrations marketplace (`/project/<ref>/integrations`): featured cards, list/grid toggle, list rows - Auth (`/project/<ref>/auth/oauth-apps`, `/project/<ref>/auth/providers`): open create/edit sheet, tab to close (X) - Database policies (`/project/<ref>/database/policies`): open policy editor sheet, tab to close - Storage policies (`/project/<ref>/storage/files/policies`): bucket section links; policy modal close - Query performance (`/project/<ref>/observability/query-performance`): info icon buttons on metrics - Replication pipeline detail (if available): slot lag / status info icons - Support (`/support/new`): attachment add/remove controls - Table editor: spreadsheet import preview checkboxes; row text/JSON editor TwoOptionToggle - Any Dialog/Sheet/toast close (X): ring on keyboard focus only, not mouse click ### design-system Preview: https://design-system-git-danny-depr-628-focus-ring-long-tail-supabase.vercel.app - Colour palette swatches (keyboard focus) - Form patterns sidepanel example: avatar / focusable control in the example ## Additional context - Linear: [DEPR-628](https://linear.app/supabase/issue/DEPR-628) - Follow-ups: form-group CSS (DEPR-629), Storage columns selection (DEPR-630), ESLint rule (DEPR-632) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Accessibility & Usability** * Standardized keyboard focus indicators across navigation, dialogs, forms, buttons, toggles, links, and tooltips using a consolidated focus style. * Improved toggle controls to use proper button semantics (instead of clickable text), including `aria-pressed`/disabled handling and better keyboard navigation. * **Visual Updates** * Harmonized hover/focus ring visuals across the design system, Studio, documentation, and marketing pages while preserving existing layout and interaction behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
126 lines
4.1 KiB
TypeScript
126 lines
4.1 KiB
TypeScript
import { navData as DevelopersData } from 'data/Solutions'
|
|
import { AnimatePresence, motion } from 'framer-motion'
|
|
import { ArrowLeftRight, ChevronRight } from 'lucide-react'
|
|
import Link from 'next/link'
|
|
import { useState } from 'react'
|
|
import { useWindowSize } from 'react-use'
|
|
|
|
type LinkProps = {
|
|
text: string
|
|
description?: string
|
|
url?: string
|
|
icon?: any
|
|
svg?: any
|
|
}
|
|
|
|
export const SolutionsDropdown = () => (
|
|
<div className="flex flex-col xl:flex-row">
|
|
<div className="w-[550px] xl:w-[600px] py-8 px-8 bg-background grid gap-3 grid-cols-2 xl:grid-cols-3">
|
|
{/* Skill Level, Who it's for, App Type */}
|
|
{DevelopersData['navigation'].slice(0, 3).map((column) => (
|
|
<LinksGroup key={column.label} links={column.links} label={column.label} />
|
|
))}
|
|
</div>
|
|
|
|
<div className="bg-surface-75 flex flex-col w-[550px] xl:w-[480px] border-t xl:border-t-0 xl:border-l">
|
|
<div className="flex flex-col gap-6 py-8 px-10">
|
|
<label className="text-foreground-lighter text-xs uppercase tracking-widest font-mono">
|
|
{DevelopersData['navigation'][3].label}
|
|
</label>
|
|
|
|
<div className="flex flex-col gap-4">
|
|
{DevelopersData['navigation'][3].links.map((link) => (
|
|
<MigrationLinkCard key={link.text} link={link} />
|
|
))}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
)
|
|
|
|
const LinksGroup = ({ links, label }: { links: LinkProps[]; label: string }) => {
|
|
return (
|
|
<div key={label} className="p-0 flex flex-col gap-6">
|
|
<label className="text-foreground-lighter text-xs uppercase tracking-widest font-mono">
|
|
{label}
|
|
</label>
|
|
<ul className="flex flex-col gap-4">
|
|
{links.map(({ icon: Icon, ...link }: LinkProps) => (
|
|
<li key={link.text}>
|
|
<Link
|
|
href={link.url!}
|
|
className="flex group items-center gap-2 text-foreground-light text-sm hover:text-foreground focus-visible:text-foreground focus-ring rounded-sm"
|
|
>
|
|
{Icon && <Icon size={16} strokeWidth={1.3} />}
|
|
<span>{link.text}</span>
|
|
<ChevronRight
|
|
strokeWidth={2}
|
|
className="w-3 -ml-1 transition-all will-change-transform -translate-x-1 opacity-0 group-hover:translate-x-0 group-hover:opacity-100"
|
|
/>
|
|
</Link>
|
|
</li>
|
|
))}
|
|
</ul>
|
|
</div>
|
|
)
|
|
}
|
|
|
|
const MotionLink = motion(Link)
|
|
|
|
const MigrationLinkCard = ({ link }: { link: LinkProps }) => {
|
|
const [hovered, setHovered] = useState(false)
|
|
const { width } = useWindowSize()
|
|
const isDesktop = width >= 1280
|
|
|
|
return (
|
|
<MotionLink
|
|
href={link.url!}
|
|
className="bg-background p-3 rounded-md border flex items-center gap-4 group overflow-hidden"
|
|
onMouseEnter={() => setHovered(true)}
|
|
onMouseLeave={() => setHovered(false)}
|
|
layout
|
|
>
|
|
<AnimatePresence mode="popLayout">
|
|
{(hovered || !isDesktop) && (
|
|
<motion.div
|
|
initial={{ opacity: 0, x: -10 }}
|
|
animate={{ opacity: 1, x: 0 }}
|
|
exit={{ opacity: 0, x: -10 }}
|
|
transition={{ duration: isDesktop ? 0.2 : 0, ease: 'easeInOut' }}
|
|
layout
|
|
>
|
|
{link.icon && <link.icon className="size-6" />}
|
|
</motion.div>
|
|
)}
|
|
</AnimatePresence>
|
|
|
|
<motion.div
|
|
className="size-6 flex items-center justify-center"
|
|
layout
|
|
transition={{ duration: isDesktop ? 0.2 : 0, ease: 'easeInOut' }}
|
|
>
|
|
<ArrowLeftRight className="size-4 text-foreground-light" strokeWidth={1.3} />
|
|
</motion.div>
|
|
|
|
<motion.div
|
|
className="flex items-center gap-1"
|
|
layout
|
|
transition={{ duration: isDesktop ? 0.2 : 0, ease: 'easeInOut' }}
|
|
>
|
|
<span className="text-base font-medium">{link.text}</span>
|
|
</motion.div>
|
|
|
|
<motion.div
|
|
layout
|
|
transition={{ duration: isDesktop ? 0.2 : 0, ease: 'easeInOut' }}
|
|
className="ml-auto"
|
|
>
|
|
<ChevronRight
|
|
strokeWidth={2}
|
|
className="w-3 transition-all will-change-transform -translate-x-1 opacity-0 group-hover:translate-x-0 group-hover:opacity-100"
|
|
/>
|
|
</motion.div>
|
|
</MotionLink>
|
|
)
|
|
}
|