mirror of
https://github.com/supabase/supabase.git
synced 2026-10-10 11:55:05 +03:00
## Summary - Adds a `create_notebook` AI assistant tool (`needsApproval: true`) that lets the assistant create a new notebook after explicit user approval. - Cell SQL is promoted from untrusted to safe via `acceptUntrustedSql`/`acceptUntrustedLogsSql` inside `execute`, using the approval gate as the confirming user gesture (same pattern as `execute_sql`). - Input is validated against the existing agent-writable notebook schema, which rejects any agent-supplied cell `id` at the schema level. - Threads an optional auth-headers param through `upsertContent`/`createNotebook`/`updateNotebook` so the tool can pass its own bearer token server-side. - Registers the tool in the tool-filter (`SCHEMA` category, alongside `list_notebooks`/`get_notebook`) and adds a `## Notebooks` prompt section guiding the assistant on when to use `create_notebook` vs. one-off `execute_sql`. Resolves FE-4082 ## Test plan - [x] `notebook-tools.test.ts` covers: tool registration, `needsApproval`, cell-id rejection, valid input, PUT body shape, and the returned id — all passing - [x] Typecheck clean - [x] Lint clean (no new warnings) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added AI-assisted notebook creation for saving multi-step investigations. * Added support for database and log SQL cells in newly created notebooks. * Notebook creation requires approval before saving and returns the notebook’s name and identifier. * Added support for custom request headers during notebook and content operations. * Added guidance for choosing between one-time SQL execution and reusable notebooks when Explorer is enabled. * **Improvements** * Improved validation and normalization of notebook content before saving. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
276 lines
8.0 KiB
TypeScript
276 lines
8.0 KiB
TypeScript
import pgMeta from '@supabase/pg-meta'
|
|
import type { JwtPayload } from '@supabase/supabase-js'
|
|
import { safeValidateUIMessages } from 'ai'
|
|
import { IS_PLATFORM } from 'common'
|
|
import type { NextApiRequest, NextApiResponse } from 'next'
|
|
import z from 'zod'
|
|
|
|
import { executeSql } from '@/data/sql/execute-sql-mutation'
|
|
import type { AiOptInLevel } from '@/hooks/misc/useOrgOptedIntoAi'
|
|
import { getAIDetails } from '@/lib/ai/ai-details'
|
|
import { NO_SCHEMA_ACCESS_MESSAGE } from '@/lib/ai/assistant-context'
|
|
import {
|
|
assistantMessageMetadataSchema,
|
|
messagesIncludeLogsSnippets,
|
|
} from '@/lib/ai/assistant-message-metadata'
|
|
import { isTracingAllowed } from '@/lib/ai/braintrust-logger'
|
|
import { generateAssistantResponse } from '@/lib/ai/generate-assistant-response'
|
|
import { isExplorerEnabled } from '@/lib/ai/is-explorer-enabled'
|
|
import { getModel } from '@/lib/ai/model'
|
|
import {
|
|
DEFAULT_ASSISTANT_ADVANCE_MODEL_ID,
|
|
DEFAULT_ASSISTANT_BASE_MODEL_ID,
|
|
getAssistantModelEntry,
|
|
isAssistantBaseModelId,
|
|
isKnownAssistantModelId,
|
|
type AssistantModelId,
|
|
} from '@/lib/ai/model.utils'
|
|
import { getTools } from '@/lib/ai/tools'
|
|
import { apiWrapper } from '@/lib/api/apiWrapper'
|
|
import { executeQuery } from '@/lib/api/self-hosted/query'
|
|
import { getURL } from '@/lib/helpers'
|
|
import { trustedUserEmail } from '@/lib/server/configcat'
|
|
|
|
export const maxDuration = 120
|
|
|
|
export const config = {
|
|
api: {
|
|
bodyParser: {
|
|
sizeLimit: '5mb',
|
|
},
|
|
},
|
|
}
|
|
|
|
async function handler(req: NextApiRequest, res: NextApiResponse, claims?: JwtPayload) {
|
|
const { method } = req
|
|
|
|
switch (method) {
|
|
case 'POST':
|
|
return handlePost(req, res, claims)
|
|
default:
|
|
res.setHeader('Allow', ['POST'])
|
|
res.status(405).json({
|
|
data: null,
|
|
error: { message: `Method ${method} Not Allowed` },
|
|
})
|
|
}
|
|
}
|
|
|
|
const wrapper = (req: NextApiRequest, res: NextApiResponse) =>
|
|
apiWrapper(req, res, handler, { withAuth: true })
|
|
|
|
export default wrapper
|
|
|
|
const requestBodySchema = z.object({
|
|
messages: z.array(z.any()),
|
|
projectRef: z.string(),
|
|
connectionString: z.string(),
|
|
schema: z.string().optional(),
|
|
table: z.string().optional(),
|
|
chatId: z.string().optional(),
|
|
chatName: z.string().optional(),
|
|
supportMode: z.boolean().optional(),
|
|
orgSlug: z.string().optional(),
|
|
model: z.string().optional(),
|
|
})
|
|
|
|
async function handlePost(req: NextApiRequest, res: NextApiResponse, claims?: JwtPayload) {
|
|
const authorization = req.headers.authorization
|
|
const accessToken = authorization?.replace('Bearer ', '')
|
|
|
|
if (IS_PLATFORM && !accessToken) {
|
|
return res.status(401).json({ error: 'Authorization token is required' })
|
|
}
|
|
|
|
const userId = claims?.sub
|
|
|
|
const body = typeof req.body === 'string' ? JSON.parse(req.body) : req.body
|
|
const { data, error: parseError } = requestBodySchema.safeParse(body)
|
|
|
|
if (parseError) {
|
|
return res.status(400).json({ error: 'Invalid request body', issues: parseError.issues })
|
|
}
|
|
|
|
const {
|
|
messages: rawMessages,
|
|
projectRef,
|
|
connectionString,
|
|
orgSlug,
|
|
chatId,
|
|
chatName,
|
|
model: rawRequestedModel,
|
|
supportMode,
|
|
} = data
|
|
|
|
const requestedModel: AssistantModelId | undefined =
|
|
rawRequestedModel && isKnownAssistantModelId(rawRequestedModel) ? rawRequestedModel : undefined
|
|
|
|
const messagesValidation = await safeValidateUIMessages({
|
|
messages: rawMessages,
|
|
metadataSchema: assistantMessageMetadataSchema,
|
|
})
|
|
if (!messagesValidation.success) {
|
|
return res.status(400).json({
|
|
error: 'Invalid request body',
|
|
message: messagesValidation.error.message,
|
|
})
|
|
}
|
|
const messages = messagesValidation.data
|
|
|
|
const includesLogsSnippets = messagesIncludeLogsSnippets(messages)
|
|
|
|
let aiOptInLevel: AiOptInLevel = 'disabled'
|
|
let hasAccessToAdvanceModel = false
|
|
let orgHasHipaaAddon: boolean | undefined
|
|
let projectIsSensitive: boolean | null | undefined
|
|
let projectRegion: string | undefined
|
|
let orgId: number | undefined
|
|
let planId: string | undefined
|
|
|
|
if (!IS_PLATFORM) {
|
|
aiOptInLevel = 'schema'
|
|
hasAccessToAdvanceModel = true
|
|
}
|
|
|
|
if (IS_PLATFORM && orgSlug && authorization && projectRef) {
|
|
try {
|
|
const aiDetails = await getAIDetails({ orgSlug, projectRef, authorization })
|
|
|
|
aiOptInLevel = aiDetails.aiOptInLevel
|
|
hasAccessToAdvanceModel = aiDetails.hasAccessToAdvanceModel
|
|
orgHasHipaaAddon = aiDetails.hasHipaaAddon
|
|
orgId = aiDetails.orgId
|
|
planId = aiDetails.planId
|
|
projectIsSensitive = aiDetails.isSensitive
|
|
projectRegion = aiDetails.region
|
|
} catch (error) {
|
|
return res.status(400).json({
|
|
error: 'There was an error fetching your organization details',
|
|
})
|
|
}
|
|
}
|
|
|
|
const explorerEnabled = await isExplorerEnabled(trustedUserEmail(claims?.email))
|
|
|
|
const envThrottled = process.env.IS_THROTTLED !== 'false'
|
|
|
|
let effectiveModel: AssistantModelId = requestedModel ?? DEFAULT_ASSISTANT_ADVANCE_MODEL_ID
|
|
if (!hasAccessToAdvanceModel || (envThrottled && !isAssistantBaseModelId(effectiveModel))) {
|
|
effectiveModel = DEFAULT_ASSISTANT_BASE_MODEL_ID
|
|
}
|
|
|
|
const {
|
|
modelParams,
|
|
error: modelError,
|
|
systemProviderOptions,
|
|
} = await getModel({
|
|
provider: 'openai',
|
|
modelEntry: getAssistantModelEntry(effectiveModel),
|
|
})
|
|
|
|
if (modelError) {
|
|
return res.status(500).json({ error: modelError.message })
|
|
}
|
|
|
|
try {
|
|
const abortController = new AbortController()
|
|
req.on('close', () => abortController.abort())
|
|
req.on('aborted', () => abortController.abort())
|
|
// Fires when the response finishes streaming or the connection drops, which
|
|
// is what tears down the remote MCP connection opened in getTools.
|
|
res.on('close', () => abortController.abort())
|
|
|
|
const tools = await getTools({
|
|
projectRef,
|
|
connectionString,
|
|
authorization,
|
|
aiOptInLevel,
|
|
accessToken,
|
|
baseUrl: getURL(),
|
|
supportMode,
|
|
isExplorerEnabled: explorerEnabled,
|
|
signal: abortController.signal,
|
|
})
|
|
|
|
// Get a list of all schemas to add to context
|
|
const getSchemas = async (): Promise<string> => {
|
|
const pgMetaSchemasList = pgMeta.schemas.list()
|
|
type Schemas = z.infer<(typeof pgMetaSchemasList)['zod']>
|
|
|
|
const { result: schemas } = await executeSql<Schemas>(
|
|
{
|
|
projectRef,
|
|
connectionString,
|
|
sql: pgMetaSchemasList.sql,
|
|
},
|
|
undefined,
|
|
{
|
|
'Content-Type': 'application/json',
|
|
...(authorization && { Authorization: authorization }),
|
|
},
|
|
IS_PLATFORM ? undefined : executeQuery
|
|
)
|
|
|
|
return schemas?.length > 0
|
|
? `The available database schema names are: ${JSON.stringify(schemas)}`
|
|
: NO_SCHEMA_ACCESS_MESSAGE
|
|
}
|
|
|
|
const result = await generateAssistantResponse({
|
|
messages,
|
|
...modelParams,
|
|
tools,
|
|
aiOptInLevel,
|
|
getSchemas: aiOptInLevel !== 'disabled' ? getSchemas : undefined,
|
|
projectRef,
|
|
chatId,
|
|
chatName,
|
|
allowTracing: isTracingAllowed({
|
|
orgHasHipaaAddon,
|
|
projectIsSensitive,
|
|
projectRegion,
|
|
}),
|
|
supportMode,
|
|
userId,
|
|
orgId,
|
|
planId,
|
|
includesLogsSnippets,
|
|
isExplorerEnabled: explorerEnabled,
|
|
requestedModel,
|
|
systemProviderOptions,
|
|
abortSignal: abortController.signal,
|
|
onSpanCreated: (spanId) => {
|
|
res.setHeader('x-braintrust-span-id', spanId)
|
|
},
|
|
})
|
|
|
|
result.pipeUIMessageStreamToResponse(res, {
|
|
sendReasoning: true,
|
|
headers: { 'Content-Encoding': 'none' },
|
|
onError: (error) => {
|
|
console.error('Assistant stream error:', error)
|
|
|
|
if (error == null) {
|
|
return 'unknown error'
|
|
}
|
|
|
|
if (typeof error === 'string') {
|
|
return error
|
|
}
|
|
|
|
if (error instanceof Error) {
|
|
return error.message
|
|
}
|
|
|
|
return JSON.stringify(error)
|
|
},
|
|
})
|
|
} catch (error) {
|
|
console.error('Error in handlePost:', error)
|
|
if (error instanceof Error) {
|
|
return res.status(500).json({ message: error.message })
|
|
}
|
|
return res.status(500).json({ message: 'An unexpected error occurred.' })
|
|
}
|
|
}
|