Files
1966209483 chore(deps): upgrade vitest to v5 (#49994)
Upgrades Vitest from 4.1.4 to 5.0.0 across the monorepo, fixes the
handful of things v5 turned into hard errors, and drops the
`vi.clearAllMocks()` boilerplate that v5's `clearMocks` default makes
redundant.

**Changed:**
- `vitest`, `@vitest/ui`, `@vitest/coverage-v8` 4.1.4 → 5.0.0 (catalog)
- `vi.mock` calls that lived inside `beforeAll`/`beforeEach`/test bodies
moved to module scope (v5 throws on nested calls). Affects the Studio
and docs setup files and four Studio tests.
- `detectBrowser` test restores `navigator` via `vi.unstubAllGlobals()`
instead of assigning `global.navigator`, which now reaches jsdom's
getter-only property.
- `RowEditor.utils.test.ts` restores its `JSON.stringify` spy. It used
to leak a throwing mock for the rest of the file, which v5's coverage
provider now trips over. A later test in the same file had been
asserting the leak's side effect (valid JSON reported as invalid) and
now asserts the correct behavior.
- `@testing-library/jest-dom` 6.6 → 7.0.1. Its vitest type augmentation
resolves through a peer now, so it lands on each package's own `vitest`
instead of whichever copy pnpm hoisted. Fixes `toBeInTheDocument` type
errors in dev-tools after the reshuffle.
- `@testing-library/react` 16.0.0 → 16.3.3 for the React 19 peer range.
- `vite: catalog:` added to dev-tools, www, and common. Without it they
resolved a newer vite than the catalog pin, which forked a second vitest
instance in the lockfile. There's now one.
- ai-commands custom matcher types use v5's `Matchers<R, T>` form.
- 110 test files: `vi.clearAllMocks()` removed from
`beforeEach`/`afterEach` hooks, along with hooks that only did that and
the imports they left unused. Calls that also reset/restore mocks are
untouched. Second commit, mechanical.

**Added:**
- `.vitest/` to the root gitignore (v5 writes JSON/JUnit/HTML reporter
output there)

**Removed:**
- `vite-tsconfig-paths` catalog entry and deps. Vitest 5 resolves
tsconfig paths itself.

Release-age note: this sat in draft with a temporary
`minimumReleaseAgeExclude` entry for `vitest` and `@vitest/*` while
5.0.0 was inside the workspace's 3-day `minimumReleaseAge` window. That
window has closed, so the exclusion is gone and nothing bypasses the
release-age gate.

**Perf** (local, medians of 3 runs, same machine):

| Suite | v4.1.4 | v5.0.0 |
|---|---|---|
| studio | 144.1s | 141.7s (-2%) |
| studio `--coverage` | 156.9s | 146.4s (-7%) |
| ui-patterns | 6.27s | 5.07s (-19%) |
| ui `--coverage` | 3.35s | 2.14s (-36%) |
| www | 0.89s | 0.47s (-47%) |

Studio is dominated by jsdom environment setup per file, which v5
doesn't change. `vitest doctor` recommends keeping the current pool
config: the vm pools and `isolate: false` all break tests.

## To test

- `pnpm install --frozen-lockfile` succeeds with no
`minimumReleaseAgeExclude` entry for vitest.
- CI: Studio unit tests, ui, ui-patterns, www, docs, and typecheck/lint
should all be green. The lint ratchet was checked locally: warning
counts on touched Studio files are identical to master.
- `pnpm test:studio` locally passes with coverage (588 files, 6240
tests).
- Open a Studio test that uses `toBeInTheDocument` in your editor and
confirm no type errors on jest-dom matchers, in Studio and in
`packages/dev-tools`.
- Known pre-existing failures unrelated to this PR: one dev-tools test
(`getEventCountBadge` capped pill) fails on master too.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Tests
- Improved test coverage for JSON validation and mobile navigation
behavior.
- Updated test setup, cleanup, environment configuration, and matcher
support across application and shared package suites.
- Removed obsolete coverage for alternate MCP transport selection.

## Chores
- Streamlined TypeScript path resolution and Vitest reporter output
handling.
- Updated testing libraries and Vitest tooling across documentation,
Studio, website, and shared packages.
- Added Vitest reporter output to ignored files.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Alaister Young <10985857+alaister@users.noreply.github.com>
Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
2026-09-10 16:45:54 +08:00

506 lines
16 KiB
TypeScript

import { fireEvent, render, screen, waitFor } from '@testing-library/react'
import { LOCAL_STORAGE_KEYS } from 'common'
import { useState, type ReactNode } from 'react'
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { MobileSheetProvider, useMobileSheet } from '../Navigation/NavigationBar/MobileSheetContext'
import { ProjectLayout } from './index'
import type { MobileMenuContentProps } from './LayoutHeader/MobileMenuContent'
import { STUDIO_PAGE_TITLE_SEPARATOR } from '@/lib/page-title'
const { mockRouter, mockSetSelectedDatabaseId, mockSetMobileMenuOpen } = vi.hoisted(() => ({
mockRouter: {
pathname: '/project/[ref]/observability/query-performance',
asPath: '/project/default/observability/query-performance',
push: vi.fn(),
replace: vi.fn(),
},
mockSetSelectedDatabaseId: vi.fn(),
mockSetMobileMenuOpen: vi.fn(),
}))
const {
mockAddBanner,
mockDismissBanner,
mockProjectState,
mockResourceWarningsState,
mockBannerDismissedState,
mockUseLocalStorageQuery,
} = vi.hoisted(() => ({
mockAddBanner: vi.fn(),
mockDismissBanner: vi.fn(),
mockProjectState: {
current: {
ref: 'default',
name: 'Project 1',
status: 'ACTIVE_HEALTHY',
postgrestStatus: 'ONLINE',
infra_compute_size: undefined as string | undefined,
integration_source: null as string | null,
},
},
mockResourceWarningsState: { current: undefined as any[] | undefined },
mockBannerDismissedState: { current: false },
mockUseLocalStorageQuery: vi.fn(),
}))
vi.mock('next/router', () => ({
useRouter: () => mockRouter,
}))
vi.mock('next/head', async () => {
const React = await import('react')
const Head = ({ children }: { children?: ReactNode }) => {
React.useEffect(() => {
const titleElement = React.Children.toArray(children).find(
(child) => React.isValidElement(child) && child.type === 'title'
)
if (!React.isValidElement<{ children: ReactNode }>(titleElement)) return
const titleText = React.Children.toArray(titleElement.props.children).join('')
document.title = titleText
}, [children])
return null
}
return { default: Head }
})
vi.mock('common', () => ({
useParams: () => ({ ref: 'default' }),
mergeRefs:
(..._refs: any[]) =>
(_value: unknown) => {},
IS_PLATFORM: false,
LOCAL_STORAGE_KEYS: {
FREE_MICRO_UPGRADE_BANNER_DISMISSED: (ref: string) =>
`free-micro-upgrade-banner-dismissed-${ref}`,
PROJECT_INTEGRATION_BANNER_DISMISSED: (ref: string, integrationSource: string) =>
`project-integration-banner-dismissed-${ref}-${integrationSource}`,
},
isFeatureEnabled: () => false,
useFlag: () => false,
}))
vi.mock('framer-motion', () => ({
AnimatePresence: ({ children }: { children: ReactNode }) => <>{children}</>,
motion: {
div: ({ children, ...props }: any) => <div {...props}>{children}</div>,
create: (Component: any) => Component,
},
}))
vi.mock('ui', () => ({
cn: (...classes: Array<string | false | null | undefined>) => classes.filter(Boolean).join(' '),
Alert: ({ children, ...props }: any) => <div {...props}>{children}</div>,
AlertDescription: ({ children, ...props }: any) => <div {...props}>{children}</div>,
AlertTitle: ({ children, ...props }: any) => <div {...props}>{children}</div>,
CommandInput: { displayName: 'CommandInput' },
Command: { displayName: 'Command' },
CommandGroup: { displayName: 'CommandGroup' },
CommandItem: { displayName: 'CommandItem' },
CommandList: { displayName: 'CommandList' },
LogoLoader: () => <div data-testid="logo-loader" />,
ResizableHandle: (props: any) => <div {...props} />,
ResizablePanel: ({ children, ...props }: any) => <div {...props}>{children}</div>,
ResizablePanelGroup: ({ children, ...props }: any) => <div {...props}>{children}</div>,
Sidebar: ({ children, ...props }: any) => <div {...props}>{children}</div>,
SidebarContent: ({ children, ...props }: any) => <div {...props}>{children}</div>,
SidebarFooter: ({ children, ...props }: any) => <div {...props}>{children}</div>,
SidebarGroup: ({ children, ...props }: any) => <div {...props}>{children}</div>,
SidebarMenu: ({ children, ...props }: any) => <div {...props}>{children}</div>,
SidebarMenuButton: (props: any) => <div {...props} />,
SidebarMenuItem: (props: any) => <div {...props} />,
useIsMobile: () => false,
usePanelRef: () => undefined,
useSidebar: () => ({ setOpen: vi.fn() }),
}))
vi.mock('ui-patterns/MobileSheetNav/MobileSheetNav', () => ({
default: ({ children }: { children: ReactNode }) => <>{children}</>,
}))
vi.mock('../editors/EditorsLayout.hooks', () => ({
useEditorType: () => undefined,
}))
vi.mock('../MainScrollContainerContext', () => ({
useMainScrollContainer: () => null,
useSetMainScrollContainer: () => () => {},
}))
vi.mock('./BuildingState', () => ({ default: () => null }))
vi.mock('./ConnectingState', () => ({ default: () => null }))
vi.mock('./LoadingState', () => ({ LoadingState: () => null }))
vi.mock('./PausedState/ProjectPausedState', () => ({ ProjectPausedState: () => null }))
vi.mock('./PauseFailedState', () => ({ PauseFailedState: () => null }))
vi.mock('./PausingState', () => ({ PausingState: () => null }))
vi.mock('./ProductMenuBar', () => ({
ProductMenuBar: ({ children }: { children: ReactNode }) => <>{children}</>,
}))
vi.mock('./ResizingState', () => ({ ResizingState: () => null }))
vi.mock('./RestartingState', () => ({ default: () => null }))
vi.mock('./RestoreFailedState', () => ({ RestoreFailedState: () => null }))
vi.mock('./RestoringState', () => ({ RestoringState: () => null }))
vi.mock('./UpgradingState', () => ({ UpgradingState: () => null }))
vi.mock('@/components/interfaces/BranchManagement/CreateBranchModal', () => ({
CreateBranchModal: () => null,
}))
vi.mock('@/components/interfaces/ProjectAPIDocs/ProjectAPIDocs', () => ({
ProjectAPIDocs: () => null,
}))
vi.mock('@/components/ui/ResourceExhaustionWarningBanner/ResourceExhaustionWarningBanner', () => ({
ResourceExhaustionWarningBanner: () => null,
}))
vi.mock('@/components/ui/ButtonTooltip', () => ({
ButtonTooltip: ({ children, ...props }: any) => (
<button tabIndex={0} {...props}>
{children}
</button>
),
}))
vi.mock('@/components/ui/PartnerIcon', () => ({
default: () => <div data-testid="partner-icon" />,
}))
vi.mock('@/hooks/custom-content/useCustomContent', () => ({
useCustomContent: () => ({ appTitle: 'Supabase' }),
}))
vi.mock('@/hooks/misc/useLocalStorage', () => ({
useLocalStorageQuery: (...args: unknown[]) => mockUseLocalStorageQuery(...args),
}))
vi.mock('@/components/ui/BannerStack/BannerStackProvider', () => ({
BANNER_ID: {
FREE_MICRO_UPGRADE: 'free-micro-upgrade-banner',
SELECT_26: 'select-2026-banner',
},
useBannerStack: () => ({
addBanner: mockAddBanner,
dismissBanner: mockDismissBanner,
banners: [],
}),
}))
vi.mock('@/components/ui/BannerStack/Banners/BannerFreeMicroUpgrade', () => ({
BannerFreeMicroUpgrade: () => null,
}))
vi.mock('@/data/usage/resource-warnings-query', () => ({
useResourceWarningsQuery: () => ({ data: mockResourceWarningsState.current }),
}))
vi.mock('@/hooks/misc/useSelectedOrganization', () => ({
useSelectedOrganizationQuery: () => ({
data: { name: 'Organization 1', slug: 'org-1' },
}),
}))
vi.mock('@/hooks/misc/useSelectedProject', () => ({
useSelectedProjectQuery: () => ({ data: mockProjectState.current }),
}))
vi.mock('@/hooks/misc/withAuth', () => ({
withAuth: (Component: any) => Component,
}))
vi.mock('@/hooks/ui/useFlag', () => ({
usePHFlag: () => undefined,
}))
vi.mock('@/state/app-state', () => ({
useAppStateSnapshot: () => ({
mobileMenuOpen: false,
showSidebar: false,
setMobileMenuOpen: mockSetMobileMenuOpen,
}),
}))
vi.mock('@/state/database-selector', () => ({
useDatabaseSelectorStateSnapshot: () => ({
setSelectedDatabaseId: mockSetSelectedDatabaseId,
}),
}))
vi.mock('./LayoutHeader/MobileMenuContent', async (importOriginal) => {
const actual = await importOriginal<typeof import('./LayoutHeader/MobileMenuContent')>()
return {
...actual,
MobileMenuContent: ({
currentProductMenuHeader,
currentProductMenu,
}: MobileMenuContentProps) => (
<div>
{currentProductMenuHeader}
{currentProductMenu}
</div>
),
}
})
vi.mock('../Navigation/ProductMenuBar', () => ({
ProductMenuBar: () => null,
}))
const MobileSheetHarness = () => {
const { content, openMenu, setContent } = useMobileSheet()
return (
<>
<button tabIndex={0} onClick={openMenu}>
Open menu
</button>
<button tabIndex={0} onClick={() => setContent(<span>Other sheet</span>)}>
Open other sheet
</button>
<div data-testid="mobile-sheet">{content}</div>
</>
)
}
const ResourceMenuHarness = () => {
const [section, setSection] = useState('Explorer')
return (
<>
<button tabIndex={0} onClick={() => setSection('Chats')}>
Change section
</button>
<ProjectLayout
product="Explorer"
isBlocking={false}
productMenuHeader={<span>{section} header</span>}
productMenu={
<button
tabIndex={0}
onClick={() => setSection(section === 'Explorer' ? 'Notebooks' : 'Explorer')}
>
{section === 'Explorer' ? 'Open notebooks' : 'Return to Explorer'}
</button>
}
>
<div />
</ProjectLayout>
</>
)
}
const renderLayout = () =>
render(
<MobileSheetProvider>
<ProjectLayout product="Database" isBlocking={false}>
<div />
</ProjectLayout>
</MobileSheetProvider>
)
describe('ProjectLayout title', () => {
beforeEach(() => {
mockRouter.pathname = '/project/[ref]/observability/query-performance'
mockRouter.asPath = '/project/default/observability/query-performance'
document.title = ''
mockProjectState.current = {
ref: 'default',
name: 'Project 1',
status: 'ACTIVE_HEALTHY',
postgrestStatus: 'ONLINE',
infra_compute_size: undefined,
integration_source: null,
}
mockBannerDismissedState.current = false
mockUseLocalStorageQuery.mockImplementation(() => [
mockBannerDismissedState.current,
vi.fn(),
{ isSuccess: true },
])
})
afterEach(() => {
document.title = ''
})
it('updates the open mobile menu when resource navigation changes without replacing other sheets', () => {
render(
<MobileSheetProvider>
<ResourceMenuHarness />
<MobileSheetHarness />
</MobileSheetProvider>
)
expect(screen.getByTestId('mobile-sheet')).toBeEmptyDOMElement()
fireEvent.click(screen.getByRole('button', { name: 'Open menu' }))
expect(screen.getByText('Explorer header')).toBeInTheDocument()
fireEvent.click(screen.getByRole('button', { name: 'Open notebooks' }))
expect(screen.getByText('Notebooks header')).toBeInTheDocument()
fireEvent.click(screen.getByRole('button', { name: 'Return to Explorer' }))
expect(screen.getByText('Explorer header')).toBeInTheDocument()
fireEvent.click(screen.getByRole('button', { name: 'Open other sheet' }))
fireEvent.click(screen.getByRole('button', { name: 'Change section' }))
expect(screen.getByTestId('mobile-sheet')).toHaveTextContent('Other sheet')
})
it('sets a composed document title and deduplicates identical section/surface labels', async () => {
render(
<MobileSheetProvider>
<ProjectLayout browserTitle={{ section: 'Settings' }} product="Settings" isBlocking={false}>
<div>Page Content</div>
</ProjectLayout>
</MobileSheetProvider>
)
await waitFor(() => {
expect(document.title).toBe(
['Settings', 'Project 1', 'Organization 1', 'Supabase'].join(STUDIO_PAGE_TITLE_SEPARATOR)
)
})
})
it('prefers entity-first browserTitle metadata when provided', async () => {
render(
<MobileSheetProvider>
<ProjectLayout
product="Database"
browserTitle={{ entity: 'users', section: 'Tables' }}
isBlocking={false}
>
<div>Page Content</div>
</ProjectLayout>
</MobileSheetProvider>
)
await waitFor(() => {
expect(document.title).toBe(
['users', 'Tables', 'Database', 'Project 1', 'Organization 1', 'Supabase'].join(
STUDIO_PAGE_TITLE_SEPARATOR
)
)
})
})
it('renders the Stripe project banner across project surfaces when the selected project is Stripe-connected', () => {
mockProjectState.current = {
...mockProjectState.current,
integration_source: 'stripe_projects',
}
renderLayout()
expect(screen.getByText('This project is connected to Stripe')).toBeTruthy()
expect(
screen.getByText('Changes made here may affect your connected Stripe project.')
).toBeTruthy()
expect(screen.getByTestId('partner-icon')).toBeTruthy()
})
it('uses a project-specific dismiss key for the Stripe project banner', () => {
mockProjectState.current = {
...mockProjectState.current,
integration_source: 'stripe_projects',
}
renderLayout()
expect(mockUseLocalStorageQuery).toHaveBeenCalledWith(
LOCAL_STORAGE_KEYS.PROJECT_INTEGRATION_BANNER_DISMISSED('default', 'stripe_projects'),
false
)
})
})
describe('FREE_MICRO_UPGRADE banner', () => {
beforeEach(() => {
mockRouter.pathname = '/project/[ref]'
mockRouter.asPath = '/project/default'
mockProjectState.current = {
ref: 'default',
name: 'Project 1',
status: 'ACTIVE_HEALTHY',
postgrestStatus: 'ONLINE',
infra_compute_size: 'nano',
integration_source: null,
}
mockResourceWarningsState.current = [
{
project: 'default',
cpu_exhaustion: true,
memory_and_swap_exhaustion: false,
disk_space_exhaustion: false,
},
]
mockBannerDismissedState.current = false
})
afterEach(() => {
mockRouter.pathname = '/project/[ref]/observability/query-performance'
mockRouter.asPath = '/project/default/observability/query-performance'
mockProjectState.current = {
ref: 'default',
name: 'Project 1',
status: 'ACTIVE_HEALTHY',
postgrestStatus: 'ONLINE',
infra_compute_size: undefined,
integration_source: null,
}
mockResourceWarningsState.current = undefined
mockBannerDismissedState.current = false
})
it('calls addBanner when project is nano and compute is near exhaustion', async () => {
renderLayout()
await waitFor(() => {
expect(mockAddBanner).toHaveBeenCalledWith(
expect.objectContaining({ id: 'free-micro-upgrade-banner' })
)
})
})
it('calls dismissBanner when banner was previously dismissed', async () => {
mockBannerDismissedState.current = true
renderLayout()
await waitFor(() => {
expect(mockDismissBanner).toHaveBeenCalledWith('free-micro-upgrade-banner')
})
expect(mockAddBanner).not.toHaveBeenCalledWith(
expect.objectContaining({ id: 'free-micro-upgrade-banner' })
)
})
it('calls dismissBanner when compute warnings are cleared', async () => {
mockResourceWarningsState.current = [
{
project: 'default',
cpu_exhaustion: false,
memory_and_swap_exhaustion: false,
disk_space_exhaustion: false,
},
]
renderLayout()
await waitFor(() => {
expect(mockDismissBanner).toHaveBeenCalledWith('free-micro-upgrade-banner')
})
expect(mockAddBanner).not.toHaveBeenCalledWith(
expect.objectContaining({ id: 'free-micro-upgrade-banner' })
)
})
it('calls dismissBanner when project is not nano compute', async () => {
mockProjectState.current = { ...mockProjectState.current, infra_compute_size: 'micro' }
renderLayout()
await waitFor(() => {
expect(mockDismissBanner).toHaveBeenCalledWith('free-micro-upgrade-banner')
})
expect(mockAddBanner).not.toHaveBeenCalledWith(
expect.objectContaining({ id: 'free-micro-upgrade-banner' })
)
})
})