Files
Charis 8b38e0d1ed feat(studio): ClickHouse dialect for logs snippet AI + rewrite to ClickHouse (#48501)
## I have read the
[CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md)
file.

YES

## What kind of change does this PR introduce?

Feature, plus a refactor of the shared logs-rewrite flow.

PR 8 of the SQL editor query-source series. Stacked on #48457 — review
that one first, and merge this after it.

## What is the current behavior?

A `log_sql` snippet runs against the ClickHouse-backed analytics
endpoint, but the SQL editor's AI still writes Postgres: inline edits
get Postgres system prompts, and the result is run through
`sql-formatter`, which mangles ClickHouse backticks and `log_attributes`
map lookups.

Legacy Logs Explorer saved queries open in the editor as `log_sql`
snippets. Those are BigQuery dialect and error against the ClickHouse
endpoint the editor runs them on, with no in-editor way out — only the
Logs Explorer offered a rewrite.

The completion route was also asymmetric. It assembled a
schema/code/instruction message for Postgres but forwarded `prompt`
verbatim for ClickHouse, so a client wanting ClickHouse had to
hand-build the equivalent string.

## What is the new behavior?

**Inline AI speaks ClickHouse for logs snippets.** `sqlSourceToDialect`
maps a snippet's source to `postgres`/`clickhouse` and
`buildCompletionRequestBody` threads it through. For ClickHouse,
`useSqlEditorAi` strips code fences from the response and skips
`formatSql`. Execution and dialect both follow the snippet type, so a
snippet's valid dialect never flips.

**Rewrite to ClickHouse in the editor.** A banner offers the rewrite for
a logs snippet whose text trips `looksLikeLegacyLogsQuery`, and proposes
the result through the editor's existing AI diff view rather than
replacing the snippet, so it's accepted or discarded like any other AI
edit. Gated on `otelLegacyLogs`: on a non-migrated org the BigQuery text
is still correct, so rewriting it would break a working query.

The offer is a state machine (`offered` / `rewriting` / `failed` /
`noRewriteNeeded` / `dismissed`) with a declarative table of valid
transitions, so the states are mutually exclusive by construction and
dismissal is terminal. A failure keeps its message and offers a retry; a
response identical to the input is reported rather than opening an empty
diff.

**One place assembles completion prompts.** The route now uses a single
template for both dialects, branching only the schema section and — for
`intent: 'rewrite'` — the instruction. `lib/ai/clickhouse-logs.ts` is
the single home for ClickHouse-logs prompt content, replacing two
independently maintained descriptions of the same table. Clients carry
no prompt text.

**The rewrite flow is shared with the Logs Explorer.** Both surfaces
previously hand-rolled the same sequence and had drifted: only one
detected a no-op rewrite, they sourced `log_attributes` keys
differently, and the Explorer formatted errors with an `as Error` cast.
Both now use `useLegacyLogsRewrite` and the same state-driven banner, so
the Explorer picks up no-op detection and typed error extraction.

**Attribute keys are fetched on submit, not while typing.** The detected
source would otherwise feed a reactive query key, making every edit that
changed it cost another network call. `useLogsAttributeKeys` is
imperative and goes through `queryClient.fetchQuery`, so a source
already cached — including by the Explorer header and query panel, which
subscribe reactively — is reused. This also closes a gap where inline
edits never received keys at all, unlike full rewrites.

`getErrorMessage` gains an optional typed fallback and no longer
stringifies a bare object into `'[object Object]'`; every existing
caller already hand-rolled a fallback, except `QueueSettings`, which
interpolated the raw result and now passes one.

Nothing here is user-visible until the `sqlEditorLogsSource` flag is
enabled.

Tests: dialect selection and request-body shape, the ClickHouse prompt
content (including that the schema section does not restate the dialect
rules), the reducer's valid and invalid transitions,
`shouldOfferLegacyLogsRewrite`, on-submit key discovery with cache
reuse, and `getErrorMessage`.

## Additional context

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Added an Assistant banner to help rewrite legacy BigQuery-style logs
queries into ClickHouse SQL.
* SQL assistance now adapts to the selected query type, including
relevant log attribute context.
* Rewrite suggestions can be reviewed as editor diffs before being
applied.

* **Bug Fixes**
* Improved rewrite failure handling, retry options, dismissal behavior,
and “no rewrite needed” messaging.
* Error notifications now provide a clearer fallback message when
details are unavailable.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-08-04 09:02:40 -04:00

349 lines
12 KiB
TypeScript

import pgMeta, { getEntityDefinitionsSql } from '@supabase/pg-meta'
import { generateText, ModelMessage, stepCountIs, tool } from 'ai'
import { IS_PLATFORM } from 'common'
import { source } from 'common-tags'
import { NextApiRequest, NextApiResponse } from 'next'
import z from 'zod'
import { executeSql } from '@/data/sql/execute-sql-mutation'
import { AiOptInLevel } from '@/hooks/misc/useOrgOptedIntoAi'
import { getOrgAIDetails } from '@/lib/ai/ai-details'
import {
buildClickhouseLogsSchemaSection,
CLICKHOUSE_LOGS_COMPLETION_INSTRUCTIONS,
CLICKHOUSE_LOGS_REWRITE_INSTRUCTION,
} from '@/lib/ai/clickhouse-logs'
import { getModel } from '@/lib/ai/model'
import { DEFAULT_COMPLETION_MODEL, LOGS_REWRITE_MODEL } from '@/lib/ai/model.utils'
import {
COMPLETION_PROMPT,
EDGE_FUNCTION_PROMPT,
PG_BEST_PRACTICES,
SECURITY_PROMPT,
SQL_COMPLETION_INSTRUCTIONS,
} from '@/lib/ai/prompts'
import { apiWrapper } from '@/lib/api/apiWrapper'
import { executeQuery } from '@/lib/api/self-hosted/query'
export const maxDuration = 60
const pgMetaSchemasList = pgMeta.schemas.list()
type Schemas = z.infer<(typeof pgMetaSchemasList)['zod']>
type EntityDefinitionRow = { data: { definitions: Array<{ id: number; sql: string }> } }
type SqlFetchParams = {
projectRef: string
connectionString: string | null | undefined
headers: Record<string, string>
}
type SchemaListResult =
| { error: true }
| { error: false; queriedSchemas: string[]; otherSchemas: string[] }
type SchemaDDLResult = { error: true } | { error: false; sqlDefinitions: string[] }
async function fetchSchemas(
includeSchema: boolean,
{ projectRef, connectionString, headers }: SqlFetchParams
): Promise<{ schemas: Schemas; error: boolean }> {
if (!includeSchema) return { schemas: [], error: false }
try {
const { result } = await executeSql<Schemas>(
{ projectRef, connectionString, sql: pgMetaSchemasList.sql },
undefined,
headers,
IS_PLATFORM ? undefined : executeQuery
)
return { schemas: result, error: false }
} catch {
return { schemas: [], error: true }
}
}
async function fetchSchemaDDL(
schemas: string[],
{ projectRef, connectionString, headers }: SqlFetchParams
): Promise<SchemaDDLResult> {
if (schemas.length === 0) return { error: false, sqlDefinitions: [] }
try {
const { result } = await executeSql<EntityDefinitionRow[]>(
{ projectRef, connectionString, sql: getEntityDefinitionsSql({ schemas }) },
undefined,
headers,
IS_PLATFORM ? undefined : executeQuery
)
const definitions = result?.[0]?.data?.definitions ?? []
return {
error: false,
sqlDefinitions: definitions.map((d) => d.sql),
}
} catch {
return { error: true }
}
}
function buildDatabaseSchemaSection({
includeSchema,
schemaListResult,
schemaDDLResult,
}: {
includeSchema: boolean
schemaListResult: SchemaListResult
schemaDDLResult: SchemaDDLResult
}): string {
if (!includeSchema) {
return 'Schema context is unavailable — data opt-in is not enabled for this project.'
}
const lines: string[] = []
if (schemaListResult.error) {
lines.push(
"Unable to fetch list of available database schemas. Assume `public` schema, infer others from the user's existing code."
)
} else {
lines.push(`Queried schemas: ${schemaListResult.queriedSchemas.join(', ')}`)
if (schemaListResult.otherSchemas.length > 0)
lines.push(
`Other available schemas (use getSchemaDefinitions tool): ${schemaListResult.otherSchemas.join(', ')}`
)
}
if (schemaDDLResult.error) {
lines.push('Failed to fetch table definitions due to a database error.')
} else {
const defsText =
schemaDDLResult.sqlDefinitions.length > 0
? schemaDDLResult.sqlDefinitions.join('\n\n')
: 'No table definitions found.'
lines.push(`\n${defsText}`)
}
return lines.join('\n')
}
const requestBodySchema = z.object({
completionMetadata: z.object({
textBeforeCursor: z.string(),
textAfterCursor: z.string(),
prompt: z.string(),
selection: z.string(),
/**
* The real `log_attributes` keys observed for the query's source, when the
* client discovered them. ClickHouse-only — there is no schema to fetch
* server-side for the logs table the way there is for Postgres DDL.
*/
availableKeys: z.array(z.string()).optional(),
}),
projectRef: z.string(),
connectionString: z.string().nullish(),
orgSlug: z.string().optional(),
language: z.string().optional(),
dialect: z.enum(['postgres', 'clickhouse']).optional(),
/**
* What the caller wants done. `rewrite` swaps the user instruction for the
* canonical BigQuery → ClickHouse rewrite instruction, so the client never has
* to carry prompt text. ClickHouse-only; defaults to `edit`.
*/
intent: z.enum(['edit', 'rewrite']).optional(),
})
async function handler(req: NextApiRequest, res: NextApiResponse) {
if (req.method !== 'POST') {
return res.status(405).json({ error: `Method ${req.method} Not Allowed` })
}
try {
let body: unknown
try {
body = typeof req.body === 'string' ? JSON.parse(req.body) : req.body
} catch {
return res.status(400).json({ error: 'Malformed JSON' })
}
const { data, error: parseError } = requestBodySchema.safeParse(body)
if (parseError) {
return res.status(400).json({ error: 'Invalid request body', issues: parseError.issues })
}
const { completionMetadata, projectRef, connectionString, orgSlug, language, dialect, intent } =
data
const { textBeforeCursor, textAfterCursor, prompt, selection, availableKeys } =
completionMetadata
const isClickhouse = dialect === 'clickhouse'
const authorization = req.headers.authorization
let aiOptInLevel: AiOptInLevel = IS_PLATFORM ? 'disabled' : 'schema'
if (IS_PLATFORM && orgSlug && authorization && projectRef) {
const { aiOptInLevel: orgAIOptInLevel } = await getOrgAIDetails({
orgSlug,
authorization,
})
aiOptInLevel = orgAIOptInLevel
}
const {
modelParams,
error: modelError,
systemProviderOptions,
} = await getModel({
provider: 'openai',
modelEntry: isClickhouse ? LOGS_REWRITE_MODEL : DEFAULT_COMPLETION_MODEL,
})
if (modelError) {
return res.status(500).json({ error: modelError.message })
}
const headers = {
'Content-Type': 'application/json',
...(authorization && { Authorization: authorization }),
}
const includeSchema = !isClickhouse && aiOptInLevel !== 'disabled'
// Fetch schema list first so we can determine which schemas to load DDL for.
// These are best-effort — if they fail, we proceed without DDL context.
const { schemas, error: schemaListError } = await fetchSchemas(includeSchema, {
projectRef,
connectionString,
headers,
})
// Always include public; also eagerly include any non-public schema whose name
// appears as `name.` in the cursor context. Checking against the real schema list
// avoids fetching DDL for table aliases or other false matches. This is robust to
// incomplete SQL (the user may be mid-typing, so a full parser would fail here).
const cursorContext = textBeforeCursor + selection + textAfterCursor
const lowerContext = cursorContext.toLowerCase()
const schemasToFetch = includeSchema
? [
'public',
...schemas
.filter((s) => {
const lower = s.name.toLowerCase()
return (
s.name !== 'public' &&
(lowerContext.includes(lower + '.') || lowerContext.includes(`"${lower}".`))
)
})
.map((s) => s.name),
]
: []
const schemaDDLResult = await fetchSchemaDDL(schemasToFetch, {
projectRef,
connectionString,
headers,
})
// Reshape the fetched schemas and candidates into a discriminated union over error states
const fetchedSchemaSet = new Set(schemasToFetch)
const schemaListResult: SchemaListResult = schemaListError
? { error: true }
: {
error: false,
queriedSchemas: schemasToFetch,
otherSchemas: schemas.filter((s) => !fetchedSchemaSet.has(s.name)).map((s) => s.name),
}
const system = isClickhouse
? source`
You write and edit ClickHouse SQL for the Supabase logs table.
Reply with ONLY the SQL that replaces the <selection> block below, keeping the
surrounding query valid: no explanation, no comments, and no markdown code fences.
${CLICKHOUSE_LOGS_COMPLETION_INSTRUCTIONS}
${SECURITY_PROMPT}
`
: source`
${COMPLETION_PROMPT}
${language === 'sql' ? `${SQL_COMPLETION_INSTRUCTIONS}\n${PG_BEST_PRACTICES}` : EDGE_FUNCTION_PROMPT}
${SECURITY_PROMPT}
`
const schemaSection = isClickhouse
? { heading: 'Logs Schema', body: buildClickhouseLogsSchemaSection(availableKeys) }
: {
heading: 'Database Schema',
body: buildDatabaseSchemaSection({ includeSchema, schemaListResult, schemaDDLResult }),
}
const instruction =
isClickhouse && intent === 'rewrite' ? CLICKHOUSE_LOGS_REWRITE_INSTRUCTION : prompt
const userMessage = source`
## ${schemaSection.heading}
${schemaSection.body}
## Code
\`\`\`${language ?? ''}
${textBeforeCursor}<selection>${selection}</selection>${textAfterCursor}
\`\`\`
## Instruction
${instruction}
`
// Note: these must be of type `CoreMessage` to prevent AI SDK from stripping `providerOptions`
// https://github.com/vercel/ai/blob/81ef2511311e8af34d75e37fc8204a82e775e8c3/packages/ai/core/prompt/standardize-prompt.ts#L83-L88
const coreMessages: ModelMessage[] = [
{
role: 'system',
content: system,
...(systemProviderOptions && { providerOptions: systemProviderOptions }),
},
{
role: 'user',
content: userMessage,
},
]
const { text } = await generateText({
...modelParams,
stopWhen: stepCountIs(5),
messages: coreMessages,
tools:
includeSchema && !schemaListResult.error
? {
getSchemaDefinitions: tool({
description: 'Get table and column definitions for one or more schemas',
inputSchema: z.object({
schemas: z
.array(z.string())
.describe('The schema names to get the definitions for'),
}),
execute: async ({ schemas: maybeSchemas }) => {
const validSchemas = maybeSchemas.filter((name) =>
schemas.some((s) => s.name === name)
)
const result = await fetchSchemaDDL(validSchemas, {
projectRef,
connectionString,
headers,
})
if (result.error)
return 'Failed to fetch schema definitions due to a database error.'
if (result.sqlDefinitions.length === 0) return 'No table definitions found.'
return result.sqlDefinitions.join('\n\n')
},
}),
}
: undefined,
})
return res.status(200).json(text)
} catch (error) {
console.error('Completion error:', error)
return res.status(500).json({ error: 'Failed to generate completion' })
}
}
const wrapper = (req: NextApiRequest, res: NextApiResponse) =>
apiWrapper(req, res, handler, { withAuth: true })
export default wrapper