mirror of
https://github.com/supabase/supabase.git
synced 2026-10-09 19:35:06 +03:00
498d051d88
## What kind of change does this PR introduce? Feature. Resolves FE-3417. ## What is the current behavior? Project Settings has a top-level `G then ,` shortcut, but its subnavigation and repeated key/log drain actions do not have scoped keyboard shortcuts or visible shortcut tooltips. | Area | Current behaviour | | --- | --- | | Project Settings sidebar | Routes are click-only once users are inside Settings. | | API/JWT keys | Creation buttons do not expose keyboard shortcuts. | | Log Drains | Add/save destination actions do not expose keyboard shortcuts. | ## What is the new behavior? Adds scoped Project Settings navigation chords, shortcut tooltips on the sidebar rows, and page/action shortcuts for API keys, JWT standby keys, and Log Drains. | Area | New shortcut coverage | | --- | --- | | Project Settings sidebar | `S then G/C/I/N/W/K/J/L/A/D` for eligible in-section routes. | | API Keys | `Shift+P` and `Shift+S` open the publishable/secret key dialogs; `Mod+Enter` submits the open dialog. | | JWT Keys | `Shift+N` opens Create standby key; `Mod+Enter` submits the open dialog. | | Log Drains | `Shift+N` adds a destination when the primary action is available; `Mod+Enter` saves the open destination sheet. | <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added keyboard shortcuts for Project Settings navigation and for actions in API Keys, JWT Keys, and Log Drains (open, create/submit). * **Improvements** * Dialogs and forms now support keyboard-triggered open and submit actions with improved enable/disable gating and updated settings menu composition; shortcuts appear in the shortcuts reference. * **Tests** * Added tests covering shortcut wiring and shortcut-driven open/submit behaviors across dialogs and action panels. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/46352?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Ali Waseem <waseema393@gmail.com>
40 lines
1.4 KiB
TypeScript
40 lines
1.4 KiB
TypeScript
import { RegistryDefinations } from '../types'
|
|
|
|
export const API_KEYS_SHORTCUT_IDS = {
|
|
API_KEYS_NEW_PUBLISHABLE: 'api-keys.new-publishable',
|
|
API_KEYS_NEW_SECRET: 'api-keys.new-secret',
|
|
API_KEYS_CREATE_PUBLISHABLE: 'api-keys.create-publishable',
|
|
API_KEYS_CREATE_SECRET: 'api-keys.create-secret',
|
|
}
|
|
|
|
export type ApiKeysShortcutId = (typeof API_KEYS_SHORTCUT_IDS)[keyof typeof API_KEYS_SHORTCUT_IDS]
|
|
|
|
export const apiKeysRegistry: RegistryDefinations<ApiKeysShortcutId> = {
|
|
[API_KEYS_SHORTCUT_IDS.API_KEYS_NEW_PUBLISHABLE]: {
|
|
id: API_KEYS_SHORTCUT_IDS.API_KEYS_NEW_PUBLISHABLE,
|
|
label: 'New publishable key',
|
|
sequence: ['Shift+P'],
|
|
showInSettings: false,
|
|
options: { ignoreInputs: true, registerInCommandMenu: true },
|
|
},
|
|
[API_KEYS_SHORTCUT_IDS.API_KEYS_NEW_SECRET]: {
|
|
id: API_KEYS_SHORTCUT_IDS.API_KEYS_NEW_SECRET,
|
|
label: 'New secret key',
|
|
sequence: ['Shift+S'],
|
|
showInSettings: false,
|
|
options: { ignoreInputs: true, registerInCommandMenu: true },
|
|
},
|
|
[API_KEYS_SHORTCUT_IDS.API_KEYS_CREATE_PUBLISHABLE]: {
|
|
id: API_KEYS_SHORTCUT_IDS.API_KEYS_CREATE_PUBLISHABLE,
|
|
label: 'Create publishable key',
|
|
sequence: ['Mod+Enter'],
|
|
showInSettings: false,
|
|
},
|
|
[API_KEYS_SHORTCUT_IDS.API_KEYS_CREATE_SECRET]: {
|
|
id: API_KEYS_SHORTCUT_IDS.API_KEYS_CREATE_SECRET,
|
|
label: 'Create secret key',
|
|
sequence: ['Mod+Enter'],
|
|
showInSettings: false,
|
|
},
|
|
}
|