mirror of
https://github.com/supabase/supabase.git
synced 2026-10-09 11:25:06 +03:00
Joshen Lim
94834752b2
## Context Improved formatting for auth logs in unified logs - their metadata are seemingly all hidden within "event_message" so the changes here bring them up - Fix detecting status, pathname, and method for auth logs from `event_message` - None were showing originally, status was mostly defaulting to `200` - Improve formatting of `event_message` by prioritising errors + floating up the auth action - Currently only shows "request completed" ## Before <img width="1449" height="955" alt="image" src="https://github.com/user-attachments/assets/f0c7f166-06ab-4bfc-8653-6f5638bf1ae7" /> ## After <img width="1449" height="956" alt="image" src="https://github.com/user-attachments/assets/cdf49bd8-c33a-4f40-a6b7-8783dc38d174" /> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * More robust parsing of auth log messages to extract error/status/method/path values and fall back to the original text when parsing fails. * Fixed cases where displayed status/method/pathname could be incorrect for auth logs. * **Improvements** * Normalized auth error text (underscores → spaces) and optional auth-action prefixes for clearer messages. * Conditional sentence-capitalization for auth event messages. * **New Features** * Centralized log metadata extraction for unified log display. * **Tests** * Added tests covering auth and non-auth log parsing and metadata extraction. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/46365?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
28 lines
1.0 KiB
TypeScript
28 lines
1.0 KiB
TypeScript
import { tryParseJson } from '@/lib/helpers'
|
|
|
|
const extractLeadingStatus = (s?: string) => {
|
|
const m = typeof s === 'string' ? s.match(/^(\d{3})\b/) : null
|
|
return m ? Number(m[1]) : undefined
|
|
}
|
|
|
|
// [Joshen] Row has an unknown type in this case so `any` is accurate
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
export const extractLogMetadata = (row: any) => {
|
|
// [Joshen] For auth logs, these metadata are nested within event_message,
|
|
// so opting to bring them out at the query level
|
|
const eventMessage = tryParseJson(row.event_message)
|
|
const status =
|
|
row.log_type === 'auth'
|
|
? (eventMessage?.status ??
|
|
extractLeadingStatus(eventMessage?.msg) ??
|
|
extractLeadingStatus(eventMessage?.error))
|
|
: (row.status ?? 200)
|
|
const method = row.log_type === 'auth' ? eventMessage?.method : row.method
|
|
const pathname =
|
|
row.log_type === 'auth'
|
|
? eventMessage?.path
|
|
: (row.url || '').replace(/^https?:\/\/[^\/]+/, '') || row.pathname || ''
|
|
|
|
return { status, method, pathname }
|
|
}
|