Files
supabase/apps/studio/components/ui/ProductMenu/ProductMenuItem.tsx
Gildas GarciaandIvan Vasilov 96d43099bb chore: refactor Button API so that it can be used a standard button (#46880)
## Problem

Our `<Button>` component breaks the default `button` contract by
redefining the `type` prop to set its variant (`primary`, `default`,
etc) instead of the button type (`submit`, `button`, etc).
This is confusing and forces to write more code when using it with
shadcn components that expect/inject the standard button props.

## Solution

- rename the `type` prop to `variant`
- rename the `htmlType` prop to `type`
- propagate the changes where necessary
- format code

## How to test

As this is just prop renaming, if it builds it's ok

---------

Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
2026-06-16 23:59:58 +02:00

104 lines
2.5 KiB
TypeScript

import Link from 'next/link'
import { Badge, Button, Menu } from 'ui'
import { ProductMenuGroupItem } from './ProductMenu.types'
import { ShortcutTooltip } from '@/components/ui/ShortcutTooltip'
interface ProductMenuItemProps {
item: ProductMenuGroupItem
isActive: boolean
target?: '_blank' | '_self'
hoverText?: string
onClick?: () => void
}
export const ProductMenuItem = ({
item,
isActive,
target = '_self',
hoverText = '',
onClick,
}: ProductMenuItemProps) => {
const {
name = '',
url = '',
icon,
rightIcon,
isExternal,
label,
disabled,
shortcutId,
isLoading,
} = item
const menuItem = (
<Menu.Item icon={icon} active={isActive} onClick={onClick}>
<div className="flex w-full items-center justify-between gap-1">
<div
className="flex items-center gap-1 min-w-0 flex-1"
title={
shortcutId ? undefined : hoverText ? hoverText : typeof name === 'string' ? name : ''
}
>
<span className="truncate flex-1 min-w-0">{name}</span>
{label !== undefined && (
<Badge
className="shrink-0"
variant={label.toLowerCase() === 'new' ? 'success' : 'warning'}
>
{label}
</Badge>
)}
</div>
{rightIcon && <div>{rightIcon}</div>}
</div>
</Menu.Item>
)
// When data necessary to check whether an item should be disabled is not yet available, override the styles to avoid
// showing the disabled state just for a moment
if (isLoading) {
return <div className="pointer-events-none">{menuItem}</div>
}
if (disabled) {
return <div className="opacity-50 pointer-events-none">{menuItem}</div>
}
if (url) {
if (isExternal) {
const externalLink = (
<Button asChild block className="justify-start!" variant="text" size="small" icon={icon}>
<Link href={url} target="_blank" rel="noreferrer">
{name}
</Link>
</Button>
)
return shortcutId ? (
<ShortcutTooltip shortcutId={shortcutId} side="right" delayDuration={1000}>
{externalLink}
</ShortcutTooltip>
) : (
externalLink
)
}
const link = (
<Link href={url} className="block" target={target} onClick={onClick}>
{menuItem}
</Link>
)
return shortcutId ? (
<ShortcutTooltip shortcutId={shortcutId} side="right" delayDuration={1000}>
{link}
</ShortcutTooltip>
) : (
link
)
}
return menuItem
}