mirror of
https://github.com/supabase/supabase.git
synced 2026-10-13 13:19:09 +03:00
Gildas GarciaandIvan Vasilov
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
43 lines
1.3 KiB
TypeScript
43 lines
1.3 KiB
TypeScript
import { PropsWithChildren } from 'react'
|
|
import { Button, cn } from 'ui'
|
|
|
|
interface ConfirmFooterProps {
|
|
message: string
|
|
cancelLabel?: string
|
|
confirmLabel?: string
|
|
confirmLabelLoading?: string
|
|
isLoading?: boolean
|
|
onCancel?: () => void | Promise<void>
|
|
onConfirm?: () => void | Promise<void>
|
|
}
|
|
|
|
export const ConfirmFooter = ({
|
|
message,
|
|
cancelLabel = 'Cancel',
|
|
confirmLabel = 'Confirm',
|
|
confirmLabelLoading = 'Working...',
|
|
isLoading = false,
|
|
onCancel,
|
|
onConfirm,
|
|
}: PropsWithChildren<ConfirmFooterProps>) => {
|
|
return (
|
|
<div
|
|
className={cn(
|
|
'flex items-center justify-between py-2 pr-2 pl-4 text-xs text-foreground',
|
|
'relative border border-t-0 overflow-hidden rounded-b-lg bg-border shadow-inset gap-3',
|
|
'bg-linear-to-r from-background-surface-75 to-background-surface-200'
|
|
)}
|
|
>
|
|
<div className="flex-1 relative z-10">{message}</div>
|
|
<div className="flex items-center gap-2 relative z-10">
|
|
<Button size="tiny" variant="outline" onClick={onCancel} disabled={isLoading}>
|
|
{cancelLabel}
|
|
</Button>
|
|
<Button size="tiny" variant="primary" onClick={onConfirm} disabled={isLoading}>
|
|
{isLoading ? confirmLabelLoading : confirmLabel}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|