mirror of
https://github.com/supabase/supabase.git
synced 2026-10-09 11:25:06 +03:00
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
59 lines
1.7 KiB
TypeScript
59 lines
1.7 KiB
TypeScript
import type { OAuthClient } from '@supabase/supabase-js'
|
|
import { X } from 'lucide-react'
|
|
import { toast } from 'sonner'
|
|
import { Button } from 'ui'
|
|
import { Admonition } from 'ui-patterns/admonition'
|
|
import { Input } from 'ui-patterns/DataInputs/Input'
|
|
|
|
interface NewOAuthAppBannerProps {
|
|
oauthApp: OAuthClient
|
|
onClose: () => void
|
|
}
|
|
|
|
export const NewOAuthAppBanner = ({ oauthApp, onClose }: NewOAuthAppBannerProps) => {
|
|
return (
|
|
<Admonition
|
|
type="default"
|
|
className="relative mb-6"
|
|
title={`Successfully generated credentials for your ${oauthApp.client_name} OAuth app!`}
|
|
description={
|
|
<div className="w-full space-y-2">
|
|
<p className="text-sm">
|
|
Do copy this client id and client secret and store it in a secure place - you will not
|
|
be able to see it again.
|
|
</p>
|
|
<div className="">
|
|
<Input
|
|
copy
|
|
readOnly
|
|
size="small"
|
|
className="input-mono"
|
|
value={oauthApp?.client_id}
|
|
onChange={() => {}}
|
|
onCopy={() => toast.success('Client Id copied to clipboard')}
|
|
/>
|
|
</div>
|
|
<div className="">
|
|
<Input
|
|
copy
|
|
readOnly
|
|
size="small"
|
|
className=" input-mono"
|
|
value={oauthApp?.client_secret}
|
|
onChange={() => {}}
|
|
onCopy={() => toast.success('Client secret copied to clipboard')}
|
|
/>
|
|
</div>
|
|
</div>
|
|
}
|
|
>
|
|
<Button
|
|
variant="text"
|
|
icon={<X />}
|
|
className="w-7 h-7 absolute top-0 right-0"
|
|
onClick={onClose}
|
|
/>
|
|
</Admonition>
|
|
)
|
|
}
|