Files
Gildas GarciaandIvan Vasilov 96d43099bb chore: refactor Button API so that it can be used a standard button (#46880)
## Problem

Our `<Button>` component breaks the default `button` contract by
redefining the `type` prop to set its variant (`primary`, `default`,
etc) instead of the button type (`submit`, `button`, etc).
This is confusing and forces to write more code when using it with
shadcn components that expect/inject the standard button props.

## Solution

- rename the `type` prop to `variant`
- rename the `htmlType` prop to `type`
- propagate the changes where necessary
- format code

## How to test

As this is just prop renaming, if it builds it's ok

---------

Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
2026-06-16 23:59:58 +02:00

88 lines
2.5 KiB
TypeScript

import { EllipsisVertical, Pencil, Trash2, User } from 'lucide-react'
import {
Button,
Card,
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuTrigger,
Table,
TableBody,
TableCell,
TableHead,
TableHeader,
TableRow,
} from 'ui'
const users = [
{
name: 'Feathers McGraw',
email: 'feathers@example.com',
},
{
name: 'Piella Bakewell',
email: 'piella@example.com',
},
{
name: 'Wendolene Ramsbottom',
email: 'wendolene@example.com',
},
]
export default function TableActions() {
return (
<Card className="w-full">
<Table>
<TableHeader>
<TableRow>
<TableHead className="w-1">
<span className="sr-only">Icon</span>
</TableHead>
<TableHead>Name</TableHead>
<TableHead>Email</TableHead>
<TableHead className="w-1">
<span className="sr-only">Actions</span>
</TableHead>
</TableRow>
</TableHeader>
<TableBody>
{users.map((user) => (
<TableRow key={user.email}>
<TableCell className="w-1">
<User size={16} className="text-foreground-muted" />
</TableCell>
<TableCell>{user.name}</TableCell>
<TableCell className="text-foreground-lighter">{user.email}</TableCell>
<TableCell className="flex items-center gap-x-2">
<Button variant="default" size="tiny" className="hit-area-2">
Inspect
</Button>
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button
variant="default"
icon={<EllipsisVertical />}
aria-label="More actions"
className="w-7 hit-area-2"
/>
</DropdownMenuTrigger>
<DropdownMenuContent side="bottom" align="end" className="w-40">
<DropdownMenuItem className="gap-x-2">
<Pencil size={14} />
<span>Edit user</span>
</DropdownMenuItem>
<DropdownMenuItem className="gap-x-2">
<Trash2 size={14} />
<span>Delete</span>
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenu>
</TableCell>
</TableRow>
))}
</TableBody>
</Table>
</Card>
)
}