mirror of
https://github.com/supabase/supabase.git
synced 2026-10-09 19:35:06 +03:00
Gildas GarciaandIvan Vasilov
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
30 lines
808 B
TypeScript
30 lines
808 B
TypeScript
import Link from 'next/link'
|
||
import { Button } from 'ui'
|
||
import { Admonition } from 'ui-patterns/admonition'
|
||
|
||
const bucketId = 'user_avatars'
|
||
|
||
export default function EmptyStateMissingRoute() {
|
||
return (
|
||
<div className="flex items-center justify-center w-full h-full">
|
||
<Admonition
|
||
type="default"
|
||
className="max-w-md"
|
||
title="Unable to find bucket"
|
||
description={`${bucketId ? `The bucket “${bucketId}”` : 'This bucket'} doesn’t seem to exist.`}
|
||
>
|
||
<Button asChild variant="default" className="mt-2">
|
||
<Link
|
||
href="/"
|
||
onClick={(e) => {
|
||
e.preventDefault() // Just for demo purposes
|
||
}}
|
||
>
|
||
Head back
|
||
</Link>
|
||
</Button>
|
||
</Admonition>
|
||
</div>
|
||
)
|
||
}
|