mirror of
https://github.com/supabase/supabase.git
synced 2026-10-09 19:35:06 +03:00
Gildas GarciaandIvan Vasilov
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
15 lines
432 B
TypeScript
15 lines
432 B
TypeScript
import { Button } from 'ui'
|
|
import { Admonition } from 'ui-patterns/admonition'
|
|
|
|
export default function AdmonitionDemo() {
|
|
return (
|
|
<Admonition
|
|
type="default"
|
|
layout="responsive"
|
|
title="Disk management has moved"
|
|
description="Disk management is now handled alongside Project Compute on the Compute and Disk page."
|
|
actions={<Button variant="default">Go to Compute and Disk</Button>}
|
|
/>
|
|
)
|
|
}
|