mirror of
https://github.com/supabase/supabase.git
synced 2026-10-10 03:45:06 +03:00
Gildas GarciaandIvan Vasilov
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
25 lines
853 B
TypeScript
25 lines
853 B
TypeScript
import { Button } from 'ui'
|
||
import { Admonition } from 'ui-patterns/admonition'
|
||
|
||
export default function AdmonitionDemo() {
|
||
return (
|
||
<div className="flex flex-col gap-4">
|
||
<Admonition
|
||
type="warning"
|
||
layout="horizontal"
|
||
title="Set up custom SMTP"
|
||
description="You’re using the built-in email service. This service has rate limits and is not meant to be
|
||
used for production apps."
|
||
actions={<Button variant="default">Set up SMTP</Button>}
|
||
/>
|
||
<Admonition
|
||
type="destructive"
|
||
layout="horizontal"
|
||
title="Deleting this organization will also remove its projects"
|
||
description="Make sure you have made a backup of your projects if you want to keep your data."
|
||
actions={<Button variant="danger">Delete organization</Button>}
|
||
/>
|
||
</div>
|
||
)
|
||
}
|