mirror of
https://github.com/supabase/supabase.git
synced 2026-10-09 19:35:06 +03:00
Gildas GarciaandIvan Vasilov
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
29 lines
1.0 KiB
TypeScript
29 lines
1.0 KiB
TypeScript
import { Lightbulb } from 'lucide-react'
|
|
import { Button, Popover, PopoverContent, PopoverTrigger } from 'ui'
|
|
|
|
import { EnableIndexAdvisorButton } from '../QueryPerformance/IndexAdvisor/EnableIndexAdvisorButton'
|
|
|
|
export const IndexAdvisorPopover = () => {
|
|
return (
|
|
<Popover modal={false}>
|
|
<PopoverTrigger asChild>
|
|
<Button variant="default" icon={<Lightbulb strokeWidth={1.5} />}>
|
|
Index Advisor
|
|
</Button>
|
|
</PopoverTrigger>
|
|
<PopoverContent className="w-80 text-sm" align="end">
|
|
<h4 className="flex items-center gap-2">
|
|
<Lightbulb size={16} /> Index Advisor
|
|
</h4>
|
|
<div className="grid gap-2 mt-4 text-foreground-light text-xs">
|
|
<p>Index Advisor recommends indexes to improve query performance on this table.</p>
|
|
<p>Enable Index Advisor to get recommendations based on your actual query patterns.</p>
|
|
<div className="mt-2">
|
|
<EnableIndexAdvisorButton />
|
|
</div>
|
|
</div>
|
|
</PopoverContent>
|
|
</Popover>
|
|
)
|
|
}
|