mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 18:05:11 +03:00
## Problem Primary colour serves readable text and selected controls, but those uses need different shades. Light mode needs darker text, while dark mode needs a deeper button fill. Fixed brand green on interactive chrome also prevents a custom primary hue from carrying through the interface. Some slider tracks and selected text are hard to read. ## Solution - Keep `--primary` for accessible text and small selected indicators. Use `--primary-solid` for button fills, which need a deeper shade in dark mode. - Add `--primary-bright` for focus rings, selected control chrome, chart accents, and other interactive highlights. It follows `--primary-hue`; `brand-*` stays fixed for Supabase identity. - Make slider troughs clearer and text selection translucent with theme foreground text. - Document the split in the design-system colour guide. | Before | After | | --- | --- | | <img width="980" height="244" alt="Before: light mode primary controls" src="https://github.com/user-attachments/assets/dfae325d-0dfe-4231-8bcd-3f89c4b9d793" /> | <img width="982" height="204" alt="After: light mode primary controls" src="https://github.com/user-attachments/assets/5fdcb531-a6e3-4549-8a13-9d9a5ebe6e20" /> | | <img width="610" height="120" alt="Before: slider track" src="https://github.com/user-attachments/assets/04f768e0-51e8-4d06-9b97-c52f4a34f122" /> | <img width="622" height="126" alt="After: slider track" src="https://github.com/user-attachments/assets/95127f4e-13dc-4f0f-b63c-cf5d70a28b42" /> | | <img width="652" height="512" alt="Before: dark mode controls" src="https://github.com/user-attachments/assets/3f88de66-90cc-40ee-8cf1-b5f4eb87b09a" /> | <img width="658" height="498" alt="After: dark mode controls" src="https://github.com/user-attachments/assets/906bec30-6ca1-4614-9fb3-6cf5e5feec22" /> | ## Review instructions 1. Compare light and dark mode in the [colour usage guide](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#primary-and-brand-colors). Check primary ink, primary-solid, primary-bright, and fixed brand swatches. 2. In Studio, open the ‘new table’ sheet in [Table Editor](https://studio-staging-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/dashboard/project/_/editor). Tab through the new table sheet's fields and toggles. Check the focus rings, selected controls, and the sheet's edges in both themes. You do not need to save a table. 3. Select text in Studio in both themes, including a link or primary-coloured label. The selection and text should remain legible. 4. Check the [Field](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/field) Price Range slider: the unused track should remain visible in both themes. The selected field card border should follow primary-bright. 5. Check the [Button](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/button) and [Radio Group](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/radio-group) previews. In dark mode, `primary` button fill should be deeper than primary [text](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#text); selected radios should remain readable.
90 lines
3.1 KiB
TypeScript
90 lines
3.1 KiB
TypeScript
import { Settings, Trash2, TriangleAlert } from 'lucide-react'
|
|
import Link from 'next/link'
|
|
import { Badge, Button } from 'ui'
|
|
import { Admonition } from 'ui-patterns/Admonition'
|
|
|
|
import { type ResourceGroup } from './MarketplaceIntegrationSettingsTab.types'
|
|
import { type ConnectedResource } from '@/components/interfaces/Integrations/Landing/Landing.utils'
|
|
|
|
export const ResourceGroupSection = ({
|
|
group,
|
|
onRemove,
|
|
}: {
|
|
group: ResourceGroup
|
|
onRemove: (resource: ConnectedResource) => void
|
|
}) => {
|
|
return (
|
|
<section className="flex flex-col gap-y-4 border-b py-8 first:pt-0 last:border-b-0">
|
|
<div className="flex flex-col gap-y-2">
|
|
<div className="flex items-center gap-x-2">
|
|
<h3 className="text-base text-foreground">{group.title}</h3>
|
|
{group.missing ? (
|
|
<Badge variant="warning" className="gap-x-1.5">
|
|
<TriangleAlert size={12} strokeWidth={1.5} />
|
|
Not connected
|
|
</Badge>
|
|
) : (
|
|
group.badge && (
|
|
<Badge variant="success" className="gap-x-1.5">
|
|
<span className="h-1.5 w-1.5 rounded-full bg-primary-bright" />
|
|
{group.badge}
|
|
</Badge>
|
|
)
|
|
)}
|
|
</div>
|
|
<p className="text-sm text-foreground-light max-w-2xl">{group.description}</p>
|
|
</div>
|
|
|
|
<Admonition
|
|
type={group.missing ? 'warning' : 'default'}
|
|
className="m-0 max-w-2xl"
|
|
title={group.missing ? 'This resource is missing' : undefined}
|
|
>
|
|
{group.missing ? group.missingNote : group.note}
|
|
</Admonition>
|
|
|
|
{group.missing ? (
|
|
group.manageAction && (
|
|
<div className="max-w-2xl">
|
|
<Button asChild icon={<Settings />}>
|
|
<Link href={group.manageAction.href}>{group.manageAction.label}</Link>
|
|
</Button>
|
|
</div>
|
|
)
|
|
) : (
|
|
<div className="max-w-2xl divide-y rounded-md border bg-surface-100">
|
|
{group.items.map((item) => (
|
|
<div
|
|
key={item.resource.key}
|
|
className="flex items-center justify-between gap-x-4 px-4 py-3"
|
|
>
|
|
<div className="flex min-w-0 flex-col">
|
|
<code
|
|
className="truncate font-mono text-sm text-foreground"
|
|
title={item.identifier}
|
|
>
|
|
{item.identifier}
|
|
</code>
|
|
{item.meta && <span className="text-xs text-foreground-lighter">{item.meta}</span>}
|
|
</div>
|
|
<div className="flex shrink-0 items-center gap-x-2">
|
|
{group.manageAction && (
|
|
<Button asChild icon={<Settings />}>
|
|
<Link href={group.manageAction.href}>{group.manageAction.label}</Link>
|
|
</Button>
|
|
)}
|
|
<Button
|
|
icon={<Trash2 className="text-foreground-light" />}
|
|
onClick={() => onRemove(item.resource)}
|
|
>
|
|
Remove
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
))}
|
|
</div>
|
|
)}
|
|
</section>
|
|
)
|
|
}
|