mirror of
https://github.com/supabase/supabase.git
synced 2026-10-05 17:35:10 +03:00
## What kind of change does this PR introduce? Accessibility cleanup (DEPR-628). ## What is the current behavior? Leftover call sites still use ad-hoc focus recipes (`ring-foreground-muted`, `outline-brand`, Dialog/Sheet `focus:` rings, etc.) instead of the shared utilities from #41575. ## What is the new behavior? Converts those leftovers across `packages/ui`, Studio, www, docs, and design-system to `focus-ring`, preferring `focus-visible`. Keeps documented exceptions (`group-focus-visible`, InputGroup `:has()`). ## To test Tab through controls (keyboard only). Expect a consistent offset ring on `:focus-visible`, not a green/brand/custom stack, and no ring animation. ### www (marketing) Preview: https://zone-www-dot-com-git-danny-depr-628-focus-ring-fbccf9-supabase.vercel.app - Global nav on `/`: Product, Developers, Solutions dropdowns; logo; hamburger + mobile menu - `/features`: view toggles and feature cards - `/company`: card links - `/changelog`: timeline / entry links - `/partners/catalog`: grid/list toggle and partner cards - `/pricing`: compute section expand control - Product / Modules / Solutions sticky navs on product pages (e.g. `/database`, `/storage`) - `/state-of-startups`: TwoOptionToggle if present ### docs Preview: https://docs-git-danny-depr-628-focus-ring-long-tail-supabase.vercel.app - Any guide page: top nav dropdowns and items - Narrow viewport: hamburger, then mobile menu links + close - Guide with PromptPanel / tabs: tab to prompt actions and tab list ### studio (dashboard) Preview: https://studio-staging-git-danny-depr-628-focus-ring-long-tail-supabase.vercel.app - Project home: Connect section tiles; drag-handle focus on sortable sections - Integrations marketplace (`/project/<ref>/integrations`): featured cards, list/grid toggle, list rows - Auth (`/project/<ref>/auth/oauth-apps`, `/project/<ref>/auth/providers`): open create/edit sheet, tab to close (X) - Database policies (`/project/<ref>/database/policies`): open policy editor sheet, tab to close - Storage policies (`/project/<ref>/storage/files/policies`): bucket section links; policy modal close - Query performance (`/project/<ref>/observability/query-performance`): info icon buttons on metrics - Replication pipeline detail (if available): slot lag / status info icons - Support (`/support/new`): attachment add/remove controls - Table editor: spreadsheet import preview checkboxes; row text/JSON editor TwoOptionToggle - Any Dialog/Sheet/toast close (X): ring on keyboard focus only, not mouse click ### design-system Preview: https://design-system-git-danny-depr-628-focus-ring-long-tail-supabase.vercel.app - Colour palette swatches (keyboard focus) - Form patterns sidepanel example: avatar / focusable control in the example ## Additional context - Linear: [DEPR-628](https://linear.app/supabase/issue/DEPR-628) - Follow-ups: form-group CSS (DEPR-629), Storage columns selection (DEPR-630), ESLint rule (DEPR-632) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Accessibility & Usability** * Standardized keyboard focus indicators across navigation, dialogs, forms, buttons, toggles, links, and tooltips using a consolidated focus style. * Improved toggle controls to use proper button semantics (instead of clickable text), including `aria-pressed`/disabled handling and better keyboard navigation. * **Visual Updates** * Harmonized hover/focus ring visuals across the design system, Studio, documentation, and marketing pages while preserving existing layout and interaction behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
66 lines
1.5 KiB
TypeScript
66 lines
1.5 KiB
TypeScript
type Props = {
|
|
type?: 'primary' | 'secondary'
|
|
text: string
|
|
url?: string
|
|
className?: string
|
|
hideArrow?: boolean
|
|
}
|
|
|
|
const Button = (props: Props) => {
|
|
const { type = 'primary', text, url, className, hideArrow = false } = props
|
|
|
|
const colorClass =
|
|
type === 'primary'
|
|
? 'px-3 py-2 shadow-xs border border-transparent text-white bg-brand-400 hover:bg-brand-300'
|
|
: 'text-brand-400 bg-none'
|
|
|
|
const textClass = type === 'primary' ? 'font-medium left-3 group-hover:left-0' : 'font-normal'
|
|
|
|
const arrowClass = type === 'primary' ? '' : 'relative -left-1 group-hover:left-0'
|
|
|
|
let buttonStyles = {
|
|
textShadow: 'none',
|
|
}
|
|
if (type === 'primary') {
|
|
buttonStyles.textShadow = '0px 0px 6px rgba(13, 128, 86, 0.8)'
|
|
}
|
|
|
|
const sharedClassName = `
|
|
group inline-flex items-center rounded-md text-sm
|
|
leading-4 focus-ring ${colorClass} ${className}
|
|
`
|
|
|
|
const content = (
|
|
<>
|
|
<span
|
|
className={`
|
|
relative transition-all ${url ? textClass : ''}
|
|
`}
|
|
>
|
|
{text}
|
|
</span>
|
|
{url && !hideArrow && (
|
|
<span className={`ml-2 opacity-0 transition-all group-hover:opacity-100 ${arrowClass}`}>
|
|
→
|
|
</span>
|
|
)}
|
|
</>
|
|
)
|
|
|
|
if (url) {
|
|
return (
|
|
<a href={url} className={sharedClassName} style={buttonStyles}>
|
|
{content}
|
|
</a>
|
|
)
|
|
}
|
|
|
|
return (
|
|
<button tabIndex={0} type="button" className={sharedClassName} style={buttonStyles}>
|
|
{content}
|
|
</button>
|
|
)
|
|
}
|
|
|
|
export default Button
|