Files
supabase/apps/studio/state/tabs.test.ts
Saxon Fletcher 39c3960215 fix(studio): harden Explorer query persistence (#49039)
<img width="1690" height="1034" alt="image"
src="https://github.com/user-attachments/assets/2dc5b10b-8e64-413b-861e-8b0b62e2d880"
/>

## Summary

- debounce draft persistence and flush pending edits when the page exits
- validate untrusted local storage with Zod, recover from malformed
entries, and retain the 50 most recently updated drafts
- harden route restoration, recent-item routing, close confirmation, and
local cleanup
- disable execution while project or replica data is resolving and fail
closed for missing replicas
- use an HTTP-safe UUID generator for self-hosted Studio
- adopt the upstream Explorer toolbar title API
- expand component and state coverage for persistence and execution
behavior

## To test

1. Open Explorer, select **Run SQL**, then enter SQL and rename the
query.
2. Reload the page and confirm the draft is restored; close its tab and
confirm it is discarded after the prompt.

## Why

This layer makes local-only Explorer drafts resilient to rapid edits,
reloads, stale browser data, and tab lifecycle edge cases.

## Impact

Queries remain local-only, and closing their tabs discards them after
confirmation. Save-as-notebook functionality remains intentionally out
of scope.

## Validation

- fresh non-incremental Studio TypeScript check
- 68 Vitest tests pass across Explorer, query sources, tabs layout, and
query/tab state
- Studio ESLint ratchet and Prettier check both clean


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Explorer query drafts now save automatically and restore reliably
across navigation, tab closures, page exits, and visibility changes.
- Recent query items now open directly to their associated Explorer
query.
- Logs time-range selections are handled consistently, including custom
ranges and preset matching.

- **Bug Fixes**
  - Prevented stale query loading states when switching between queries.
  - Improved handling of invalid or outdated saved drafts.
  - Limited saved drafts to the 50 most recently updated queries.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-08-14 13:16:54 +07:00

431 lines
12 KiB
TypeScript

import type { NextRouter } from 'next/router'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { createTabId, createTabsState, type Tab } from './tabs'
import { ENTITY_TYPE } from '@/data/entity-types/entity-type-constants'
const fakeRouter = () => ({ query: { ref: 'default' }, push: vi.fn() }) as unknown as NextRouter
const sqlTab = (id: string): Tab => ({
id: `sql-${id}`,
type: 'sql',
label: id,
isPreview: false,
metadata: { sqlId: id },
})
describe('Explorer chat tabs', () => {
beforeEach(() => {
localStorage.clear()
})
it('creates stable chat tab ids and navigates to the chat route', () => {
const store = createTabsState('default')
const router = fakeRouter()
const id = createTabId('chat', { id: 'assistant-chat-id' })
store.addTab({
id,
type: 'chat',
label: 'Investigate errors',
metadata: { chatId: 'assistant-chat-id' },
isPreview: false,
})
store.handleTabNavigation(id, router)
expect(id).toBe('chat-assistant-chat-id')
expect(router.push).toHaveBeenCalledWith('/project/default/explorer/chat/assistant-chat-id')
})
it('returns to Explorer home when the final chat tab closes', () => {
const store = createTabsState('default')
const router = fakeRouter()
const id = createTabId('chat', { id: 'assistant-chat-id' })
store.addTab({
id,
type: 'chat',
label: 'Investigate errors',
metadata: { chatId: 'assistant-chat-id' },
isPreview: false,
})
store.handleTabClose({
id,
router,
editor: 'explorer',
onClearDashboardHistory: () => {},
})
expect(router.push).toHaveBeenCalledWith('/project/default/explorer')
})
})
describe('tabs recent items', () => {
beforeEach(() => {
localStorage.clear()
})
it('refreshes an existing recent item label when the tab is re-added', () => {
const store = createTabsState('default')
store.addRecentItem({
id: 'r-1',
type: ENTITY_TYPE.TABLE,
label: 'tasks',
metadata: {
schema: 'public',
name: 'tasks',
tableId: 1,
},
})
store.addRecentItem({
id: 'r-1',
type: ENTITY_TYPE.TABLE,
label: 'routines',
metadata: {
schema: 'public',
name: 'routines',
tableId: 1,
},
})
expect(store.recentItems).toHaveLength(1)
expect(store.recentItems[0].label).toBe('routines')
expect(store.recentItems[0].metadata?.name).toBe('routines')
})
it('keeps recent items aligned when an open tab label changes', () => {
const store = createTabsState('default')
store.addTab({
id: 'r-1',
type: ENTITY_TYPE.TABLE,
label: 'tasks',
metadata: {
schema: 'public',
name: 'tasks',
tableId: 1,
},
isPreview: false,
})
store.updateTab('r-1', { label: 'routines' })
expect(store.tabsMap['r-1'].label).toBe('routines')
expect(store.recentItems[0].label).toBe('routines')
expect(store.recentItems[0].metadata?.name).toBe('routines')
})
})
describe('tabs sql source metadata', () => {
beforeEach(() => {
localStorage.clear()
})
it('backfills sqlSource onto a tab and its recent item', () => {
const store = createTabsState('default')
store.addTab({
id: 'sql-a',
type: 'sql',
label: 'Logs query',
metadata: { sqlId: 'a', name: 'Logs query' },
isPreview: false,
})
// Persisted before the field existed → absent until backfilled from the snippet.
expect(store.tabsMap['sql-a'].metadata?.sqlSource).toBeUndefined()
store.updateTab('sql-a', { sqlSource: 'logs' })
expect(store.tabsMap['sql-a'].metadata?.sqlSource).toBe('logs')
expect(store.recentItems[0].metadata?.sqlSource).toBe('logs')
})
it('carries sqlSource from a tab into its recent item on creation', () => {
const store = createTabsState('default')
store.addTab({
id: 'sql-a',
type: 'sql',
label: 'Logs query',
metadata: { sqlId: 'a', name: 'Logs query', sqlSource: 'logs' },
isPreview: false,
})
expect(store.recentItems[0].metadata?.sqlSource).toBe('logs')
})
})
describe('tabs removal', () => {
beforeEach(() => {
localStorage.clear()
})
const addSqlTab = (store: ReturnType<typeof createTabsState>, id: string, isPreview = false) => {
store.addTab({
id: `sql-${id}`,
type: 'sql',
label: `Snippet ${id}`,
metadata: { sqlId: id, name: `Snippet ${id}` },
isPreview,
})
}
it('removes deleted snippet tabs and reassigns the active tab', () => {
const store = createTabsState('default')
addSqlTab(store, 'a')
addSqlTab(store, 'b')
addSqlTab(store, 'c')
expect(store.activeTab).toBe('sql-c')
store.removeTabs(['sql-c', 'sql-b'])
expect(store.openTabs).toEqual(['sql-a'])
expect(store.tabsMap['sql-b']).toBeUndefined()
expect(store.tabsMap['sql-c']).toBeUndefined()
expect(store.activeTab).toBe('sql-a')
})
it('clears the active tab when the last tab is removed', () => {
const store = createTabsState('default')
addSqlTab(store, 'a')
store.removeTab('sql-a')
expect(store.openTabs).toEqual([])
expect(store.activeTab).toBeNull()
})
it('clears previewTabId when the preview tab is removed', () => {
const store = createTabsState('default')
addSqlTab(store, 'a')
addSqlTab(store, 'b', true)
expect(store.previewTabId).toBe('sql-b')
store.removeTab('sql-b')
expect(store.previewTabId).toBeUndefined()
expect(store.openTabs).toEqual(['sql-a'])
})
it('keeps previewTabId when a non-preview tab is removed', () => {
const store = createTabsState('default')
addSqlTab(store, 'a')
addSqlTab(store, 'b', true)
store.removeTab('sql-a')
expect(store.previewTabId).toBe('sql-b')
expect(store.openTabs).toEqual(['sql-b'])
})
})
describe('tabs close handlers', () => {
beforeEach(() => {
localStorage.clear()
})
it('runs the registered close handler when a single tab is closed', () => {
const store = createTabsState('default')
store.addTab(sqlTab('a'))
const onClose = vi.fn()
store.registerTabTypeHandler('sql', { onClose })
store.handleTabClose({ id: 'sql-a', router: fakeRouter(), onClearDashboardHistory: () => {} })
expect(onClose).toHaveBeenCalledTimes(1)
expect(onClose.mock.calls[0][0]).toMatchObject({ id: 'sql-a', metadata: { sqlId: 'a' } })
})
it('runs the close handler for every tab closed via closeTabs', () => {
const store = createTabsState('default')
store.addTab(sqlTab('a'))
store.addTab(sqlTab('b'))
const onClose = vi.fn()
store.registerTabTypeHandler('sql', { onClose })
store.closeTabs(['sql-a', 'sql-b'])
expect(onClose).toHaveBeenCalledTimes(2)
expect(store.openTabs).toHaveLength(0)
})
it('does not run close handlers for the low-level removeTab / removeTabs (re-keying, cleanup)', () => {
const store = createTabsState('default')
store.addTab(sqlTab('a'))
store.addTab(sqlTab('b'))
const onClose = vi.fn()
store.registerTabTypeHandler('sql', { onClose })
store.removeTab('sql-a')
store.removeTabs(['sql-b'])
expect(onClose).not.toHaveBeenCalled()
})
it('only runs the handler for the matching tab type', () => {
const store = createTabsState('default')
store.addTab(sqlTab('a'))
store.addTab({ id: 'r-1', type: ENTITY_TYPE.TABLE, label: 'tasks', isPreview: false })
const onClose = vi.fn()
store.registerTabTypeHandler('sql', { onClose })
store.closeTabs(['sql-a', 'r-1'])
expect(onClose).toHaveBeenCalledTimes(1)
expect(onClose.mock.calls[0][0]).toMatchObject({ id: 'sql-a' })
})
it('returns the confirmation from the handler when any closing tab needs it', () => {
const store = createTabsState('default')
store.addTab(sqlTab('clean'))
store.addTab(sqlTab('dirty'))
store.registerTabTypeHandler('sql', {
confirmClose: (tabs) =>
tabs.some((tab) => tab.metadata?.sqlId === 'dirty')
? { title: 'Unsaved changes', description: 'Closing will discard them.' }
: null,
})
expect(store.getCloseConfirmation(['sql-clean'])).toBeNull()
expect(store.getCloseConfirmation(['sql-clean', 'sql-dirty'])).toEqual({
title: 'Unsaved changes',
description: 'Closing will discard them.',
})
})
it('passes the full set of closing tabs to the handler so it owns the copy', () => {
const store = createTabsState('default')
store.addTab(sqlTab('a'))
store.addTab(sqlTab('b'))
store.addTab(sqlTab('c'))
// The handler — not the store — decides the wording, e.g. count-aware copy.
store.registerTabTypeHandler('sql', {
confirmClose: (tabs) => ({ title: 'Unsaved changes', description: `${tabs.length} tabs` }),
})
expect(store.getCloseConfirmation(['sql-a', 'sql-b', 'sql-c'])).toEqual({
title: 'Unsaved changes',
description: '3 tabs',
})
})
it('stops running a handler after it is unregistered', () => {
const store = createTabsState('default')
store.addTab(sqlTab('a'))
const onClose = vi.fn()
const unregister = store.registerTabTypeHandler('sql', { onClose })
unregister()
store.closeTabs(['sql-a'])
expect(onClose).not.toHaveBeenCalled()
})
it('exposes a registered status indicator and bumps the registration version', () => {
const store = createTabsState('default')
const Indicator = () => null
expect(store.getTabStatusIndicator('sql')).toBeUndefined()
const before = store.handlerRegistrationVersion
const unregister = store.registerTabTypeHandler('sql', { StatusIndicator: Indicator })
expect(store.getTabStatusIndicator('sql')).toBe(Indicator)
expect(store.handlerRegistrationVersion).toBeGreaterThan(before)
const afterRegister = store.handlerRegistrationVersion
unregister()
expect(store.getTabStatusIndicator('sql')).toBeUndefined()
expect(store.handlerRegistrationVersion).toBeGreaterThan(afterRegister)
})
})
describe('explorer query tabs', () => {
beforeEach(() => {
localStorage.clear()
})
it('navigates to a query tab using its Explorer route', () => {
const store = createTabsState('default')
const router = fakeRouter()
store.addTab({
id: 'query-query-1',
type: 'query',
label: 'Untitled query',
metadata: { queryId: 'query-1' },
isPreview: false,
})
store.handleTabNavigation('query-query-1', router)
expect(router.push).toHaveBeenCalledWith('/project/default/explorer/query/query-1')
})
it('keeps Explorer tabs open when closing all table editor tabs', () => {
const store = createTabsState('default')
const router = fakeRouter()
store.addTab({
id: 'r-1',
type: ENTITY_TYPE.TABLE,
label: 'users',
metadata: { tableId: 1, schema: 'public' },
isPreview: false,
})
store.addTab({
id: 'query-query-1',
type: 'query',
label: 'Untitled query',
metadata: { queryId: 'query-1' },
isPreview: false,
})
store.handleTabCloseAll({
editor: 'table',
router,
onClearDashboardHistory: vi.fn(),
})
expect(store.openTabs).toEqual(['query-query-1'])
expect(store.tabsMap['query-query-1']).toBeDefined()
})
it('runs query cleanup for every query closed in bulk', () => {
const store = createTabsState('default')
store.addTab({
id: 'query-query-1',
type: 'query',
label: 'Query 1',
metadata: { queryId: 'query-1' },
isPreview: false,
})
store.addTab({
id: 'query-query-2',
type: 'query',
label: 'Query 2',
metadata: { queryId: 'query-2' },
isPreview: false,
})
const onClose = vi.fn()
store.registerTabTypeHandler('query', { onClose })
store.closeTabs(['query-query-1', 'query-query-2'])
expect(onClose).toHaveBeenCalledTimes(2)
expect(onClose.mock.calls.map(([tab]) => tab.metadata?.queryId)).toEqual(['query-1', 'query-2'])
})
})