Files
supabase/apps/studio/lib/ai/supabase-mcp.test.ts
1966209483 chore(deps): upgrade vitest to v5 (#49994)
Upgrades Vitest from 4.1.4 to 5.0.0 across the monorepo, fixes the
handful of things v5 turned into hard errors, and drops the
`vi.clearAllMocks()` boilerplate that v5's `clearMocks` default makes
redundant.

**Changed:**
- `vitest`, `@vitest/ui`, `@vitest/coverage-v8` 4.1.4 → 5.0.0 (catalog)
- `vi.mock` calls that lived inside `beforeAll`/`beforeEach`/test bodies
moved to module scope (v5 throws on nested calls). Affects the Studio
and docs setup files and four Studio tests.
- `detectBrowser` test restores `navigator` via `vi.unstubAllGlobals()`
instead of assigning `global.navigator`, which now reaches jsdom's
getter-only property.
- `RowEditor.utils.test.ts` restores its `JSON.stringify` spy. It used
to leak a throwing mock for the rest of the file, which v5's coverage
provider now trips over. A later test in the same file had been
asserting the leak's side effect (valid JSON reported as invalid) and
now asserts the correct behavior.
- `@testing-library/jest-dom` 6.6 → 7.0.1. Its vitest type augmentation
resolves through a peer now, so it lands on each package's own `vitest`
instead of whichever copy pnpm hoisted. Fixes `toBeInTheDocument` type
errors in dev-tools after the reshuffle.
- `@testing-library/react` 16.0.0 → 16.3.3 for the React 19 peer range.
- `vite: catalog:` added to dev-tools, www, and common. Without it they
resolved a newer vite than the catalog pin, which forked a second vitest
instance in the lockfile. There's now one.
- ai-commands custom matcher types use v5's `Matchers<R, T>` form.
- 110 test files: `vi.clearAllMocks()` removed from
`beforeEach`/`afterEach` hooks, along with hooks that only did that and
the imports they left unused. Calls that also reset/restore mocks are
untouched. Second commit, mechanical.

**Added:**
- `.vitest/` to the root gitignore (v5 writes JSON/JUnit/HTML reporter
output there)

**Removed:**
- `vite-tsconfig-paths` catalog entry and deps. Vitest 5 resolves
tsconfig paths itself.

Release-age note: this sat in draft with a temporary
`minimumReleaseAgeExclude` entry for `vitest` and `@vitest/*` while
5.0.0 was inside the workspace's 3-day `minimumReleaseAge` window. That
window has closed, so the exclusion is gone and nothing bypasses the
release-age gate.

**Perf** (local, medians of 3 runs, same machine):

| Suite | v4.1.4 | v5.0.0 |
|---|---|---|
| studio | 144.1s | 141.7s (-2%) |
| studio `--coverage` | 156.9s | 146.4s (-7%) |
| ui-patterns | 6.27s | 5.07s (-19%) |
| ui `--coverage` | 3.35s | 2.14s (-36%) |
| www | 0.89s | 0.47s (-47%) |

Studio is dominated by jsdom environment setup per file, which v5
doesn't change. `vitest doctor` recommends keeping the current pool
config: the vm pools and `isolate: false` all break tests.

## To test

- `pnpm install --frozen-lockfile` succeeds with no
`minimumReleaseAgeExclude` entry for vitest.
- CI: Studio unit tests, ui, ui-patterns, www, docs, and typecheck/lint
should all be green. The lint ratchet was checked locally: warning
counts on touched Studio files are identical to master.
- `pnpm test:studio` locally passes with coverage (588 files, 6240
tests).
- Open a Studio test that uses `toBeInTheDocument` in your editor and
confirm no type errors on jest-dom matchers, in Studio and in
`packages/dev-tools`.
- Known pre-existing failures unrelated to this PR: one dev-tools test
(`getEventCountBadge` capped pill) fails on master too.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Tests
- Improved test coverage for JSON validation and mobile navigation
behavior.
- Updated test setup, cleanup, environment configuration, and matcher
support across application and shared package suites.
- Removed obsolete coverage for alternate MCP transport selection.

## Chores
- Streamlined TypeScript path resolution and Vitest reporter output
handling.
- Updated testing libraries and Vitest tooling across documentation,
Studio, website, and shared packages.
- Added Vitest reporter output to ignored files.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Alaister Young <10985857+alaister@users.noreply.github.com>
Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
2026-09-10 16:45:54 +08:00

139 lines
5.2 KiB
TypeScript

import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { createSupabaseMCPClient } from './supabase-mcp'
const createMCPClientMock = vi.fn()
vi.mock('@ai-sdk/mcp', () => ({
createMCPClient: (...args: any[]) => createMCPClientMock(...args),
}))
const ACCESS_TOKEN = 'test-access-token'
const PROJECT_REF = 'abcdefghijklmnopqrst'
function getTransportConfig() {
expect(createMCPClientMock).toHaveBeenCalledTimes(1)
return createMCPClientMock.mock.calls[0][0]
}
describe('createSupabaseMCPClient', () => {
const originalMcpUrl = process.env.NEXT_PUBLIC_MCP_URL
const originalSha = process.env.VERCEL_GIT_COMMIT_SHA
beforeEach(() => {
createMCPClientMock.mockResolvedValue({ tools: vi.fn() })
delete process.env.VERCEL_GIT_COMMIT_SHA
})
afterEach(() => {
if (originalMcpUrl === undefined) delete process.env.NEXT_PUBLIC_MCP_URL
else process.env.NEXT_PUBLIC_MCP_URL = originalMcpUrl
if (originalSha === undefined) delete process.env.VERCEL_GIT_COMMIT_SHA
else process.env.VERCEL_GIT_COMMIT_SHA = originalSha
})
it('connects over the HTTP transport with the supabase-studio client name', async () => {
process.env.NEXT_PUBLIC_MCP_URL = 'https://mcp.supabase.com/mcp'
await createSupabaseMCPClient({ accessToken: ACCESS_TOKEN, projectRef: PROJECT_REF })
const config = getTransportConfig()
expect(config.name).toBe('supabase-studio')
expect(config.transport.type).toBe('http')
})
it('targets the URL from NEXT_PUBLIC_MCP_URL with project_ref and read_only', async () => {
process.env.NEXT_PUBLIC_MCP_URL = 'https://mcp.supabase.com/mcp'
await createSupabaseMCPClient({ accessToken: ACCESS_TOKEN, projectRef: PROJECT_REF })
const url = new URL(getTransportConfig().transport.url)
expect(url.origin + url.pathname).toBe('https://mcp.supabase.com/mcp')
expect(url.searchParams.get('project_ref')).toBe(PROJECT_REF)
expect(url.searchParams.get('read_only')).toBe('true')
})
it('forwards the dashboard access token as a bearer header', async () => {
process.env.NEXT_PUBLIC_MCP_URL = 'https://mcp.supabase.com/mcp'
await createSupabaseMCPClient({ accessToken: ACCESS_TOKEN, projectRef: PROJECT_REF })
expect(getTransportConfig().transport.headers.Authorization).toBe(`Bearer ${ACCESS_TOKEN}`)
})
it('identifies assistant traffic with the x-source-name header', async () => {
process.env.NEXT_PUBLIC_MCP_URL = 'https://mcp.supabase.com/mcp'
await createSupabaseMCPClient({ accessToken: ACCESS_TOKEN, projectRef: PROJECT_REF })
expect(getTransportConfig().transport.headers['x-source-name']).toBe('supabase-studio')
})
it('sends x-source-version from VERCEL_GIT_COMMIT_SHA when available', async () => {
process.env.NEXT_PUBLIC_MCP_URL = 'https://mcp.supabase.com/mcp'
process.env.VERCEL_GIT_COMMIT_SHA = 'abc1234'
await createSupabaseMCPClient({ accessToken: ACCESS_TOKEN, projectRef: PROJECT_REF })
expect(getTransportConfig().transport.headers['x-source-version']).toBe('abc1234')
})
it('omits x-source-version when VERCEL_GIT_COMMIT_SHA is not set', async () => {
process.env.NEXT_PUBLIC_MCP_URL = 'https://mcp.supabase.com/mcp'
delete process.env.VERCEL_GIT_COMMIT_SHA
await createSupabaseMCPClient({ accessToken: ACCESS_TOKEN, projectRef: PROJECT_REF })
expect(getTransportConfig().transport.headers).not.toHaveProperty('x-source-version')
})
it('never leaks the access token into the URL', async () => {
process.env.NEXT_PUBLIC_MCP_URL = 'https://mcp.supabase.com/mcp'
await createSupabaseMCPClient({ accessToken: ACCESS_TOKEN, projectRef: PROJECT_REF })
expect(getTransportConfig().transport.url).not.toContain(ACCESS_TOKEN)
})
it('always requests read-only mode', async () => {
process.env.NEXT_PUBLIC_MCP_URL = 'https://mcp.supabase.com/mcp'
await createSupabaseMCPClient({ accessToken: ACCESS_TOKEN, projectRef: PROJECT_REF })
const url = new URL(getTransportConfig().transport.url)
expect(url.searchParams.get('read_only')).toBe('true')
})
it('falls back to the default local URL when NEXT_PUBLIC_MCP_URL is unset', async () => {
delete process.env.NEXT_PUBLIC_MCP_URL
await createSupabaseMCPClient({ accessToken: ACCESS_TOKEN, projectRef: PROJECT_REF })
const url = new URL(getTransportConfig().transport.url)
expect(url.origin + url.pathname).toBe('http://localhost:8080/mcp')
expect(url.searchParams.get('project_ref')).toBe(PROJECT_REF)
})
it('falls back to the default local URL when NEXT_PUBLIC_MCP_URL is an empty string', async () => {
process.env.NEXT_PUBLIC_MCP_URL = ''
await createSupabaseMCPClient({ accessToken: ACCESS_TOKEN, projectRef: PROJECT_REF })
const url = new URL(getTransportConfig().transport.url)
expect(url.origin + url.pathname).toBe('http://localhost:8080/mcp')
})
it('returns the client created by createMCPClient', async () => {
process.env.NEXT_PUBLIC_MCP_URL = 'https://mcp.supabase.com/mcp'
const fakeClient = { tools: vi.fn() }
createMCPClientMock.mockResolvedValueOnce(fakeClient)
const client = await createSupabaseMCPClient({
accessToken: ACCESS_TOKEN,
projectRef: PROJECT_REF,
})
expect(client).toBe(fakeClient)
})
})