Files
supabase/apps/studio/hooks/misc/withAuth.tsx
Ali Waseem d8563cfc6a fix(studio): require full authentication for the support form (#49318)
The support form was exempted from the highest AAL check (since the
original MFA rollout in #16813) so that users stuck on the MFA challenge
could still file a ticket. The platform API now rejects AAL1 sessions
with `403 Insufficient AAL: MFA required`, so for those users the form
is simply broken — it renders an error toast and the submit would fail
too.

This requires AAL2 on `/support/new`, so an AAL1 session gets redirected
to the MFA challenge and returns to the form afterwards, and removes the
links to the support form from the MFA screen. A dedicated flow for
users who can't get past MFA to reach us is being worked on separately
and should be out soon!

Fixes FE-4218

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added an “Email support” action for multi-factor authentication
issues, with a prefilled subject line.
- Provided clearer guidance when authentication factors cannot be
retrieved.

- **Bug Fixes**
- Improved authentication error handling based on the session’s
assurance level.
- Reduced confusing permission and error messages for lower-assurance
sessions.
- Updated support page access to use standard authentication behavior
for a more consistent sign-in experience.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-08-21 08:27:37 -06:00

168 lines
5.7 KiB
TypeScript

import { useAuth } from 'common'
import { useRouter } from 'next/router'
import { ComponentType, useCallback, useEffect, useRef, useState } from 'react'
import { toast } from 'sonner'
import { SessionTimeoutModal } from '@/components/interfaces/SignIn/SessionTimeoutModal'
import { usePermissionsQuery } from '@/data/permissions/permissions-query'
import { useAuthenticatorAssuranceLevelQuery } from '@/data/profile/mfa-authenticator-assurance-level-query'
import { useSignOut } from '@/lib/auth'
import { BASE_PATH, IS_PLATFORM } from '@/lib/constants'
import { isNextPageWithLayout, type NextPageWithLayout } from '@/types'
const MAX_TIMEOUT = 10000 // 10 seconds
export function withAuth<T>(
WrappedComponent: ComponentType<T> | NextPageWithLayout<T, T>,
options: {
/**
* The auth level used to check the user credentials. In most cases, if the user has MFA enabled
* we want the highest level (which is 2) for all pages, as the platform API rejects sessions
* that haven't completed the MFA challenge. Only opt out for pages that don't read from the
* platform API and are meant to be reachable before the user has finished signing in.
* @default true
*/
useHighestAAL: boolean
} = { useHighestAAL: true }
) {
// ignore auth in self-hosted
if (!IS_PLATFORM) {
return WrappedComponent
}
const WithAuthHOC: ComponentType<T> = (props) => {
const router = useRouter()
const signOut = useSignOut()
const { isLoading, session } = useAuth()
const timeoutIdRef = useRef<NodeJS.Timeout | null>(null)
const [isSessionTimeoutModalOpen, setIsSessionTimeoutModalOpen] = useState(false)
const {
isPending: isAALLoading,
data: aalData,
isError: isErrorAAL,
isSuccess: isSuccessAAL,
error: errorAAL,
} = useAuthenticatorAssuranceLevelQuery()
const isAtHighestAAL = isSuccessAAL && aalData.currentLevel === aalData.nextLevel
useEffect(() => {
if (isErrorAAL) {
toast.error(
`Failed to fetch authenticator assurance level: ${errorAAL?.message}. Try refreshing your browser, or reach out to us via a support ticket if the issue persists`
)
}
}, [isErrorAAL, errorAAL])
const { isError: isErrorPermissions, error: errorPermissions } = usePermissionsQuery()
useEffect(() => {
if (isErrorPermissions && isAtHighestAAL) {
toast.error(
`Failed to fetch permissions: ${errorPermissions?.message}. Try refreshing your browser, or reach out to us via a support ticket if the issue persists`
)
}
}, [isErrorPermissions, errorPermissions, isAtHighestAAL])
const isLoggedIn = Boolean(session)
const isFinishedLoading = !isLoading && !isAALLoading
const isCorrectLevel = options.useHighestAAL ? isAtHighestAAL : true
const needsMfaElevation = isLoggedIn && !isCorrectLevel
const redirectToSignIn = useCallback(() => {
let pathname = location.pathname
if (BASE_PATH) {
pathname = pathname.replace(BASE_PATH, '')
}
if (pathname === '/sign-in' || pathname === '/sign-in-mfa') {
// If the user is already on the sign in page, we don't need to redirect them
return
}
const searchParams = new URLSearchParams(location.search)
searchParams.set('returnTo', pathname)
if (needsMfaElevation) {
// Session is valid at AAL1 but needs to be elevated to AAL2. Preserve the session
// and send the user to the MFA challenge — typically the IdP-initiated SSO path,
// where the user lands directly on /dashboard without going through /sign-in-mfa.
router.push(`/sign-in-mfa?${searchParams.toString()}`)
return
}
// Sign out before redirecting to sign in page incase the user is stuck in a loading state
signOut().finally(() => {
router.push(`/sign-in?${searchParams.toString()}`)
})
}, [router, signOut, needsMfaElevation])
useEffect(() => {
if (!isFinishedLoading) {
timeoutIdRef.current = setTimeout(() => {
setIsSessionTimeoutModalOpen(true)
}, MAX_TIMEOUT)
} else {
if (timeoutIdRef.current) {
clearTimeout(timeoutIdRef.current)
timeoutIdRef.current = null
}
}
return () => {
if (timeoutIdRef.current) {
clearTimeout(timeoutIdRef.current)
}
}
}, [isFinishedLoading, router, redirectToSignIn])
const shouldRedirect = isFinishedLoading && (!isLoggedIn || !isCorrectLevel)
useEffect(() => {
if (shouldRedirect) {
// Clear the timeout if it's still active and we are redirecting
if (timeoutIdRef.current) {
clearTimeout(timeoutIdRef.current)
timeoutIdRef.current = null
}
redirectToSignIn()
}
}, [redirectToSignIn, shouldRedirect])
const InnerComponent = WrappedComponent as any
const supportContext =
typeof router.query.ref === 'string' && router.pathname.startsWith('/project/')
? {
projectRef: router.query.ref,
...(typeof router.query.organizationSlug === 'string' && {
orgSlug: router.query.organizationSlug,
}),
}
: undefined
return (
<>
<SessionTimeoutModal
visible={isSessionTimeoutModalOpen}
onClose={() => setIsSessionTimeoutModalOpen(false)}
redirectToSignIn={redirectToSignIn}
supportContext={supportContext}
/>
<InnerComponent {...props} />
</>
)
}
WithAuthHOC.displayName = `withAuth(${WrappedComponent.displayName})`
if (isNextPageWithLayout(WrappedComponent)) {
;(WithAuthHOC as NextPageWithLayout<T, T>).getLayout = WrappedComponent.getLayout
}
return WithAuthHOC
}