Files
supabase/apps/studio/components/ui/HighQueryCost.tsx
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

180 lines
5.8 KiB
TypeScript
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
import {
Button,
Dialog,
DialogClose,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogSection,
DialogSectionSeparator,
DialogTitle,
DialogTrigger,
Tooltip,
TooltipContent,
TooltipTrigger,
} from 'ui'
import { Admonition } from 'ui-patterns/Admonition'
import { DocsButton } from './DocsButton'
import { InlineLinkClassName } from './InlineLink'
import { DOCS_URL } from '@/lib/constants'
import { ResponseError } from '@/types'
interface HighQueryCostErrorProps {
error: ResponseError
suggestions?: string[]
onSelectLoadData?: () => void
}
export const HighCostError = ({
error,
suggestions,
onSelectLoadData,
}: HighQueryCostErrorProps) => {
return (
<Admonition
type="default"
title="Data not loaded to protect database performance"
description="The query to retrieve the data was not run as it could place heavy load on the database and impact performance"
>
<div className="mt-2 flex items-center gap-x-2 items-center">
{!!onSelectLoadData && (
<LoadDataWarningDialog error={error} onSelectLoadData={onSelectLoadData} />
)}
<HighQueryCostDialog error={error} suggestions={suggestions} />
</div>
</Admonition>
)
}
const HighQueryCostDialog = ({ error, suggestions = [] }: HighQueryCostErrorProps) => {
const metadata = error.metadata
return (
<Dialog>
<DialogTrigger asChild>
<Button variant="outline">Learn more</Button>
</DialogTrigger>
<DialogContent onOpenAutoFocus={(event) => event.preventDefault()}>
<DialogHeader>
<DialogTitle>Estimated query cost exceeds safety thresholds</DialogTitle>
<DialogDescription>
Preventive measure to mitigate impacting the database
</DialogDescription>
</DialogHeader>
<DialogSectionSeparator />
<DialogSection className="flex flex-col gap-y-2 text-sm">
<p>
The dashboard runs optimized SQL queries on your project’s database to load data for
this interface.
</p>
<p>
However, the query was skipped as its{' '}
<Tooltip>
<TooltipTrigger className={InlineLinkClassName}>estimated cost</TooltipTrigger>
<TooltipContent side="bottom" className="flex flex-col gap-y-1">
<p>Estimated cost: {metadata?.cost.toLocaleString()}</p>
<p className="text-foreground-light">
Determined via the <code className="text-code-inline">EXPLAIN</code> command
</p>
</TooltipContent>
</Tooltip>{' '}
is high and could place significant load on the database with high disk I/O or CPU
usage.
</p>
</DialogSection>
{suggestions.length > 0 && (
<>
<DialogSectionSeparator />
<DialogSection className="flex flex-col gap-y-4 text-sm">
<p className="font-mono text-foreground-lighter uppercase tracking-tight text-sm">
Suggested steps
</p>
{suggestions.length > 0 && (
<div className="flex flex-col gap-y-1">
<p>You may check the following to lower the cost of the query</p>
<ul className="list-disc pl-6">
{suggestions.map((x) => (
<li key={x}>{x}</li>
))}
</ul>
</div>
)}
</DialogSection>
</>
)}
<DialogFooter>
<DocsButton
href={`${DOCS_URL}/guides/troubleshooting/understanding-postgresql-explain-output-Un9dqX`}
/>
<DialogClose asChild>
<Button className="opacity-100">Understood</Button>
</DialogClose>
</DialogFooter>
</DialogContent>
</Dialog>
)
}
const LoadDataWarningDialog = ({
error,
onSelectLoadData,
}: {
error: ResponseError
onSelectLoadData: () => void
}) => {
const metadata = error.metadata
return (
<Dialog>
<DialogTrigger asChild>
<Button>Load data</Button>
</DialogTrigger>
<DialogContent onOpenAutoFocus={(event) => event.preventDefault()}>
<DialogHeader>
<DialogTitle>Confirm to proceed loading data</DialogTitle>
<DialogDescription>
Preventive measure to mitigate impacting the database
</DialogDescription>
</DialogHeader>
<DialogSectionSeparator />
<DialogSection className="flex flex-col gap-y-2 text-sm">
<p>
The query to load your table's data was initially skipped as its{' '}
<Tooltip>
<TooltipTrigger className={InlineLinkClassName}>estimated cost</TooltipTrigger>
<TooltipContent side="bottom" className="flex flex-col gap-y-1">
<p>Estimated cost: {metadata?.cost.toLocaleString()}</p>
<p className="text-foreground-light">
Determined via the <code className="text-code-inline">EXPLAIN</code> command
</p>
</TooltipContent>
</Tooltip>{' '}
is high and could place significant load on the database with high disk I/O or CPU
usage.
</p>
<p>
You may proceed to run the query, and we'll suppress this warning for this table for the
rest of this browser session.
</p>
</DialogSection>
<DialogFooter>
<DialogClose asChild>
<Button className="opacity-100">Cancel</Button>
</DialogClose>
<DialogClose asChild>
<Button variant="warning" onClick={() => onSelectLoadData()}>
I understand, proceed
</Button>
</DialogClose>
</DialogFooter>
</DialogContent>
</Dialog>
)
}