mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 01:45:10 +03:00
## What kind of change does this PR introduce? Mechanical cleanup on top of the Button default-variant change (#50160). ## What is the current behavior? Many callsites still pass `variant="default"` even though that is now the component default. ## What is the new behavior? Removes redundant static `variant="default"` from legacy `Button` and `ButtonTooltip` callsites. Keeps explicit defaults where they document the API: - `button-default.tsx` and `button-sizes.tsx` demos - `DocsButton`, which pins neutral styling at the wrapper boundary ## To test Studio: - [Auth → Rate Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits): dirty the form so Cancel appears; Cancel stays neutral, Save stays green - [Project Settings → API Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys): `DocsButton` in the header actions stays neutral Design system: - [Design system → Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button): `button-default` / `button-sizes` still show explicit default styling; Primary (green) is restricted to the Primary section (and `asChild`) WWW: - [www → Brand assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets): Download logo kit / Download button kit stay neutral
50 lines
1.3 KiB
TypeScript
50 lines
1.3 KiB
TypeScript
import { Button } from 'ui'
|
|
|
|
interface Props {
|
|
form: React.HTMLProps<HTMLButtonElement>['form']
|
|
hasChanges: boolean | undefined // Disables submit button if false
|
|
handleReset: () => void // Handling a reset/cancel of the form
|
|
helper?: React.ReactNode // Helper text to show alongside actions
|
|
disabled?: boolean
|
|
isSubmitting?: boolean
|
|
submitText?: string
|
|
}
|
|
|
|
export const FormActions = ({
|
|
form,
|
|
hasChanges = undefined,
|
|
handleReset,
|
|
helper,
|
|
disabled = false,
|
|
isSubmitting,
|
|
submitText = 'Save',
|
|
}: Props) => {
|
|
const isDisabled = isSubmitting || disabled || (!hasChanges && hasChanges !== undefined)
|
|
|
|
return (
|
|
<div
|
|
className={[
|
|
'flex w-full items-center gap-2',
|
|
// justify actions to right if no helper text
|
|
helper ? 'justify-between' : 'justify-end',
|
|
].join(' ')}
|
|
>
|
|
{helper && <span className="text-sm text-foreground-lighter">{helper}</span>}
|
|
<div className="flex items-center gap-2">
|
|
<Button disabled={isDisabled} type="reset" onClick={() => handleReset()}>
|
|
Cancel
|
|
</Button>
|
|
<Button
|
|
form={form}
|
|
variant="primary"
|
|
type="submit"
|
|
disabled={isDisabled}
|
|
loading={isSubmitting}
|
|
>
|
|
{submitText}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|