Files
supabase/apps/studio/components/ui/Charts/ReportSettings.tsx
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

56 lines
1.9 KiB
TypeScript

import { Settings } from 'lucide-react'
import { useState } from 'react'
import { Label, Popover, PopoverContent, PopoverTrigger, Switch } from 'ui'
import { useChartHoverState } from './useChartHoverState'
import { ButtonTooltip } from '@/components/ui/ButtonTooltip'
interface ReportSettingsProps {
chartId: string
}
export const ReportSettings = ({ chartId }: ReportSettingsProps) => {
const [isOpen, setIsOpen] = useState(false)
const { syncHover, syncTooltip, setSyncHover, setSyncTooltip } = useChartHoverState(chartId)
return (
<Popover open={isOpen} onOpenChange={setIsOpen}>
<PopoverTrigger asChild>
<ButtonTooltip
icon={<Settings />}
className="w-7"
tooltip={{ content: { side: 'bottom', text: 'Report settings' } }}
/>
</PopoverTrigger>
<PopoverContent align="center" side="bottom" className="w-64 p-3 flex flex-col gap-y-4">
<div className="flex items-start justify-between space-x-2">
<Label htmlFor="sync-hover" className="text-xs">
<p>Sync chart headers</p>
<p className="text-xs text-foreground-light mt-1 text-balance">
Hovering over any chart will update headers across all charts
</p>
</Label>
<Switch id="sync-hover" checked={syncHover} onCheckedChange={setSyncHover} />
</div>
{syncHover && (
<div className="flex items-start justify-between space-x-2">
<Label htmlFor="sync-tooltips" className="text-xs">
<p>Sync tooltips</p>
<p className="text-xs text-foreground-light mt-1 text-balance">
Shows tooltips on all charts
</p>
</Label>
<Switch
id="sync-tooltips"
checked={syncTooltip}
disabled={!syncHover}
onCheckedChange={setSyncTooltip}
/>
</div>
)}
</PopoverContent>
</Popover>
)
}