mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 09:55:06 +03:00
<img width="913" height="572" alt="image" src="https://github.com/user-attachments/assets/e8112085-508a-49e4-abb1-7550248e611e" /> ## Problem A single Assistant response often produces 10+ reasoning and lookup rows ("Reasoned", "Ran search_docs", …). They push the answer down the chat, use raw tool names, and a fast tool call flashes past before the row goes back to "Thinking...". ## Solution Consecutive reasoning and lookup rows fold into one collapsible group. - **Running:** the header shows a tool only while it executes ("Checking policies in public..."). Between calls it reads "Thinking...", however long that lasts. Each header label stays up for at least 1 second, so quick calls no longer flash. - **Finished:** the header lists what the tools did, e.g. "Searched docs and checked policies", or "…, and 2 more". - **Expanded (any time):** every call is listed under a vertical rule. Rows still in progress shimmer, including several at once for parallel calls. ## How to test 1. Run `pnpm dev:studio` and open the Assistant on a project with a few tables. 2. Ask something that needs several lookups, e.g. "What RLS policies do I have and what do the docs recommend for them?" 3. While it streams, check the collapsed header: - It shows each tool while it runs, then goes back to "Thinking..." between calls. - Labels don't flash. Each stays up for about a second. - Only the shimmer marks progress, with no blinking cursor underneath. 4. Expand the group mid-stream. Rows read like "Checking policies in public..." rather than tool names, and only rows still in progress shimmer. 5. When it finishes, the header lists the actions ("Searched docs and checked policies") and stops shimmering. 6. Press Stop while a group is running. The unfinished row reads "Response interrupted" and stops spinning. 7. Reload the chat. Older groups show their collapsed summaries. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * AI assistant tool activity is grouped into collapsible sections with progress labels while work is underway and summaries when complete. * Expand grouped activity to review reasoning and tool details. Active tools and reasoning are highlighted, while completed reasoning without text is hidden. * Progress labels remain visible briefly during transitions, and active responses display a shimmer effect. * **Bug Fixes** * The loading indicator no longer appears while the assistant is processing a tool group. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
248 lines
8.4 KiB
TypeScript
248 lines
8.4 KiB
TypeScript
import { fireEvent, render, screen } from '@testing-library/react'
|
|
import type { UIMessage } from 'ai'
|
|
import { useState } from 'react'
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
import { Message } from './Message'
|
|
|
|
const { renderQuery, renderFunction, renderMarkdown } = vi.hoisted(() => ({
|
|
renderQuery: vi.fn(),
|
|
renderFunction: vi.fn(),
|
|
renderMarkdown: vi.fn(),
|
|
}))
|
|
|
|
// Keep the message/context/part pipeline real, substituting stateful probes for the
|
|
// expensive leaves so we can detect both extra renders and lost local state.
|
|
vi.mock('./AssistantQueryCell', () => ({
|
|
AssistantQueryCell: (props: { initialResult?: { rows: unknown[] }; onApprove?: () => void }) => {
|
|
renderQuery(props)
|
|
const [runs, setRuns] = useState(0)
|
|
return (
|
|
<div>
|
|
<button tabIndex={0} onClick={() => setRuns((count) => count + 1)}>
|
|
Run count: {runs}
|
|
</button>
|
|
<button tabIndex={0} onClick={props.onApprove}>
|
|
Approve query
|
|
</button>
|
|
<output>{JSON.stringify(props.initialResult?.rows)}</output>
|
|
</div>
|
|
)
|
|
},
|
|
}))
|
|
|
|
vi.mock('./EdgeFunctionRenderer', () => ({
|
|
EdgeFunctionRenderer: (props: { code: string }) => {
|
|
renderFunction(props)
|
|
return <pre>{props.code}</pre>
|
|
},
|
|
}))
|
|
|
|
vi.mock('./MessageMarkdown', () => ({
|
|
MessageMarkdown: ({ children }: { children: string }) => {
|
|
renderMarkdown(children)
|
|
return <p>{children}</p>
|
|
},
|
|
}))
|
|
|
|
vi.mock('./Message.Actions', () => ({ MessageActions: () => null }))
|
|
|
|
const initialMessage: UIMessage = {
|
|
id: 'assistant-1',
|
|
role: 'assistant',
|
|
parts: [
|
|
{
|
|
type: 'tool-execute_sql',
|
|
toolCallId: 'query-1',
|
|
state: 'approval-requested',
|
|
approval: { id: 'approval-1' },
|
|
input: { sql: 'select 1', label: 'Query', view: 'table' },
|
|
},
|
|
{
|
|
type: 'tool-deploy_edge_function',
|
|
toolCallId: 'function-1',
|
|
state: 'input-available',
|
|
input: {
|
|
code: 'Deno.serve(() => new Response("hello"))',
|
|
label: 'Function',
|
|
functionName: 'hello',
|
|
},
|
|
},
|
|
{ type: 'text', text: 'Working' },
|
|
],
|
|
}
|
|
|
|
const callbacks = {
|
|
onDelete: vi.fn(),
|
|
onEdit: vi.fn(),
|
|
onBranch: vi.fn(),
|
|
onCancelEdit: vi.fn(),
|
|
addToolApprovalResponse: vi.fn(),
|
|
}
|
|
|
|
function FeedMessage({
|
|
message = initialMessage,
|
|
isLoading = true,
|
|
addToolApprovalResponse = callbacks.addToolApprovalResponse,
|
|
}: {
|
|
message?: UIMessage
|
|
isLoading?: boolean
|
|
addToolApprovalResponse?: typeof callbacks.addToolApprovalResponse
|
|
}) {
|
|
return (
|
|
<Message
|
|
{...callbacks}
|
|
id={message.id}
|
|
message={message}
|
|
isLoading={isLoading}
|
|
isLastMessage
|
|
isAfterEditedMessage={false}
|
|
isBeingEdited={false}
|
|
addToolApprovalResponse={addToolApprovalResponse}
|
|
/>
|
|
)
|
|
}
|
|
|
|
describe('assistant feed rendering', () => {
|
|
beforeEach(() => vi.clearAllMocks())
|
|
|
|
it('does not rerender unchanged history when the parent renders', () => {
|
|
const { rerender } = render(<FeedMessage />)
|
|
const counts = [
|
|
renderQuery.mock.calls.length,
|
|
renderFunction.mock.calls.length,
|
|
renderMarkdown.mock.calls.length,
|
|
]
|
|
|
|
rerender(<FeedMessage />)
|
|
|
|
expect([
|
|
renderQuery.mock.calls.length,
|
|
renderFunction.mock.calls.length,
|
|
renderMarkdown.mock.calls.length,
|
|
]).toEqual(counts)
|
|
})
|
|
|
|
it('updates streamed text without rerendering cloned tools or losing their local state', () => {
|
|
const { rerender } = render(<FeedMessage />)
|
|
fireEvent.click(screen.getByRole('button', { name: 'Run count: 0' }))
|
|
const queryRenders = renderQuery.mock.calls.length
|
|
const functionRenders = renderFunction.mock.calls.length
|
|
|
|
const updated = structuredClone(initialMessage)
|
|
updated.parts[2] = { type: 'text', text: 'Working on the next step' }
|
|
rerender(<FeedMessage message={updated} />)
|
|
|
|
expect(screen.getByText('Working on the next step')).toBeInTheDocument()
|
|
expect(screen.getByRole('button', { name: 'Run count: 1' })).toBeInTheDocument()
|
|
expect(renderQuery).toHaveBeenCalledTimes(queryRenders)
|
|
expect(renderFunction).toHaveBeenCalledTimes(functionRenders)
|
|
})
|
|
|
|
it('updates tool output and code when their content changes', () => {
|
|
const { rerender } = render(<FeedMessage />)
|
|
const updated = structuredClone(initialMessage)
|
|
updated.parts[0] = {
|
|
type: 'tool-execute_sql',
|
|
toolCallId: 'query-1',
|
|
state: 'output-available',
|
|
input: { sql: 'select 1', label: 'Query', view: 'table' },
|
|
output: [{ value: 1 }],
|
|
}
|
|
updated.parts[1] = {
|
|
type: 'tool-deploy_edge_function',
|
|
toolCallId: 'function-1',
|
|
state: 'input-available',
|
|
input: { code: 'updated code', label: 'Function', functionName: 'hello' },
|
|
}
|
|
rerender(<FeedMessage message={updated} />)
|
|
|
|
expect(screen.getByText('[{"value":1}]')).toBeInTheDocument()
|
|
expect(screen.getByText('updated code')).toBeInTheDocument()
|
|
})
|
|
|
|
it('uses the latest approval callback even when the tool part is unchanged', () => {
|
|
const { rerender } = render(<FeedMessage />)
|
|
const approve = vi.fn()
|
|
rerender(<FeedMessage addToolApprovalResponse={approve} />)
|
|
fireEvent.click(screen.getByRole('button', { name: 'Approve query' }))
|
|
|
|
expect(approve).toHaveBeenCalledWith({ id: 'approval-1', approved: true })
|
|
expect(callbacks.addToolApprovalResponse).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('retains query state when streaming completes', () => {
|
|
const { rerender } = render(<FeedMessage />)
|
|
fireEvent.click(screen.getByRole('button', { name: 'Run count: 0' }))
|
|
rerender(<FeedMessage isLoading={false} />)
|
|
expect(screen.getByRole('button', { name: 'Run count: 1' })).toBeInTheDocument()
|
|
})
|
|
|
|
it('finishes reasoning when the SDK mutates the first streamed part before publishing a snapshot', () => {
|
|
const reasoning = {
|
|
type: 'reasoning' as const,
|
|
text: 'Looking at the schema',
|
|
state: 'streaming' as 'streaming' | 'done',
|
|
}
|
|
const message: UIMessage = { id: 'reasoning-1', role: 'assistant', parts: [reasoning] }
|
|
const { rerender } = render(<FeedMessage message={message} />)
|
|
// Expand the tool group so the reasoning row itself is rendered
|
|
fireEvent.click(screen.getByRole('button', { name: 'Thinking...' }))
|
|
// The group header and the reasoning row
|
|
expect(screen.getAllByText('Thinking...')).toHaveLength(2)
|
|
|
|
// Chat.pushMessage exposes the initial object; subsequent replaceMessage calls clone it.
|
|
reasoning.state = 'done'
|
|
rerender(<FeedMessage message={structuredClone(message)} isLoading={false} />)
|
|
|
|
expect(screen.queryByText('Thinking...')).not.toBeInTheDocument()
|
|
expect(screen.getAllByText('Reasoned')).toHaveLength(2)
|
|
})
|
|
|
|
it('keeps a tool group running while a call in it outlasts a later block', () => {
|
|
const message: UIMessage = {
|
|
id: 'parallel-1',
|
|
role: 'assistant',
|
|
parts: [
|
|
{ type: 'tool-search_docs', toolCallId: 'docs-1', state: 'input-available', input: {} },
|
|
{ type: 'text', text: 'Checking your schema' },
|
|
],
|
|
}
|
|
render(<FeedMessage message={message} />)
|
|
|
|
expect(screen.getByRole('button', { name: 'Searching docs...' })).toBeInTheDocument()
|
|
})
|
|
|
|
it('updates text when the SDK mutates the first streamed part', () => {
|
|
const text = { type: 'text' as const, text: 'First token', state: 'streaming' as const }
|
|
const message: UIMessage = { id: 'text-1', role: 'assistant', parts: [text] }
|
|
const { rerender } = render(<FeedMessage message={message} />)
|
|
|
|
text.text = 'First token and the rest of the response'
|
|
rerender(<FeedMessage message={structuredClone(message)} />)
|
|
|
|
expect(screen.getByText(text.text)).toBeInTheDocument()
|
|
})
|
|
|
|
it('updates a tool when its initial input-streaming part is mutated to a completed result', () => {
|
|
const tool = {
|
|
type: 'tool-execute_sql' as const,
|
|
toolCallId: 'query-1',
|
|
state: 'input-streaming' as const,
|
|
}
|
|
const message: UIMessage = { id: 'tool-1', role: 'assistant', parts: [tool] }
|
|
const { rerender } = render(<FeedMessage message={message} />)
|
|
expect(screen.getByText('Writing SQL...')).toBeInTheDocument()
|
|
|
|
Object.assign(tool, {
|
|
state: 'output-available',
|
|
input: { sql: 'select 1' },
|
|
output: [{ value: 1 }],
|
|
})
|
|
rerender(<FeedMessage message={structuredClone(message)} isLoading={false} />)
|
|
|
|
expect(screen.queryByText('Writing SQL...')).not.toBeInTheDocument()
|
|
expect(screen.getByText('[{"value":1}]')).toBeInTheDocument()
|
|
})
|
|
})
|