Files
supabase/apps/studio/components/layouts/AppLayout/ProjectDropdown.tsx
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

193 lines
6.3 KiB
TypeScript

import { useParams } from 'common'
import { Box, Plus } from 'lucide-react'
import Link from 'next/link'
import { useRouter } from 'next/router'
import type { ComponentProps } from 'react'
import { useState } from 'react'
import { Button, CommandGroup } from 'ui'
import { ShimmeringLoader } from 'ui-patterns/ShimmeringLoader'
import { AppLayoutDropdownTriggerButton } from './AppLayoutDropdown'
import { sanitizeRoute } from './ProjectDropdown.utils'
import { ProjectRowLink } from './ProjectRowLink'
import { useEmbeddedCloseHandler } from './useEmbeddedCloseHandler'
import { CommandItemLink } from '@/components/ui/CommandItemLink'
import { OrganizationProjectSelector } from '@/components/ui/OrganizationProjectSelector'
import PartnerIcon from '@/components/ui/PartnerIcon'
import { getManagedByFromOrganizationPartner } from '@/data/organizations/managed-by-utils'
import type { OrgProject } from '@/data/projects/org-projects-infinite-query'
import { useProjectDetailQuery } from '@/data/projects/project-detail-query'
import { useIsFeatureEnabled } from '@/hooks/misc/useIsFeatureEnabled'
import { useSelectedOrganizationQuery } from '@/hooks/misc/useSelectedOrganization'
import { useSelectedProjectQuery } from '@/hooks/misc/useSelectedProject'
import { IS_PLATFORM } from '@/lib/constants'
import type { ManagedBy } from '@/lib/constants/infrastructure'
import { useTrack } from '@/lib/telemetry/track'
// --- Sub-components ---
interface ProjectDropdownNewProjectActionsProps {
organizationSlug: string | undefined
embedded: boolean
onClose: () => void
}
function ProjectDropdownNewProjectActions({
organizationSlug,
embedded,
onClose,
}: ProjectDropdownNewProjectActionsProps) {
const href = `/new/${organizationSlug}`
if (embedded) {
return (
<Button block size="small" asChild icon={<Plus size={14} strokeWidth={1.5} />}>
<Link
href={href}
onClick={onClose}
className="text-xs text-foreground-light hover:text-foreground"
>
New project
</Link>
</Button>
)
}
return (
<CommandGroup>
<CommandItemLink href={href} className="cursor-pointer w-full gap-2" onSelect={onClose}>
<Plus size={14} strokeWidth={1.5} />
<p>New project</p>
</CommandItemLink>
</CommandGroup>
)
}
const ProjectDropdownNonPlatformView = ({ projectName }: { projectName: string }) => {
return <div className="text-sm px-3 py-1">{projectName}</div>
}
interface ProjectDropdownPlatformViewProps {
projectRef: string | undefined
projectName: string
projectManagedBy?: ManagedBy
selectorProps: Omit<
ComponentProps<typeof OrganizationProjectSelector>,
'renderTrigger' | 'embedded'
>
}
function ProjectDropdownPlatformView({
projectRef,
projectName,
projectManagedBy,
selectorProps,
}: ProjectDropdownPlatformViewProps) {
return (
<div className="flex items-center shrink-0">
<Link href={`/project/${projectRef}`} className="flex items-center gap-2 shrink-0 text-sm">
<Box size={14} strokeWidth={1.5} className="text-foreground-lighter" />
<span title={projectName} className="text-foreground max-w-32 lg:max-w-64 truncate">
{projectName}
</span>
{projectManagedBy && <PartnerIcon organization={{ managed_by: projectManagedBy }} />}
</Link>
<OrganizationProjectSelector
{...selectorProps}
renderTrigger={() => (
<AppLayoutDropdownTriggerButton
className="shrink-0"
aria-label="Show organization projects"
/>
)}
/>
</div>
)
}
// --- Main component ---
interface ProjectDropdownProps {
embedded?: boolean
className?: string
onClose?: () => void
}
export const ProjectDropdown = ({
embedded = false,
className,
onClose,
}: ProjectDropdownProps = {}) => {
const router = useRouter()
const { ref } = useParams()
const { data: project, isPending: isLoadingProject } = useSelectedProjectQuery()
const { data: selectedOrganization } = useSelectedOrganizationQuery()
const isBranch = project?.parentRef !== project?.ref
const { data: parentProject, isPending: isLoadingParentProject } = useProjectDetailQuery(
{ ref: project?.parent_project_ref },
{ enabled: isBranch }
)
const selectedProject = parentProject ?? project
const projectCreationEnabled = useIsFeatureEnabled('projects:create')
const track = useTrack()
const [open, setOpen] = useState(false)
const close = useEmbeddedCloseHandler(embedded, onClose, setOpen)
const selectedProjectManagedBy = selectedProject?.integration_source
? getManagedByFromOrganizationPartner(undefined, selectedProject.integration_source)
: selectedOrganization?.billing_partner
? selectedOrganization.managed_by
: undefined
if (isLoadingProject || (isBranch && isLoadingParentProject) || !selectedProject) {
if (!embedded) return <ShimmeringLoader className="p-2 md:mr-2 md:w-[90px]" />
}
const handleSetOpen = embedded
? (_value: boolean) => onClose?.()
: (next: boolean) => {
if (next) track('header_project_dropdown_opened')
setOpen(next)
}
const selectorProps = {
open,
setOpen: handleSetOpen,
selectedRef: ref,
getItemHref: (project: { ref: string }) => {
const sanitizedRoute = sanitizeRoute(router.route, router.query)
return sanitizedRoute?.replace('[ref]', project.ref) ?? `/project/${project.ref}`
},
renderRow: (project: Pick<OrgProject, 'ref' | 'name' | 'status' | 'integration_source'>) => (
<ProjectRowLink project={project} selectedRef={ref} />
),
renderActions: (_setOpen: (value: boolean) => void, options?: { embedded?: boolean }) =>
projectCreationEnabled ? (
<ProjectDropdownNewProjectActions
organizationSlug={selectedOrganization?.slug}
embedded={options?.embedded ?? false}
onClose={close}
/>
) : null,
}
if (embedded)
return (
<OrganizationProjectSelector {...selectorProps} embedded className={className} fetchOnMount />
)
return IS_PLATFORM ? (
<ProjectDropdownPlatformView
projectRef={project?.ref}
projectName={selectedProject?.name ?? ''}
projectManagedBy={selectedProjectManagedBy}
selectorProps={selectorProps}
/>
) : (
<ProjectDropdownNonPlatformView projectName={selectedProject?.name ?? ''} />
)
}