Files
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

156 lines
5.2 KiB
TypeScript

import { useParams } from 'common'
import { Database as DatabaseIcon } from 'icons'
import { Loader2, Minus, MoreVertical, RotateCcw, Trash } from 'lucide-react'
import Link from 'next/link'
import { useMemo, useState } from 'react'
import { AWS_REGIONS } from 'shared-data'
import {
Badge,
Button,
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuSeparator,
DropdownMenuTrigger,
TableCell,
TableRow,
Tooltip,
TooltipContent,
TooltipTrigger,
} from 'ui'
import { ShimmeringLoader } from 'ui-patterns/ShimmeringLoader'
import { DropReplicaConfirmationModal } from './DropReplicaConfirmationModal'
import { REPLICA_STATUS } from './ReadReplicas.constants'
import { getIsInTransition, getStatusLabel } from './ReadReplicas.utils'
import { RestartReplicaConfirmationModal } from './RestartReplicaConfirmationModal'
import { getReadReplicaPath } from '@/components/interfaces/Settings/Infrastructure/Infrastructure.utils'
import { useReplicationLagQuery } from '@/data/read-replicas/replica-lag-query'
import { type Database } from '@/data/read-replicas/replicas-query'
import { formatDatabaseID } from '@/data/read-replicas/replicas.utils'
interface ReadReplicaRow {
replica: Database
onUpdateReplica: () => void
}
export const ReadReplicaRow = ({ replica, onUpdateReplica }: ReadReplicaRow) => {
const { ref } = useParams()
const { identifier, region, status } = replica
const formattedId = formatDatabaseID(identifier ?? '')
const {
data: lagDuration,
isPending: isLoadingLag,
isError: isErrorLag,
} = useReplicationLagQuery(
{
id: identifier,
projectRef: ref,
connectionString: replica.connectionString,
},
{ enabled: status === REPLICA_STATUS.ACTIVE_HEALTHY }
)
const [showConfirmRestart, setShowConfirmRestart] = useState(false)
const [showConfirmDrop, setShowConfirmDrop] = useState(false)
const regionMeta = Object.values(AWS_REGIONS).find((x) => x.code === region)
const isInTransition = useMemo(() => getIsInTransition({ status }), [status])
const statusLabel = useMemo(() => getStatusLabel({ status }), [status])
return (
<>
<TableRow>
<TableCell>
<DatabaseIcon size={18} className="text-foreground-light" />
</TableCell>
<TableCell>
<div>
<p>Read Replica (ID: {formattedId})</p>
<Tooltip>
<TooltipTrigger asChild>
<p className="text-foreground-lighter w-fit">{regionMeta?.displayName}</p>
</TooltipTrigger>
<TooltipContent side="right">{regionMeta?.code}</TooltipContent>
</Tooltip>
</div>
</TableCell>
<TableCell>
<div className="flex items-center gap-x-2">
<Badge
variant={
statusLabel === 'Healthy'
? 'success'
: statusLabel === 'Failed'
? 'destructive'
: 'default'
}
>
{statusLabel}
</Badge>
{isInTransition && <Loader2 className="animate-spin w-3 h-3" />}
</div>
</TableCell>
<TableCell>
{isErrorLag || status !== REPLICA_STATUS.ACTIVE_HEALTHY ? (
<Minus size={18} className="text-foreground-lighter" />
) : isLoadingLag ? (
<ShimmeringLoader />
) : (
<p>{lagDuration}s</p>
)}
</TableCell>
<TableCell>
<div className="flex items-center justify-end gap-x-2">
<Button asChild className="relative" disabled={status === 'GOING_DOWN'}>
<Link href={getReadReplicaPath(ref, replica.identifier)}>View replica</Link>
</Button>
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button icon={<MoreVertical />} className="w-7" />
</DropdownMenuTrigger>
<DropdownMenuContent align="end" className="w-52">
<DropdownMenuItem
className="gap-x-2"
disabled={status !== 'ACTIVE_HEALTHY'}
onClick={() => setShowConfirmRestart(true)}
>
<RotateCcw size={14} />
<span>Restart replica</span>
</DropdownMenuItem>
<DropdownMenuSeparator />
<DropdownMenuItem
className="gap-x-2"
disabled={status === 'GOING_DOWN'}
onClick={() => setShowConfirmDrop(true)}
>
<Trash size={14} />
<span>Drop replica</span>
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenu>
</div>
</TableCell>
</TableRow>
<DropReplicaConfirmationModal
selectedReplica={showConfirmDrop ? replica : undefined}
onSuccess={() => onUpdateReplica()}
onCancel={() => setShowConfirmDrop(false)}
/>
<RestartReplicaConfirmationModal
selectedReplica={showConfirmRestart ? replica : undefined}
onSuccess={() => onUpdateReplica()}
onCancel={() => setShowConfirmRestart(false)}
/>
</>
)
}