Files
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

133 lines
5.3 KiB
TypeScript
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
import { useState } from 'react'
import { toast } from 'sonner'
import { Button } from 'ui'
import { Admonition } from 'ui-patterns/Admonition'
import ConfirmationModal from 'ui-patterns/Dialogs/ConfirmationModal'
import { DocsButton } from '@/components/ui/DocsButton'
import Panel from '@/components/ui/Panel'
import { useProjectSettingsV2Query } from '@/data/config/project-settings-v2-query'
import { useCheckCNAMERecordMutation } from '@/data/custom-domains/check-cname-mutation'
import { useCustomDomainActivateMutation } from '@/data/custom-domains/custom-domains-activate-mutation'
import { useCustomDomainDeleteMutation } from '@/data/custom-domains/custom-domains-delete-mutation'
import type { CustomDomainResponse } from '@/data/custom-domains/custom-domains-query'
import { DOCS_URL } from '@/lib/constants'
export type CustomDomainActivateProps = {
projectRef?: string
customDomain: CustomDomainResponse
}
export const CustomDomainActivate = ({ projectRef, customDomain }: CustomDomainActivateProps) => {
const [isActivateConfirmModalVisible, setIsActivateConfirmModalVisible] = useState(false)
const { data: settings } = useProjectSettingsV2Query({ projectRef })
const { mutate: checkCNAMERecord, isPending: isCheckingRecord } = useCheckCNAMERecordMutation()
const { mutate: activateCustomDomain, isPending: isActivating } = useCustomDomainActivateMutation(
{
onSuccess: () => {
toast.success(`Successfully activated custom domain`)
setIsActivateConfirmModalVisible(false)
},
}
)
const { mutate: deleteCustomDomain, isPending: isDeleting } = useCustomDomainDeleteMutation({
onSuccess: () => {
toast.success(
'Custom domain setup cancelled successfully. It may take a few seconds before your custom domain is fully removed, so you may need to refresh your browser.'
)
},
})
const endpoint = settings?.app_config?.endpoint
const onActivateCustomDomain = async () => {
if (!projectRef) return console.error('Project ref is required')
checkCNAMERecord(
{ domain: customDomain.hostname },
{ onSuccess: () => activateCustomDomain({ projectRef }) }
)
}
const onCancelCustomDomain = async () => {
if (!projectRef) return console.error('Project ref is required')
deleteCustomDomain({ projectRef })
}
return (
<>
<div className="flex flex-col items-start">
<Panel.Content>
<div className="flex flex-col gap-2">
<h4 className="text-foreground">Enable your custom domain</h4>
<p className="text-sm text-foreground-light">
Set up is almost complete. Press “Activate” below to enable{' '}
<code className="text-code-inline">{customDomain.hostname}</code> for this project.
</p>
<p className="text-sm text-foreground-light">
We recommend that you schedule a downtime window of 20 - 30 minutes for your
application, as you will need to update any services that need to know about your
custom domain (e.g client side code or OAuth providers).
</p>
</div>
<div className="mt-4">
<Admonition
type="note"
title="Retain your CNAME record for service continuity after activation"
>
<p>
Your custom domain CNAME record for{' '}
<code className="text-code-inline">{customDomain.hostname}</code> should resolve to{' '}
{endpoint ? (
<code className="text-code-inline">{endpoint}</code>
) : (
"your project's API URL"
)}
. If you're using Cloudflare as your DNS provider, disable the proxy option.
</p>
</Admonition>
</div>
</Panel.Content>
<div className="w-full border-t border-muted" />
<Panel.Content className="w-full">
<div className="flex items-center justify-between">
<DocsButton href={`${DOCS_URL}/guides/platform/custom-domains`} />
<div className="flex items-center space-x-2">
<Button className="self-end" onClick={onCancelCustomDomain} loading={isDeleting}>
Cancel
</Button>
<Button
variant="primary"
disabled={isDeleting}
onClick={() => setIsActivateConfirmModalVisible(true)}
className="self-end"
>
Activate
</Button>
</div>
</div>
</Panel.Content>
</div>
<ConfirmationModal
size="small"
loading={isCheckingRecord || isActivating}
visible={isActivateConfirmModalVisible}
title="Activate custom domain"
confirmLabel="Activate"
confirmLabelLoading="Activating"
onCancel={() => setIsActivateConfirmModalVisible(false)}
onConfirm={onActivateCustomDomain}
>
<p className="text-sm">
Activating <code className="text-code-inline break-normal!">{customDomain.hostname}</code>{' '}
will make it visible to users in place of your project’s Supabase domain. The Supabase
domain will continue to work too.
</p>
</ConfirmationModal>
</>
)
}