mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 09:55:06 +03:00
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? Chore / build (ESLint config upgrade + lint cleanup). ## What is the current behavior? `eslint-plugin-react-hooks` v5 (pulled in transitively by `eslint-config-next` v15) doesn't recognize stable `useEffectEvent`, so every effect that calls an effect-event handler needs an `eslint-disable react-hooks/exhaustive-deps` to silence a false positive. There are 30 such dead disables across Studio. ## What is the new behavior? Bumps `eslint-config-next` to v16, which pulls in `eslint-plugin-react-hooks` v7 whose `exhaustive-deps` understands `useEffectEvent`, and removes the 30 now-dead disable directives (and their orphaned explanatory comments). Supporting changes: - **Flat-config migration**: v16 is a native flat-config array (v15 was eslintrc), so `eslint-config-supabase` now spreads it directly instead of bridging through `FlatCompat`. - **React Compiler rules off**: v16 enables react-hooks v7's `recommended`, which layers the React Compiler lint rules on top of the two classic rules. These are switched off (derived dynamically from what next enables) to keep this change scoped to the `exhaustive-deps` improvement. - **Plugin-registration fallout** (v16 scopes plugin registration to a file glob rather than registering globally like FlatCompat did): stop re-registering `@typescript-eslint` (shared) and `jsx-a11y` (studio); scope our react / react-hooks / jsx-a11y rule overrides (studio, www) to v16's plugin glob so they don't error on files outside it (e.g. `.cjs`). - **Lint surface preserved**: v16's glob newly includes `.mts`/`.cts` (v15 didn't lint them), which surfaced pre-existing errors in tooling scripts. The shared config keeps the prior surface by leaving `.mts`/`.cts` unlinted; linting them is left as a separate change. - **Ratchet**: rebaselines `@tanstack/query/exhaustive-deps` 9 → 89. v15 forced next's `@babel/eslint-parser` onto `.ts` files, hiding these deps; v16 parses `.ts` with `@typescript-eslint/parser` and correctly surfaces the intentional `connectionString`-excluded-from-`queryKey` pattern. Worth a follow-up to review whether any are real cache-correctness bugs. - Drops three now-dead devDeps from `eslint-config-supabase`: `@eslint/eslintrc`, `@eslint/js`, `@typescript-eslint/eslint-plugin`. Verified locally: `turbo run lint` → 7/7 packages pass with 0 errors; Studio `lint:ratchet` passes; Prettier clean on changed files; typecheck unaffected. ## Additional context <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Refined linting configuration and removed outdated lint suppressions across Studio. * Updated Next.js linting support and refreshed related development configuration. * Expanded lint baseline coverage for query-related code. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
83 lines
3.7 KiB
TypeScript
83 lines
3.7 KiB
TypeScript
import { useParams } from 'common'
|
|
import { useRouter } from 'next/router'
|
|
import { useEffect, useEffectEvent } from 'react'
|
|
|
|
import { parseSqlSnippetSource } from './querySource'
|
|
import { createSqlSnippetSkeletonV2 } from './SQLEditor.utils'
|
|
import { useSelectedProjectQuery } from '@/hooks/misc/useSelectedProject'
|
|
import { useProfile } from '@/lib/profile'
|
|
import { wasNeverPersisted } from '@/state/sql-editor/sql-editor-lifecycle'
|
|
import { canEditSnippet } from '@/state/sql-editor/sql-editor-rules'
|
|
import { useSqlEditorV2StateSnapshot } from '@/state/sql-editor/sql-editor-state'
|
|
import { useTabsStateSnapshot } from '@/state/tabs'
|
|
|
|
/**
|
|
* Owns the editing lifecycle of a single SQL snippet: creating the snippet in
|
|
* the store on first edit (and routing to its URL), writing changes back to the
|
|
* store via `setSql`, and seeding the editor from a `?content=` deep link.
|
|
*
|
|
* Edits are written to the store synchronously on every change; debouncing the
|
|
* actual persistence is the save mechanism's job (see `createSaveMechanism`), so
|
|
* the store — and therefore the snippet's dirty status — always reflects the
|
|
* latest edit immediately.
|
|
*
|
|
* Extracted from `MonacoEditor` so that component stays a thin editor shell.
|
|
*/
|
|
export function useSnippetEditor({ id, snippetName }: { id: string; snippetName: string }) {
|
|
const router = useRouter()
|
|
const { profile } = useProfile()
|
|
const { ref, content, source } = useParams()
|
|
const { data: project } = useSelectedProjectQuery()
|
|
|
|
const snapV2 = useSqlEditorV2StateSnapshot()
|
|
const tabsSnap = useTabsStateSnapshot()
|
|
|
|
const snippet = snapV2.snippets[id]
|
|
const disableEdit = !!snippet && !canEditSnippet(snippet.snippet, profile?.id)
|
|
|
|
function handleEditorChange(value: string | undefined) {
|
|
tabsSnap.makeActiveTabPermanent()
|
|
if (!id || !value) return
|
|
|
|
if (!snippet && ref && profile !== undefined && project !== undefined) {
|
|
const newSnippet = createSqlSnippetSkeletonV2({
|
|
idOverride: id,
|
|
name: snippetName,
|
|
sql: value,
|
|
owner_id: profile?.id,
|
|
project_id: project?.id,
|
|
// A creation entry (e.g. "New logs query") threads the target backend
|
|
// through `/sql/new?source=`; default to a database snippet otherwise.
|
|
source: parseSqlSnippetSource(source),
|
|
})
|
|
snapV2.addSnippet({ projectRef: ref, snippet: newSnippet })
|
|
// When the editor was seeded from a `content` deep-link, replace rather
|
|
// than push. The caller navigated to `/sql/new?content=...` (a long,
|
|
// one-shot URL); replacing collapses it out of history so Back returns to
|
|
// the originating page instead of a wasted step that re-seeds the snippet.
|
|
if (router.query.content !== undefined) {
|
|
router.replace(`/project/${ref}/sql/${newSnippet.id}`, undefined, { shallow: true })
|
|
} else {
|
|
router.push(`/project/${ref}/sql/${newSnippet.id}`, undefined, { shallow: true })
|
|
}
|
|
}
|
|
|
|
// A snippet that has never been persisted needs the snippet/folder lists
|
|
// invalidated so it shows up in the sidebar. If `snippet` was undefined at
|
|
// render we just created one above (status 'new'), which always qualifies.
|
|
const shouldInvalidate = snippet ? wasNeverPersisted(snippet.snippet.status) : true
|
|
snapV2.setSql({ id, sql: value, shouldInvalidate })
|
|
}
|
|
|
|
// if an SQL query is passed by the content parameter, set the editor value to its content. This
|
|
// is usually used for sending the user to SQL editor from other pages with SQL.
|
|
const seedFromContentParam = useEffectEvent(() => {
|
|
if (content && content.length > 0) handleEditorChange(content)
|
|
})
|
|
useEffect(() => {
|
|
seedFromContentParam()
|
|
}, [])
|
|
|
|
return { snippet, disableEdit, handleEditorChange }
|
|
}
|