mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 09:55:06 +03:00
## What kind of change does this PR introduce? Bug fix / design-system alignment for the legacy `Button` from `ui`. ## What is the current behavior? Omitting `variant` on the legacy `Button` falls back to brand-green `primary`. That makes accidental greens easy, and it is hard to spot the real main action on busy pages. ## What is the new behavior? - Legacy `Button` now defaults to neutral `default` - Intentional primary CTAs (create, save, submit, marketing CTAs, and matching `ButtonTooltip` usages) now set `variant="primary"` so their appearance is unchanged - Neutral actions that previously relied on the old fallback (cancel, close, back, dashboard nav, and similar) become grey/white - Design-system docs updated; regression tests cover the new default `Button_Shadcn_` is unchanged. It already uses its own CVA default. This is PR 1 of 2 in a stack. PR 2 drops now-redundant `variant="default"` props. ## To test Studio (http://localhost:8082): - `/sign-in`: Sign in stays green - Open a project → Database → Tables: New table stays green - Auth → Users → Invite: Invite user stays green; Cancel / dismiss controls stay neutral - Project Settings → General: edit a field so Cancel and Save appear. Cancel is neutral, Save is green Design system (http://localhost:3003): - Components → Button: default demo is neutral; primary demo is green; featured preview is the default variant Marketing (optional): - www header: Start your project stays green; logged-in Dashboard is neutral <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Buttons now default to a neutral style, while primary actions across Studio, documentation, marketing pages, forms, dialogs, and error states use prominent primary styling. - Updated button examples and previews clarify the distinction between default and primary variants. - Event registration now includes a directional arrow icon. - **Tests** - Added coverage confirming default button styling and explicit primary styling behave as expected. - Updated related test fixtures to use primary styling where appropriate. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
88 lines
3.0 KiB
TypeScript
88 lines
3.0 KiB
TypeScript
import { LOCAL_STORAGE_KEYS, safeLocalStorage, useFlag } from 'common'
|
|
import { useEffect } from 'react'
|
|
import {
|
|
Button,
|
|
Dialog,
|
|
DialogContent,
|
|
DialogDescription,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogSection,
|
|
DialogSectionSeparator,
|
|
DialogTitle,
|
|
KeyboardShortcut,
|
|
} from 'ui'
|
|
|
|
import { shouldShowManualSaveNotice } from './SqlEditorManualSaveNoticeDialog.utils'
|
|
import { useFeaturePreviewContext } from '@/components/interfaces/App/FeaturePreview/FeaturePreviewContext'
|
|
import { useLocalStorageQuery } from '@/hooks/misc/useLocalStorage'
|
|
import { IS_PLATFORM } from '@/lib/constants'
|
|
|
|
/**
|
|
* One-time notice for users the manual saving rollout switches over, shown the
|
|
* first time they land on a SQL Editor route. Users who opted into the preview
|
|
* themselves already know the behavior and never see it.
|
|
*/
|
|
export const SqlEditorManualSaveNoticeDialog = () => {
|
|
const { isInitialized } = useFeaturePreviewContext()
|
|
const isForced = useFlag('sqlEditorManualSaveForced')
|
|
|
|
const [isNoticeDismissed, setIsNoticeDismissed, { isSuccess: isDismissalLoaded }] =
|
|
useLocalStorageQuery(LOCAL_STORAGE_KEYS.SQL_EDITOR_MANUAL_SAVE_NOTICE_DISMISSED, false)
|
|
|
|
const hasOptedIntoPreview =
|
|
safeLocalStorage.getItem(LOCAL_STORAGE_KEYS.UI_PREVIEW_SQL_EDITOR_MANUAL_SAVE) === 'true'
|
|
|
|
// Record the dismissal up front for users who opted in themselves. The notice
|
|
// outlives the feature preview — once the preview is retired there's no stored
|
|
// opt-in left to recognize them by, and without this they'd be shown a notice
|
|
// about behavior they chose.
|
|
useEffect(() => {
|
|
if (isDismissalLoaded && hasOptedIntoPreview && !isNoticeDismissed) {
|
|
setIsNoticeDismissed(true)
|
|
}
|
|
}, [isDismissalLoaded, hasOptedIntoPreview, isNoticeDismissed, setIsNoticeDismissed])
|
|
|
|
const isOpen =
|
|
isDismissalLoaded &&
|
|
shouldShowManualSaveNotice({
|
|
isPlatform: IS_PLATFORM,
|
|
isFeaturePreviewInitialized: isInitialized,
|
|
isForced,
|
|
hasOptedIntoPreview,
|
|
isNoticeDismissed,
|
|
})
|
|
|
|
return (
|
|
<Dialog open={isOpen} onOpenChange={(open) => !open && setIsNoticeDismissed(true)}>
|
|
<DialogContent size="medium">
|
|
<DialogHeader>
|
|
<DialogTitle>Snippets no longer save automatically</DialogTitle>
|
|
<DialogDescription>
|
|
The SQL Editor now saves your snippets only when you save them.
|
|
</DialogDescription>
|
|
</DialogHeader>
|
|
|
|
<DialogSectionSeparator />
|
|
|
|
<DialogSection className="text-sm">
|
|
<ul className="list-disc pl-6 text-foreground-light space-y-1">
|
|
<li>
|
|
Save with the Save button next to Run, or with{' '}
|
|
<KeyboardShortcut keys={['Meta', 's']} />
|
|
</li>
|
|
<li>Tabs with unsaved edits show a dot</li>
|
|
<li>Closing a tab with unsaved edits discards them</li>
|
|
</ul>
|
|
</DialogSection>
|
|
|
|
<DialogFooter>
|
|
<Button variant="primary" onClick={() => setIsNoticeDismissed(true)}>
|
|
Understood
|
|
</Button>
|
|
</DialogFooter>
|
|
</DialogContent>
|
|
</Dialog>
|
|
)
|
|
}
|