Files
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

107 lines
3.9 KiB
TypeScript

import { useParams } from 'common'
import { UseFormReturn, useWatch } from 'react-hook-form'
import {
Button,
FormControl,
FormField,
FormInputGroupInput,
InputGroup,
InputGroupAddon,
} from 'ui'
import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'
import { DiskStorageSchemaType } from '../DiskManagement.schema'
import {
calculateComputeSizeRequiredForIops,
mapAddOnVariantIdToComputeSize,
} from '../DiskManagement.utils'
import { ComputeSizeRecommendationSection } from '../ui/ComputeSizeRecommendationSection'
import { DiskType, RESTRICTED_COMPUTE_FOR_IOPS_ON_GP3 } from '../ui/DiskManagement.constants'
import { DiskManagementIOPSReadReplicas } from '../ui/DiskManagementReadReplicas'
import { useDiskAttributesQuery } from '@/data/config/disk-attributes-query'
type IOPSFieldProps = {
form: UseFormReturn<DiskStorageSchemaType>
disableInput: boolean
}
export function IOPSField({ form, disableInput }: IOPSFieldProps) {
const { ref: projectRef } = useParams()
const { control, formState, setValue, trigger, getValues } = form
const watchedStorageType = useWatch({ control, name: 'storageType' })
const watchedComputeSize = useWatch({ control, name: 'computeSize' })
const watchedIOPS = useWatch({ control, name: 'provisionedIOPS' }) ?? 0
const { isError } = useDiskAttributesQuery({ projectRef })
const disableIopsInput =
RESTRICTED_COMPUTE_FOR_IOPS_ON_GP3.includes(watchedComputeSize) && watchedStorageType === 'gp3'
return (
<FormField
control={control}
name="provisionedIOPS"
render={({ field }) => {
const reccomendedComputeSize = calculateComputeSizeRequiredForIops(watchedIOPS)
return (
<FormItemLayout
layout="flex-row-reverse"
label="IOPS"
id={field.name}
description={
<span className="flex flex-col gap-y-2">
<p>Use higher IOPS for high-throughput apps.</p>
<ComputeSizeRecommendationSection
form={form}
actions={
<Button
onClick={() => {
setValue('computeSize', reccomendedComputeSize ?? 'ci_nano')
trigger('provisionedIOPS')
}}
>
Update to {mapAddOnVariantIdToComputeSize(reccomendedComputeSize)}
</Button>
}
/>
{!formState.errors.provisionedIOPS && (
<DiskManagementIOPSReadReplicas
isDirty={formState.dirtyFields.provisionedIOPS !== undefined}
oldIOPS={formState.defaultValues?.provisionedIOPS ?? 0}
newIOPS={field.value}
oldStorageType={formState.defaultValues?.storageType as DiskType}
newStorageType={getValues('storageType') as DiskType}
/>
)}
</span>
}
labelOptional={
<p className="text-foreground-lighter">Input/output operations per second.</p>
}
>
<FormControl className="max-w-32">
<InputGroup>
<FormInputGroupInput
type="number"
{...field}
id={field.name}
value={field.value}
disabled={disableInput || disableIopsInput || isError}
onChange={(e) => {
setValue('provisionedIOPS', e.target.valueAsNumber, {
shouldDirty: true,
shouldValidate: true,
})
}}
/>
<InputGroupAddon align="inline-end">IOPS</InputGroupAddon>
</InputGroup>
</FormControl>
</FormItemLayout>
)
}}
/>
)
}