Files
Danny White 1131e3e2ce fix(ui): default Button variant to default instead of primary (#50160)
## What kind of change does this PR introduce?

Bug fix / design-system alignment for the legacy `Button` from `ui`.

## What is the current behavior?

Omitting `variant` on the legacy `Button` falls back to brand-green
`primary`. That makes accidental greens easy, and it is hard to spot the
real main action on busy pages.

## What is the new behavior?

- Legacy `Button` now defaults to neutral `default`
- Intentional primary CTAs (create, save, submit, marketing CTAs, and
matching `ButtonTooltip` usages) now set `variant="primary"` so their
appearance is unchanged
- Neutral actions that previously relied on the old fallback (cancel,
close, back, dashboard nav, and similar) become grey/white
- Design-system docs updated; regression tests cover the new default

`Button_Shadcn_` is unchanged. It already uses its own CVA default.

This is PR 1 of 2 in a stack. PR 2 drops now-redundant
`variant="default"` props.

## To test

Studio (http://localhost:8082):

- `/sign-in`: Sign in stays green
- Open a project → Database → Tables: New table stays green
- Auth → Users → Invite: Invite user stays green; Cancel / dismiss
controls stay neutral
- Project Settings → General: edit a field so Cancel and Save appear.
Cancel is neutral, Save is green

Design system (http://localhost:3003):

- Components → Button: default demo is neutral; primary demo is green;
featured preview is the default variant

Marketing (optional):

- www header: Start your project stays green; logged-in Dashboard is
neutral

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Style**
- Buttons now default to a neutral style, while primary actions across
Studio, documentation, marketing pages, forms, dialogs, and error states
use prominent primary styling.
- Updated button examples and previews clarify the distinction between
default and primary variants.
  - Event registration now includes a directional arrow icon.

- **Tests**
- Added coverage confirming default button styling and explicit primary
styling behave as expected.
- Updated related test fixtures to use primary styling where
appropriate.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-09-10 11:23:17 +10:00

105 lines
3.6 KiB
TypeScript

import { PermissionAction } from '@supabase/shared-types/out/constants'
import { useParams } from 'common'
import dayjs from 'dayjs'
import { AlertCircle } from 'lucide-react'
import type { Timezone } from './PITR.types'
import { TimezoneSelection } from './TimezoneSelection'
import { ButtonTooltip } from '@/components/ui/ButtonTooltip'
import { FormPanel } from '@/components/ui/Forms/FormPanel'
import { useBackupsQuery } from '@/data/database/backups-query'
import { useReadReplicasQuery } from '@/data/read-replicas/replicas-query'
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
interface PITRStatusProps {
selectedTimezone: Timezone
onUpdateTimezone: (timezone: Timezone) => void
onSetConfiguration: () => void
}
const PITRStatus = ({
selectedTimezone,
onUpdateTimezone,
onSetConfiguration,
}: PITRStatusProps) => {
const { ref } = useParams()
const { data: backups } = useBackupsQuery({ projectRef: ref })
const { data: databases } = useReadReplicasQuery({ projectRef: ref })
const hasReadReplicas = (databases ?? []).length > 1
const { earliestPhysicalBackupDateUnix, latestPhysicalBackupDateUnix } =
backups?.physicalBackupData ?? {}
const earliestAvailableBackup = dayjs
.unix(earliestPhysicalBackupDateUnix ?? 0)
.tz(selectedTimezone?.utc[0])
.format('DD MMM YYYY, HH:mm:ss')
const latestAvailableBackup = dayjs
.unix(latestPhysicalBackupDateUnix ?? 0)
.tz(selectedTimezone?.utc[0])
.format('DD MMM YYYY, HH:mm:ss')
const { can: canTriggerPhysicalBackup } = useAsyncCheckPermissions(
PermissionAction.INFRA_EXECUTE,
'queue_job.walg.prepare_restore'
)
return (
<>
<FormPanel
disabled={true}
footer={
<div className="flex items-center justify-between p-6">
<div className="flex items-center space-x-4">
<AlertCircle className="text-foreground-light" size={18} strokeWidth={1.5} />
<span className="text-foreground-light text-sm">
You'll be able to pick the right date and time when you begin
</span>
</div>
<ButtonTooltip
variant="primary"
disabled={hasReadReplicas || !canTriggerPhysicalBackup}
onClick={() => onSetConfiguration()}
tooltip={{
content: {
side: 'left',
text: hasReadReplicas
? 'You will need to remove all read replicas first to trigger a PITR recovery'
: !canTriggerPhysicalBackup
? 'You need additional permissions to trigger a PITR recovery'
: undefined,
},
}}
>
Start a restore
</ButtonTooltip>
</div>
}
>
<div className="p-6 space-y-6">
<div className="w-[350px]">
<TimezoneSelection
selectedTimezone={selectedTimezone}
onSelectTimezone={onUpdateTimezone}
/>
</div>
<div className="flex items-center space-x-20">
<div className="space-y-2">
<p className="text-sm text-foreground-light">Database restore available from</p>
<p className="text-2xl">{earliestAvailableBackup}</p>
</div>
<div className="space-y-2">
<p className="text-sm text-foreground-light">Latest restore available at</p>
<p className="text-2xl">{latestAvailableBackup}</p>
</div>
</div>
</div>
</FormPanel>
</>
)
}
export default PITRStatus