mirror of
https://github.com/supabase/supabase.git
synced 2026-10-05 17:35:10 +03:00
Gildas GarciaandIvan Vasilov
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
44 lines
1.5 KiB
TypeScript
44 lines
1.5 KiB
TypeScript
'use client'
|
|
|
|
import { Menu } from 'lucide-react'
|
|
import Link from 'next/link'
|
|
import { Button } from 'ui'
|
|
|
|
import { CommandMenu } from './command-menu'
|
|
import { HomepageSvgHandler } from './homepage-svg-handler'
|
|
import { ThemeSwitcherDropdown } from './theme-switcher-dropdown'
|
|
import { useMobileSidebar } from '@/hooks/use-mobile-sidebar'
|
|
|
|
export const TopNavigation = () => {
|
|
const { toggle } = useMobileSidebar()
|
|
|
|
return (
|
|
<header className="sticky top-0 z-50 w-full bg-studio/95 backdrop-blur-sm supports-backdrop-filter:bg-studio/60 border-b border-l border-r">
|
|
<nav className="py-3 w-full flex">
|
|
<div className="max-w-site w-full flex flex-row items-center gap-6 mx-auto md:px-6 px-4 justify-between">
|
|
<div className="flex items-center gap-2">
|
|
<Button
|
|
variant="text"
|
|
size="tiny"
|
|
className="px-1 md:hidden"
|
|
onClick={toggle}
|
|
icon={<Menu size={16} />}
|
|
aria-label="Toggle navigation menu"
|
|
/>
|
|
<Link href="/" className="flex items-center lg:gap-6 gap-4">
|
|
<h1 className="hidden md:flex line-clamp-1 lg:text-2xl text-xl">
|
|
Supabase Design System
|
|
</h1>
|
|
<HomepageSvgHandler name="logo" className="h-4 w-auto" />
|
|
</Link>
|
|
</div>
|
|
<div className="flex items-center gap-2">
|
|
<CommandMenu />
|
|
<ThemeSwitcherDropdown />
|
|
</div>
|
|
</div>
|
|
</nav>
|
|
</header>
|
|
)
|
|
}
|