mirror of
https://github.com/supabase/supabase.git
synced 2026-10-07 10:25:06 +03:00
Danny White
c8aca8d3a0
## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? UI / design-system consistency (accessibility). ## What is the current behavior? Keyboard focus rings are inconsistent across Studio and `packages/ui`: - Custom Button uses thick `outline` with per-variant colours (brand / grey / destructive / warning) - Form controls use muted grey rings (`ring-background-control`) - Tabs / NavMenu / Radio use soft brand `ring-ring` - Studio `.inset-focus` uses dark green `outline-brand-600` Related: [DEPR-354](https://linear.app/supabase/issue/DEPR-354). ## What is the new behavior? One shared focus recipe, exposed as Tailwind `@utility` classes in `packages/config/css/utilities.css`: | Utility | Use when | | --- | --- | | `focus-ring` | Buttons, inputs, most controls (offset ring) | | `focus-inset` | Dense/flush surfaces such as interactive table rows (renamed from `inset-focus`) | ```txt # focus-ring outline-hidden focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 focus-visible:ring-offset-background ``` Applied on Button, shadcn form controls, Menu/NavMenu, Command palette trigger, Studio table rows, and related call sites. Documented in the design-system accessibility docs. Variants do not change focus ring colour. When the ring must appear on a different element than the focused one (e.g. Menu + ProductMenu `Link` via `group-focus-visible`, or InputGroup via `:has()`), keep an explicit ring stack. The utilities bake in `:focus-visible` on the same element. ## Additional context **Out of scope** - Full `packages/ui` / Studio / www sweep - Legacy Studio form-group green box-shadow cleanup - ESLint rule for bare `outline-none` ## Test plan Prefer Safari (“hard mode” for `tabIndex`). Expect one soft brand ring everywhere: not grey, not solid green outline. ### Design system - [ ] [Accessibility](https://design-system-git-dnywh-choreimprove-tab-focus-styles-supabase.vercel.app/design-system/docs/accessibility): recipe docs match what you see - [ ] [Button](https://design-system-git-dnywh-choreimprove-tab-focus-styles-supabase.vercel.app/design-system/docs/components/button): Tab primary / default / danger; same ring colour - [ ] [Table → Row-level navigation](https://design-system-git-dnywh-choreimprove-tab-focus-styles-supabase.vercel.app/design-system/docs/components/table#row-level-navigation): Tab an interactive row; inset outline (`focus-inset`) sits inside the row ### Studio - [ ] **Org home → table view** (`/organizations/_` or org projects): switch to the table layout, Tab onto a project row; inset outline sits inside the row (list/card view uses CardButton, not `focus-inset`) - [ ] **Project sidebar** (Database, Auth, Storage, …): Tab the main product nav links; ring follows the focused item (not the nested section menus like Tables / Roles) - [ ] **Storage → Files**: Tab a bucket row; same inset outline as org table rows - [ ] **Project Settings → General** (or Compute and Disk): Tab through inputs, checkboxes, switches, selects; same offset ring, no ring on mouse click - [ ] **Header ⌘K** (desktop width): Tab to the search control after Feedback; same soft brand `focus-ring` (was a thicker `ring-border-strong` before) - [ ] **Table Editor or SQL Editor tabs**: focus a tab, Tab to × if active; close shows a ring - [ ] **Light + dark**: ring stays visible against both backgrounds
32 lines
1.3 KiB
TypeScript
32 lines
1.3 KiB
TypeScript
// Props to https://github.com/shadcn-ui/ui/issues/885#issuecomment-2059600641
|
|
// @mildtomato - consider using this as the main Slider component in packages/ui
|
|
|
|
import { Slider as SliderPrimitive } from 'radix-ui'
|
|
import { ComponentPropsWithoutRef, ElementRef, forwardRef, Fragment } from 'react'
|
|
import { cn } from 'ui'
|
|
|
|
export const Slider = forwardRef<
|
|
ElementRef<typeof SliderPrimitive.Root>,
|
|
ComponentPropsWithoutRef<typeof SliderPrimitive.Root>
|
|
>(({ className, ...props }, ref) => {
|
|
const initialValue = Array.isArray(props.value) ? props.value : [props.min, props.max]
|
|
|
|
return (
|
|
<SliderPrimitive.Root
|
|
ref={ref}
|
|
className={cn('relative flex w-full touch-none select-none items-center', className)}
|
|
{...props}
|
|
>
|
|
<SliderPrimitive.Track className="relative h-2 w-full grow overflow-hidden rounded-full bg-secondary">
|
|
<SliderPrimitive.Range className="absolute h-full bg-primary" />
|
|
</SliderPrimitive.Track>
|
|
{initialValue.map((_, index) => (
|
|
<Fragment key={index}>
|
|
<SliderPrimitive.Thumb className="block h-4 w-4 rounded-full border-2 border-primary bg-background transition-colors focus-ring disabled:pointer-events-none disabled:opacity-50" />
|
|
</Fragment>
|
|
))}
|
|
</SliderPrimitive.Root>
|
|
)
|
|
})
|
|
Slider.displayName = SliderPrimitive.Root.displayName
|