Files
Gildas GarciaandIvan Vasilov 96d43099bb chore: refactor Button API so that it can be used a standard button (#46880)
## Problem

Our `<Button>` component breaks the default `button` contract by
redefining the `type` prop to set its variant (`primary`, `default`,
etc) instead of the button type (`submit`, `button`, etc).
This is confusing and forces to write more code when using it with
shadcn components that expect/inject the standard button props.

## Solution

- rename the `type` prop to `variant`
- rename the `htmlType` prop to `type`
- propagate the changes where necessary
- format code

## How to test

As this is just prop renaming, if it builds it's ok

---------

Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
2026-06-16 23:59:58 +02:00

92 lines
2.7 KiB
TypeScript

import { PermissionAction } from '@supabase/shared-types/out/constants'
import { useEffect } from 'react'
import {
Button,
cn,
Dialog,
DialogContent,
DialogFooter,
DialogHeader,
DialogSection,
DialogSectionSeparator,
DialogTitle,
Form,
} from 'ui'
import { AIOptInLevelSelector } from '@/components/interfaces/Organization/GeneralSettings/AIOptInLevelSelector'
import { useAIOptInForm } from '@/hooks/forms/useAIOptInForm'
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
interface AIOptInModalProps {
visible: boolean
onCancel: () => void
}
export const AIOptInModal = ({ visible, onCancel }: AIOptInModalProps) => {
const { form, onSubmit, isUpdating, currentOptInLevel } = useAIOptInForm(onCancel)
const { can: canUpdateOrganization } = useAsyncCheckPermissions(
PermissionAction.UPDATE,
'organizations'
)
const onOpenChange = (open: boolean) => {
if (!open) {
onCancel()
}
}
useEffect(() => {
if (visible) {
form.reset({ aiOptInLevel: currentOptInLevel })
}
}, [visible, currentOptInLevel, form])
return (
<Dialog open={visible} onOpenChange={onOpenChange}>
<DialogContent size="large" aria-describedby={undefined}>
<Form {...form}>
<form id="ai-opt-in-form" onSubmit={form.handleSubmit(onSubmit)}>
<DialogHeader padding="small">
<DialogTitle>Update Supabase Assistant Opt-in Level</DialogTitle>
</DialogHeader>
<DialogSectionSeparator />
<DialogSection className="space-y-4 pb-0" padding="small">
<AIOptInLevelSelector
control={form.control}
disabled={!canUpdateOrganization || isUpdating}
/>
</DialogSection>
<DialogFooter
padding="small"
className={cn(!canUpdateOrganization && 'justify-between!')}
>
{!canUpdateOrganization && (
<p className="text-sm text-foreground-lighter">
You need additional permissions to update the opt-in level
</p>
)}
<div className="flex items-center gap-x-2">
<Button variant="default" disabled={isUpdating} onClick={onCancel}>
Cancel
</Button>
<Button
variant="primary"
type="submit"
form="ai-opt-in-form"
loading={isUpdating}
disabled={isUpdating || !canUpdateOrganization || !form.formState.isDirty}
>
Confirm
</Button>
</div>
</DialogFooter>
</form>
</Form>
</DialogContent>
</Dialog>
)
}