mirror of
https://github.com/supabase/supabase.git
synced 2026-10-07 10:25:06 +03:00
Gildas GarciaandIvan Vasilov
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
39 lines
1.2 KiB
TypeScript
39 lines
1.2 KiB
TypeScript
import { Badge, Button } from 'ui'
|
|
|
|
import { FeaturePreviewSidebarPanel } from '../../ui/FeaturePreviewSidebarPanel'
|
|
import { useGenerateAdvisorsMenu } from './AdvisorsMenu.utils'
|
|
import { SIDEBAR_KEYS } from '@/components/layouts/ProjectLayout/LayoutSidebar/LayoutSidebarProvider'
|
|
import { ProductMenu } from '@/components/ui/ProductMenu'
|
|
import { useSidebarManagerSnapshot } from '@/state/sidebar-manager-state'
|
|
|
|
interface AdvisorsSidebarMenuProps {
|
|
page?: string
|
|
}
|
|
|
|
export function AdvisorsSidebarMenu({ page }: AdvisorsSidebarMenuProps) {
|
|
const menu = useGenerateAdvisorsMenu()
|
|
const { toggleSidebar } = useSidebarManagerSnapshot()
|
|
|
|
const handleOpenAdvisor = () => {
|
|
toggleSidebar(SIDEBAR_KEYS.ADVISOR_PANEL)
|
|
}
|
|
|
|
return (
|
|
<div className="pb-12 relative">
|
|
<FeaturePreviewSidebarPanel
|
|
className="mx-4 mt-4"
|
|
title="Moving to the toolbar"
|
|
description="Advisors are now available in the top toolbar for quicker access across the dashboard."
|
|
illustration={<Badge variant="success">New</Badge>}
|
|
actions={
|
|
<Button size="tiny" variant="default" onClick={handleOpenAdvisor}>
|
|
Try it now
|
|
</Button>
|
|
}
|
|
/>
|
|
|
|
<ProductMenu page={page} menu={menu} />
|
|
</div>
|
|
)
|
|
}
|