mirror of
https://github.com/supabase/supabase.git
synced 2026-10-07 18:35:07 +03:00
## Summary - Migrates all 11 `useHotKey` call sites across 9 files to `useShortcut`, backed by `SHORTCUT_DEFINITIONS` in `state/shortcuts/registry.ts`. - Adds 10 new registry entries (all `showInSettings: false` to keep behavior identical to today — these were not previously user-configurable). - Deletes `apps/studio/hooks/ui/useHotKey.ts`. - Simplifies `ActionBar.handleSave` — the legacy hook passed a `KeyboardEvent` the callback used for `preventDefault`/`stopPropagation` and a textarea-plain-Enter guard; all of that is redundant under `useShortcut` (TanStack handles default/propagation; `Mod+Enter` never fires on plain Enter). - Removes a stale commented-out `useHotKey` reference in `DataTableFilterCommand.tsx`. Part of FE-3025 (legacy hotkey hook cleanup). `useKeyboardShortcuts` in `grid/components/common/Hooks.tsx` will be migrated in a follow-up. ## Test plan All shortcuts should still fire with **Cmd** (macOS) / **Ctrl** (Win/Linux). **Table Editor — operation queue** (requires pending unsaved edits on a row) - [x] `Cmd+S` saves pending edits - [x] `Cmd+.` toggles the operation queue side panel - [x] `Cmd+Z` undoes the latest edit and re-fetches the affected table rows - [x] With no pending edits, none of the above fire (gated by `isEnabled`) **Table Editor — side panel editor forms** (row, table, column, policy, etc.) - [x] `Cmd+Enter` submits the form when the panel is visible - [x] Does not submit if the form is disabled/loading or the panel is hidden **Unified Logs — data table** - [x] `Cmd+B` toggles the filter controls sidebar (desktop) - [x] `Cmd+B` opens the filter drawer (mobile, `<sm` breakpoint) - [x] `Cmd+Esc` resets active column filters (reset button visible) - [x] `Cmd+U` resets column order + visibility - [x] `Cmd+J` toggles live mode **Unified Logs — reset focus** - [x] `Cmd+.` blurs the currently focused element / resets focus to body **AI Assistant panel** - [x] While editing a message, `Cmd+Esc` cancels the edit **Regression checks** - [x] `pnpm --filter=studio typecheck` passes (verified locally) - [x] None of the new shortcut entries appear in Account → Preferences → Keyboard shortcuts (all `showInSettings: false`) - [x] Existing shortcuts (`Cmd+K`, `Cmd+I`, `Cmd+E`, results copy/download) still work unchanged <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Refactor * Implemented a centralized keyboard shortcut registry system for managing shortcuts consistently across the application * Updated multiple UI components throughout the interface to use the new shortcut management system * All existing keyboard shortcuts continue to function without any changes in behavior or user experience ## Chores * Removed legacy keyboard shortcut hook implementation <!-- end of auto-generated comment: release notes by coderabbit.ai -->
46 lines
1.7 KiB
TypeScript
46 lines
1.7 KiB
TypeScript
import { useQueryState } from 'nuqs'
|
|
import { useEffect, useMemo, useRef } from 'react'
|
|
|
|
import { SEARCH_PARAMS_PARSER } from './UnifiedLogs.constants'
|
|
import { SHORTCUT_IDS } from '@/state/shortcuts/registry'
|
|
import { useShortcut } from '@/state/shortcuts/useShortcut'
|
|
|
|
export const useResetFocus = () => {
|
|
useShortcut(SHORTCUT_IDS.UNIFIED_LOGS_RESET_FOCUS, () => {
|
|
// FIXME: some dedicated div[tabindex="0"] do not auto-unblur (e.g. the DataTableFilterResetButton)
|
|
// REMINDER: we cannot just document.activeElement?.blur(); as the next tab will focus the next element in line,
|
|
// which is not what we want. We want to reset entirely.
|
|
document.body.setAttribute('tabindex', '0')
|
|
document.body.focus()
|
|
document.body.removeAttribute('tabindex')
|
|
})
|
|
}
|
|
|
|
export const useLiveMode = <TData extends { date: Date }>(data: TData[]) => {
|
|
const [live] = useQueryState('live', SEARCH_PARAMS_PARSER.live)
|
|
// REMINDER: used to capture the live mode on timestamp
|
|
const liveTimestamp = useRef<number | undefined>(live ? new Date().getTime() : undefined)
|
|
|
|
useEffect(() => {
|
|
if (live) liveTimestamp.current = new Date().getTime()
|
|
else liveTimestamp.current = undefined
|
|
}, [live])
|
|
|
|
const anchorRow = useMemo(() => {
|
|
if (!live) return undefined
|
|
|
|
const item = data.find((item) => {
|
|
// return first item that is there if not liveTimestamp
|
|
if (!liveTimestamp.current) return true
|
|
// return first item that is after the liveTimestamp
|
|
if (item.date.getTime() > liveTimestamp.current) return false
|
|
return true
|
|
// return first item if no liveTimestamp
|
|
})
|
|
|
|
return item
|
|
}, [live, data])
|
|
|
|
return { row: anchorRow, timestamp: liveTimestamp.current }
|
|
}
|