Files
Gildas GarciaandIvan Vasilov 96d43099bb chore: refactor Button API so that it can be used a standard button (#46880)
## Problem

Our `<Button>` component breaks the default `button` contract by
redefining the `type` prop to set its variant (`primary`, `default`,
etc) instead of the button type (`submit`, `button`, etc).
This is confusing and forces to write more code when using it with
shadcn components that expect/inject the standard button props.

## Solution

- rename the `type` prop to `variant`
- rename the `htmlType` prop to `type`
- propagate the changes where necessary
- format code

## How to test

As this is just prop renaming, if it builds it's ok

---------

Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
2026-06-16 23:59:58 +02:00

113 lines
3.5 KiB
TypeScript

import { ExternalLink } from 'lucide-react'
import Link from 'next/link'
import { Button } from 'ui'
import { Markdown } from '../Markdown'
import { asGraphqlExposureLint, GraphqlExposureCallout } from './GraphqlExposureLintCTA'
import { EntityTypeIcon, LintCTA, LintEntity } from './Linter.utils'
import { createLintSummaryPrompt, lintInfoMap } from '@/components/interfaces/Linter/Linter.utils'
import { SIDEBAR_KEYS } from '@/components/layouts/ProjectLayout/LayoutSidebar/LayoutSidebarProvider'
import { AiAssistantDropdown } from '@/components/ui/AiAssistantDropdown'
import { Lint } from '@/data/lint/lint-query'
import { DOCS_URL } from '@/lib/constants'
import { useTrack } from '@/lib/telemetry/track'
import { useAiAssistantStateSnapshot } from '@/state/ai-assistant-state'
import { useSidebarManagerSnapshot } from '@/state/sidebar-manager-state'
interface LintDetailProps {
lint: Lint
projectRef: string
onAskAssistant?: () => void
onAfterAction?: () => void
}
export const LintDetail = ({
lint,
projectRef,
onAskAssistant,
onAfterAction,
}: LintDetailProps) => {
const track = useTrack()
const snap = useAiAssistantStateSnapshot()
const { openSidebar } = useSidebarManagerSnapshot()
const isGraphqlExposureLint = !!asGraphqlExposureLint(lint.name)
const handleAskAssistant = () => {
track('advisor_assistant_button_clicked', {
origin: 'lint_detail',
advisorCategory: lint.categories[0],
advisorType: lint.name,
advisorLevel: lint.level,
})
onAskAssistant?.()
openSidebar(SIDEBAR_KEYS.AI_ASSISTANT)
snap.newChat({
name: 'Summarize lint',
initialMessage: createLintSummaryPrompt(lint),
})
}
const buildPromptForCopy = () => {
return createLintSummaryPrompt(lint)
}
return (
<div>
<h3 className="text-sm mb-2">Entity</h3>
<div className="flex items-center gap-1 px-2 py-0.5 bg-surface-200 border rounded-lg text-sm mb-6 w-fit">
<EntityTypeIcon type={lint.metadata?.type} />
<LintEntity metadata={lint.metadata} />
</div>
<h3 className="text-sm mb-2">Issue</h3>
<Markdown className="leading-6 text-sm text-foreground-light mb-6">
{lint.detail.replace(/\\`/g, '`')}
</Markdown>
<h3 className="text-sm mb-2">Description</h3>
<Markdown className="text-sm text-foreground-light mb-6">
{lint.description.replace(/\\`/g, '`')}
</Markdown>
{isGraphqlExposureLint && (
<div className="mb-4">
<GraphqlExposureCallout projectRef={projectRef} />
</div>
)}
<h3 className="text-sm mb-2">Resolve</h3>
<div className="flex flex-wrap items-center gap-2">
<AiAssistantDropdown
label="Ask Assistant"
buildPrompt={buildPromptForCopy}
onOpenAssistant={handleAskAssistant}
telemetrySource="lint_detail"
/>
<LintCTA
title={lint.name}
projectRef={projectRef}
metadata={lint.metadata}
onAfterAction={onAfterAction}
/>
<Button asChild variant="text">
<Link
href={
lintInfoMap.find((item) => item.name === lint.name)?.docsLink ||
`${DOCS_URL}/guides/database/database-linter`
}
target="_blank"
rel="noreferrer"
className="no-underline"
>
<span className="flex items-center gap-2">
Learn more <ExternalLink size={14} />
</span>
</Link>
</Button>
</div>
</div>
)
}