mirror of
https://github.com/supabase/supabase.git
synced 2026-10-08 10:55:06 +03:00
## What kind of change does this PR introduce? A11y cleanup follow-up to #47984 / [DEPR-626](https://linear.app/supabase/issue/DEPR-626). ## What is the current behavior? Studio had 82 ratcheted `supabase/require-explicit-tabindex` violations (raw `<button>` / `role="button"` without explicit `tabIndex`). ## What is the new behavior? - Explicit `tabIndex={0}` (or disabled → `-1`) on those Studio call sites across nav, `components/ui`, Database, Storage, and the remainder - Ratchet baseline cleared (**82 → 0**) and the rule **removed from the Studio ratchet** (debt is gone; ratchet is temporary) - Rule remains a shared **`warn`** for now — promoting to `error` (and sweeping www/docs/design-system) is a follow-up - Also fixed the learn/ui-library call sites that surfaced while experimenting with error promotion - Small follow-ups where making controls focusable exposed gaps: accessible names, disabled/focus consistency, focus-ring polish on To-test surfaces, home section `KeyboardSensor`, and an E2E locator tightened after `aria-label="Remove column"` Prefer migrating to `Button` from `ui` in future touch-ups; this PR takes the minimal path so Studio debt can stay at zero. ## Additional context Batches landed together so baseline conflicts stayed simple while chipping away: - Hotspots / nav (FirstLevelNav, Marketplace, AttachmentUpload, Column, Tabs, …) - `components/ui` shared - Database + Storage - Remainder **Out of scope / intentional deferrals** - Promoting `supabase/require-explicit-tabindex` to a lint **error** (follow-up after www/docs/design-system sweeps) - Tabs/Radio roving, tooltips, context menus, in-menu items - Full keyboard-accessible tab-close UX (close stays hover + `tabIndex={-1}`; context menu still closes tabs) - Data API docs links (`/project/<ref>/api` redirect) **Reviewer notes** - Rule only flags raw `<button>` / `role="button"` without a `tabIndex` prop. `Button` from `ui` already bakes this in - `tabIndex={-1}` is intentional for disabled controls, in-menu / roving-focus children, and hover-only tab close - For dnd-kit grips, put `tabIndex` **after** `{...attributes}` so it isn’t overwritten (TS2783) ### To test Use **Safari** with macOS Keyboard navigation **off** (System Settings → Keyboard). Chrome once for a sanity pass. For each surface below: Tab until the control is focused, then activate with Enter/Space where relevant. 1. **API Docs side panel** (Table Editor → open a table → **API docs**) - Floating API Docs panel — **not** `/project/<ref>/api` (that redirects to Data API docs; language ToggleGroup uses arrow keys; links are out of scope) - Left nav buttons — Tab through several and activate one; active highlight / navigation still works 2. **Integrations → Marketplace** - Enable **Integrations layout** feature preview first (avatar menu → Feature previews) - `/org/<slug>/integrations` or project integrations marketplace - “Clear all”, grid/list toggles — Tab + activate 3. **Table Editor → create a table → Columns** - Drag handles only appear while **creating** (not when editing an existing table) - Tab to grip / remove (X) / sensitive-data eye if shown 4. **Project Home** — section drag handles - Tab to a grip (visible focus ring) - Optional: Space to pick up, arrows to move, Space/Esc to drop (KeyboardSensor added) - Mouse dnd still works 5. **Storage → Policies** — expand/collapse bucket list chevron (design-system focus ring, no stuck grey open bg) 6. **Support form** (Help → Support) — attachment remove (×) and add-attachment control when visible Disabled controls should be **skipped** by Tab. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Accessibility Improvements** * Improved keyboard navigation throughout Studio by explicitly managing focus (`tabIndex`) across many interactive controls (menus, tabs, tables, charts, dialogs, navigation, and form actions). * Disabled or non-interactive controls are now removed from the tab order (or made unfocusable), while available actions remain reachable. * Ensured `type="button"` on relevant controls to prevent unintended submissions, and refined keyboard focus behavior for various toggles and copy/remove actions. * **Chores** * Updated the ESLint rule baseline configuration to match the new focus behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
116 lines
3.5 KiB
TypeScript
116 lines
3.5 KiB
TypeScript
import { Switch } from 'ui'
|
|
|
|
import {
|
|
ALL_PRIVILEGE_TYPES,
|
|
COLUMN_PRIVILEGE_TYPES,
|
|
TABLE_PRIVILEGE_TYPES,
|
|
} from './Privileges.constants'
|
|
import { usePrivilegesState } from './Privileges.utils'
|
|
import Table from '@/components/to-be-cleaned/Table'
|
|
import type { ColumnPrivilege } from '@/data/privileges/column-privileges-query'
|
|
|
|
export interface PrivilegesTableProps extends Pick<
|
|
ReturnType<typeof usePrivilegesState>,
|
|
'tableCheckedStates' | 'columnCheckedStates' | 'toggleTablePrivilege' | 'toggleColumnPrivilege'
|
|
> {
|
|
columnPrivileges: ColumnPrivilege[]
|
|
disabled: boolean
|
|
isApplyingChanges?: boolean
|
|
}
|
|
|
|
const PrivilegesTable = ({
|
|
columnPrivileges,
|
|
tableCheckedStates,
|
|
columnCheckedStates,
|
|
toggleTablePrivilege,
|
|
toggleColumnPrivilege,
|
|
disabled,
|
|
isApplyingChanges = false,
|
|
}: PrivilegesTableProps) => {
|
|
const handleClickColumnName = (columnId: string) => {
|
|
const hasAllPrivileges = COLUMN_PRIVILEGE_TYPES.every(
|
|
(privilege) => columnCheckedStates[columnId][privilege]
|
|
)
|
|
const privilegesToToggle = COLUMN_PRIVILEGE_TYPES.filter((privilege) =>
|
|
hasAllPrivileges
|
|
? columnCheckedStates[columnId][privilege]
|
|
: !columnCheckedStates[columnId][privilege]
|
|
)
|
|
|
|
privilegesToToggle.forEach((privilege) => {
|
|
toggleColumnPrivilege(columnId, privilege)
|
|
})
|
|
}
|
|
|
|
return (
|
|
<Table
|
|
className="table-fixed mb-4"
|
|
head={[
|
|
<Table.th key="header-column">
|
|
<span>Column</span>
|
|
</Table.th>,
|
|
...ALL_PRIVILEGE_TYPES.map((privilege) => {
|
|
const checked = tableCheckedStates[privilege]
|
|
|
|
return (
|
|
<Table.th key={`header-${privilege}`}>
|
|
<div className="inline-flex items-center gap-2">
|
|
<span>{privilege.charAt(0) + privilege.slice(1).toLowerCase()}</span>
|
|
|
|
<Switch
|
|
checked={checked}
|
|
onCheckedChange={() => {
|
|
toggleTablePrivilege(privilege)
|
|
}}
|
|
disabled={disabled || isApplyingChanges}
|
|
/>
|
|
</div>
|
|
</Table.th>
|
|
)
|
|
}),
|
|
]}
|
|
body={columnPrivileges.map((column) => (
|
|
<Table.tr key={column.column_id}>
|
|
<Table.td>
|
|
<button
|
|
tabIndex={0}
|
|
onClick={() => handleClickColumnName(column.column_id)}
|
|
className="block w-full truncate text-left text-foreground"
|
|
>
|
|
{column.column_name}
|
|
</button>
|
|
</Table.td>
|
|
{COLUMN_PRIVILEGE_TYPES.map((privilege) => {
|
|
const checked = columnCheckedStates[column.column_id][privilege]
|
|
|
|
return (
|
|
<Table.td key={privilege}>
|
|
{COLUMN_PRIVILEGE_TYPES.includes(privilege as any) && (
|
|
<div className="ml-5 inline-flex">
|
|
<Switch
|
|
checked={checked}
|
|
onCheckedChange={() => {
|
|
toggleColumnPrivilege(column.column_id, privilege)
|
|
}}
|
|
disabled={disabled || isApplyingChanges}
|
|
/>
|
|
</div>
|
|
)}
|
|
</Table.td>
|
|
)
|
|
})}
|
|
{TABLE_PRIVILEGE_TYPES.map((privilege) => {
|
|
return (
|
|
<Table.td key={privilege}>
|
|
<span className="ml-5 text-xs text-foreground-lighter">N/A</span>
|
|
</Table.td>
|
|
)
|
|
})}
|
|
</Table.tr>
|
|
))}
|
|
/>
|
|
)
|
|
}
|
|
|
|
export default PrivilegesTable
|