mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 18:05:11 +03:00
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
70 lines
1.9 KiB
TypeScript
70 lines
1.9 KiB
TypeScript
import { useParams } from 'common'
|
|
import { useState } from 'react'
|
|
import { toast } from 'sonner'
|
|
import {
|
|
Button,
|
|
Dialog,
|
|
DialogContent,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogSection,
|
|
DialogSectionSeparator,
|
|
DialogTitle,
|
|
DialogTrigger,
|
|
} from 'ui'
|
|
|
|
import { LintInfo } from '../Linter/Linter.constants'
|
|
import { useLintRuleDeleteMutation } from '@/data/lint/delete-lint-rule-mutation'
|
|
import { LintException } from '@/data/lint/lint-rules-query'
|
|
|
|
interface EnableRuleModalProps {
|
|
lint: LintInfo
|
|
rule: LintException
|
|
}
|
|
|
|
export const EnableRuleModal = ({ lint, rule }: EnableRuleModalProps) => {
|
|
const { ref } = useParams()
|
|
|
|
const [open, setOpen] = useState(false)
|
|
|
|
const { mutate: deleteRule, isPending: isDeleting } = useLintRuleDeleteMutation({
|
|
onSuccess: () => {
|
|
toast.success(`Successfully enabled the "${lint.title}" rule`)
|
|
setOpen(false)
|
|
},
|
|
})
|
|
|
|
const onDeleteRule = () => {
|
|
if (!ref) return console.error('Project ref is required')
|
|
deleteRule({ projectRef: ref, ids: [rule.id] })
|
|
}
|
|
|
|
return (
|
|
<Dialog open={open} onOpenChange={setOpen}>
|
|
<DialogTrigger asChild>
|
|
<Button variant="default">Enable rule</Button>
|
|
</DialogTrigger>
|
|
<DialogContent size="small">
|
|
<DialogHeader>
|
|
<DialogTitle>Enable rule</DialogTitle>
|
|
</DialogHeader>
|
|
<DialogSectionSeparator />
|
|
<DialogSection>
|
|
<p className="text-sm">
|
|
The "{lint.title}" rule will be visible in the Advisor reports, and will be included in
|
|
email notifications for this project.
|
|
</p>
|
|
</DialogSection>
|
|
<DialogFooter>
|
|
<Button disabled={isDeleting} variant="default" onClick={() => setOpen(false)}>
|
|
Cancel
|
|
</Button>
|
|
<Button loading={isDeleting} variant="primary" onClick={onDeleteRule}>
|
|
Enable
|
|
</Button>
|
|
</DialogFooter>
|
|
</DialogContent>
|
|
</Dialog>
|
|
)
|
|
}
|