mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 09:55:06 +03:00
Gildas GarciaandIvan Vasilov
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
13 lines
306 B
TypeScript
13 lines
306 B
TypeScript
import { Button, Input } from 'ui'
|
|
|
|
export default function InputWithButton() {
|
|
return (
|
|
<div className="flex w-full max-w-sm items-center space-x-2">
|
|
<Input type="email" placeholder="Email" />
|
|
<Button type="submit" variant="secondary">
|
|
Subscribe
|
|
</Button>
|
|
</div>
|
|
)
|
|
}
|