Files
Saxon FletcherandCopilot 986f3464a6 Advisor refine (#40293)
* advisor panel title

* refactor

* use badge for critical

* Update apps/studio/components/ui/AdvisorPanel/AdvisorPanel.utils.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* refactor

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-11 10:32:50 +10:00

170 lines
5.7 KiB
TypeScript

import { AlertTriangle, ChevronRight, Inbox } from 'lucide-react'
import { Lint } from 'data/lint/lint-query'
import { Notification } from 'data/notifications/notifications-v2-query'
import { AdvisorSeverity, AdvisorTab } from 'state/advisor-state'
import { Badge, Button, cn } from 'ui'
import { GenericSkeletonLoader } from 'ui-patterns'
import type { AdvisorItem } from './AdvisorPanel.types'
import {
formatItemDate,
getAdvisorItemDisplayTitle,
getLintEntityString,
severityBadgeVariants,
severityColorClasses,
severityLabels,
tabIconMap,
} from './AdvisorPanel.utils'
import { EmptyAdvisor } from './EmptyAdvisor'
const NoProjectNotice = () => {
return (
<div className="absolute top-28 px-6 flex flex-col items-center justify-center w-full gap-y-2">
<Inbox className="text-foreground-muted" strokeWidth={1} />
<div className="text-center">
<p className="heading-default">Project required</p>
<p className="text-foreground-light text-sm">
Select a project to view security and performance advisories
</p>
</div>
</div>
)
}
interface AdvisorPanelBodyProps {
isLoading: boolean
isError: boolean
filteredItems: AdvisorItem[]
activeTab: AdvisorTab
severityFilters: AdvisorSeverity[]
onItemClick: (item: AdvisorItem) => void
onClearFilters: () => void
hiddenItemsCount: number
hasAnyFilters: boolean
hasProjectRef?: boolean
}
export const AdvisorPanelBody = ({
isLoading,
isError,
filteredItems,
activeTab,
severityFilters,
onItemClick,
onClearFilters,
hiddenItemsCount,
hasAnyFilters,
hasProjectRef = true,
}: AdvisorPanelBodyProps) => {
// Show notice if no project ref and trying to view project-specific tabs
if (!hasProjectRef && activeTab !== 'messages') {
return <NoProjectNotice />
}
if (isLoading) {
return (
<div>
<GenericSkeletonLoader className="w-full p-4" />
</div>
)
}
if (isError) {
return (
<div className="my-8 mx-4 flex flex-col items-center gap-2">
<AlertTriangle className="text-destructive" />
<h2 className="text-base text-foreground-light">Error loading advisories</h2>
<p className="text-sm text-foreground-lighter">Please try again later.</p>
</div>
)
}
if (filteredItems.length === 0) {
return (
<EmptyAdvisor
activeTab={activeTab}
hasFilters={hasAnyFilters}
onClearFilters={onClearFilters}
/>
)
}
return (
<>
<div className="flex flex-col">
{filteredItems.map((item) => {
const SeverityIcon = tabIconMap[item.tab as Exclude<AdvisorTab, 'all'>]
const severityClass = severityColorClasses[item.severity]
const isNotification = item.source === 'notification'
const notification = isNotification ? (item.original as Notification) : null
const isUnread = notification?.status === 'new'
const lint = !isNotification ? (item.original as Lint) : null
// Primary text: issue type for lint items, title for notifications
const primaryText = getAdvisorItemDisplayTitle(item)
// Secondary text: entity for lint items when no date, date for notifications
const hasDate = !!item.createdAt
const entityString = getLintEntityString(lint)
return (
<div key={`${item.source}-${item.id}`} className="border-b">
<Button
type="text"
className={cn(
'justify-start w-full block rounded-none h-auto py-3 px-4 hover:text-foreground',
isUnread && 'bg-surface-100/50'
)}
onClick={() => onItemClick(item)}
>
<div className="flex items-center justify-between gap-2">
<div className="flex items-center gap-3 overflow-hidden">
<SeverityIcon
size={16}
strokeWidth={1.5}
className={cn('flex-shrink-0', severityClass)}
/>
<div className="text-left flex flex-col gap-0.5 truncate flex-1 min-w-0">
<div className="truncate">{primaryText}</div>
{hasDate ? (
<span className="text-xs text-foreground-light capitalize-sentence">
{formatItemDate(item.createdAt!)}
</span>
) : (
entityString && (
<div className="flex items-center gap-1 text-xs text-foreground-light">
<span className="truncate">{entityString}</span>
</div>
)
)}
</div>
</div>
<div className="flex items-center gap-2 flex-shrink-0">
{item.severity === 'critical' && (
<Badge variant={severityBadgeVariants[item.severity]}>
{severityLabels[item.severity]}
</Badge>
)}
<ChevronRight
size={16}
strokeWidth={1.5}
className="flex-shrink-0 text-foreground-lighter"
/>
</div>
</div>
</Button>
</div>
)
})}
</div>
{severityFilters.length > 0 && hiddenItemsCount > 0 && (
<div className="px-4 py-3">
<Button type="text" className="w-full" onClick={onClearFilters}>
Show {hiddenItemsCount} more issue{hiddenItemsCount !== 1 ? 's' : ''}
</Button>
</div>
)}
</>
)
}