mirror of
https://github.com/supabase/supabase.git
synced 2026-10-09 03:15:06 +03:00
## Details of change Re-lands DATAENG-1468 (docs page feedback to Postgres) with an **insert-only** design that avoids the cross-project auth issue that caused the prior revert. - New insert-only `feedback_comments` table: anon `insert` policy only (no select/update/delete). Columns: `page`, `vote`, `title`, `comment`, `user_id`, `metadata`. - The docs widget writes the free-text comment to `feedback_comments` via the **anon key**. The votes `feedback` table is untouched (one row per vote). - No user token is sent to the content project anymore (that was the cause of the previous failure): the feedback client uses the anon key only. - The commenter's account user id (gotrue UUID) is read client-side from the session and stored as a plain `user_id` column for attribution (comments are logged-in-only). Org/project association is derived downstream in BigQuery via that id; docs pages aren't project-scoped, so there's no project_ref/org to capture here. - Removed the previous update-by-id approach, the per-user RLS policies, and the obsolete unit test. ## Why the previous version was reverted It authenticated feedback writes with the supabase.com account session token, but the requests target the docs content project (`xguihxuzqibwxjnimxev`), which cannot verify that token. Logged-in users got `PGRST301 / JWSInvalidSignature`. This version removes the user token entirely, so writes succeed for everyone. ## Verification Insert-only RLS means a row can be written but not read/updated/deleted by `anon`. Comments retrievable with `where comment is not null` is not needed (separate table); just query `feedback_comments`. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * The feedback form now captures a vote rating along with an optional title and detailed comments, saving richer context for review. * **Refactor** * Feedback submission has been streamlined to write directly to the database for both vote and comment submissions. * **Maintenance** * Updated the feedback data typings to support the new title, comment, user, page, and vote fields via the new feedback comments storage. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
236 lines
7.7 KiB
TypeScript
236 lines
7.7 KiB
TypeScript
'use client'
|
|
|
|
import { createClient } from '@supabase/supabase-js'
|
|
import { IS_PLATFORM } from '~/lib/constants'
|
|
import { useSendTelemetryEvent } from '~/lib/telemetry'
|
|
import { gotrueClient, useConstant, useIsLoggedIn, type Database } from 'common'
|
|
import { Check, MessageSquareQuote, X } from 'lucide-react'
|
|
import { usePathname } from 'next/navigation'
|
|
import {
|
|
forwardRef,
|
|
useReducer,
|
|
useRef,
|
|
useState,
|
|
type CSSProperties,
|
|
type MouseEventHandler,
|
|
} from 'react'
|
|
import { Button, cn } from 'ui'
|
|
|
|
import { getSanitizedTabParams } from './Feedback.utils'
|
|
import { FeedbackModal, type FeedbackFields } from './FeedbackModal'
|
|
|
|
const FeedbackButton = forwardRef<
|
|
HTMLButtonElement,
|
|
{ isYes: boolean; onClick: MouseEventHandler; visible: boolean }
|
|
>(({ isYes, onClick, visible }, ref) => {
|
|
const isLoggedIn = useIsLoggedIn()
|
|
if (!isLoggedIn) return null
|
|
|
|
return (
|
|
<button
|
|
ref={ref}
|
|
className={cn(
|
|
'mt-0',
|
|
'flex items-center gap-1',
|
|
'text-xs text-foreground-lighter',
|
|
'hover:text-foreground text-left',
|
|
!visible && 'opacity-0 invisible',
|
|
'[transition-property:opacity,color]',
|
|
'[transition-delay:700ms,0ms]'
|
|
)}
|
|
onClick={onClick}
|
|
>
|
|
{isYes ? <>What went well?</> : <>How can we improve?</>}
|
|
<MessageSquareQuote size={14} strokeWidth={1.5} />
|
|
</button>
|
|
)
|
|
})
|
|
FeedbackButton.displayName = 'FeedbackButton'
|
|
|
|
type Response = 'yes' | 'no'
|
|
|
|
enum StateType {
|
|
Unanswered = 'unanswered',
|
|
Followup = 'followup',
|
|
}
|
|
|
|
type State = { type: StateType.Unanswered } | { type: StateType.Followup; response: Response }
|
|
|
|
type Action = { event: 'VOTED'; response: Response }
|
|
|
|
const initialState = { type: StateType.Unanswered } satisfies State
|
|
|
|
function reducer(state: State, action: Action) {
|
|
switch (action.event) {
|
|
case 'VOTED':
|
|
if (state.type === StateType.Unanswered)
|
|
return { type: StateType.Followup, response: action.response }
|
|
default:
|
|
return state
|
|
}
|
|
}
|
|
|
|
function Feedback({ className }: { className?: string }) {
|
|
const [state, dispatch] = useReducer(reducer, initialState)
|
|
const [modalOpen, setModalOpen] = useState(false)
|
|
const feedbackButtonRef = useRef<HTMLButtonElement>(null)
|
|
|
|
const pathname = usePathname() ?? ''
|
|
const sendTelemetryEvent = useSendTelemetryEvent()
|
|
const supabase = useConstant(() =>
|
|
IS_PLATFORM
|
|
? createClient<Database>(
|
|
process.env.NEXT_PUBLIC_SUPABASE_URL!,
|
|
process.env.NEXT_PUBLIC_SUPABASE_ANON_KEY!
|
|
)
|
|
: undefined
|
|
)
|
|
|
|
const unanswered = state.type === 'unanswered'
|
|
const isYes = 'response' in state && state.response === 'yes'
|
|
const isNo = 'response' in state && state.response === 'no'
|
|
const showYes = unanswered || isYes
|
|
const showNo = unanswered || isNo
|
|
|
|
async function sendFeedbackVote(response: Response) {
|
|
if (!supabase) return
|
|
const { error } = await supabase
|
|
.from('feedback')
|
|
.insert({ vote: response, page: pathname, metadata: { query: getSanitizedTabParams() } })
|
|
if (error) console.error(error)
|
|
}
|
|
|
|
function handleVote(response: Response) {
|
|
sendTelemetryEvent({
|
|
action: 'docs_feedback_clicked',
|
|
properties: { response },
|
|
})
|
|
sendFeedbackVote(response)
|
|
dispatch({ event: 'VOTED', response })
|
|
// Focus so screen reader users are aware of the new element
|
|
setTimeout(() => {
|
|
feedbackButtonRef.current?.focus()
|
|
// Wait for element to show up first
|
|
}, 700)
|
|
}
|
|
|
|
function refocusButton() {
|
|
setTimeout(() => {
|
|
feedbackButtonRef.current?.focus()
|
|
// Wait for modal to disappear and button to become focusable again
|
|
}, 100)
|
|
}
|
|
|
|
async function handleSubmit({ comment, title }: FeedbackFields) {
|
|
if (supabase) {
|
|
const userId = (await gotrueClient.getSession()).data.session?.user?.id ?? null
|
|
const { error } = await supabase.from('feedback_comments').insert({
|
|
page: pathname,
|
|
// @ts-expect-error -- the comment modal only opens after a vote, so state.response is set
|
|
vote: state.response,
|
|
title,
|
|
comment,
|
|
user_id: userId,
|
|
metadata: { query: getSanitizedTabParams() },
|
|
})
|
|
if (error) console.error(error)
|
|
}
|
|
setModalOpen(false)
|
|
refocusButton()
|
|
}
|
|
|
|
return (
|
|
<section className={cn('@container', className)} aria-labelledby="feedback-title">
|
|
<h3 id="feedback-title" className="block font-mono text-xs text-foreground-light mb-3">
|
|
Is this helpful?
|
|
</h3>
|
|
<div className="relative flex flex-col gap-2 @[12rem]:gap-4 @[12rem]:flex-row @[12rem]:items-center">
|
|
<div
|
|
style={{ '--container-flex-gap': '0.5rem' } as CSSProperties}
|
|
className="relative flex gap-2 items-center"
|
|
>
|
|
<Button
|
|
variant="outline"
|
|
rounded
|
|
className={cn(
|
|
'px-1 w-7 h-7',
|
|
'text-foreground-light',
|
|
'[transition-property:opacity,transform,color] [transition-duration:150ms,250ms,250ms]',
|
|
'motion-reduce:[transition-duration:150ms,1ms,300ms]',
|
|
'[transition-timing-function:cubic-bezier(.76,0,.23,1)]',
|
|
!isNo && 'hover:text-warning hover:border-warning-500',
|
|
isNo && `bg-warning text-warning-200 border-warning! disabled:opacity-100`,
|
|
!showNo && 'opacity-0 invisible'
|
|
)}
|
|
onClick={() => handleVote('no')}
|
|
disabled={state.type === StateType.Followup}
|
|
>
|
|
<X size={14} strokeWidth={2} className="text-current" />
|
|
<span className="sr-only">No</span>
|
|
</Button>
|
|
<Button
|
|
variant="outline"
|
|
rounded
|
|
className={cn(
|
|
'px-1 w-7 h-7',
|
|
'text-foreground-light',
|
|
'[transition-property:opacity,transform,color] [transition-duration:150ms,250ms,250ms]',
|
|
'motion-reduce:[transition-duration:150ms,1ms,300ms]',
|
|
'[transition-timing-function:cubic-bezier(.76,0,.23,1)]',
|
|
!isYes && 'hover:text-brand-600 hover:border-brand-500',
|
|
isYes &&
|
|
'bg-brand text-brand-200 border-brand! disabled:opacity-100 -translate-x-[calc(100%+var(--container-inline-flex-gap,0.5rem))]',
|
|
!showYes && 'opacity-0 invisible'
|
|
)}
|
|
onClick={() => handleVote('yes')}
|
|
disabled={state.type === StateType.Followup}
|
|
>
|
|
<Check size={14} strokeWidth={2} />
|
|
<span className="sr-only">Yes</span>
|
|
</Button>
|
|
</div>
|
|
<div
|
|
className={cn(
|
|
'flex flex-col gap-0.5',
|
|
'@[12rem]:absolute @[12rem]:left-9',
|
|
'text-xs',
|
|
'opacity-0 invisible',
|
|
'text-left',
|
|
'-translate-x-2',
|
|
'[transition-property:opacity,transform]',
|
|
'[transition-duration:450ms,300ms]',
|
|
'[transition-delay:200ms,0ms]',
|
|
'[transition-timing-function:cubic-bezier(.76,0,.23,1)]',
|
|
'motion-reduce:[transition-duration:150ms,1ms]',
|
|
'ease-out!',
|
|
state.type === StateType.Followup && 'opacity-100 visible translate-x-0'
|
|
)}
|
|
>
|
|
{state.type === StateType.Followup && (
|
|
<>
|
|
<span className="text-foreground-light">Thanks for your feedback!</span>
|
|
<FeedbackButton
|
|
ref={feedbackButtonRef}
|
|
onClick={() => setModalOpen(true)}
|
|
isYes={isYes}
|
|
visible={true}
|
|
/>
|
|
</>
|
|
)}
|
|
</div>
|
|
</div>
|
|
<FeedbackModal
|
|
visible={modalOpen}
|
|
page={pathname}
|
|
onCancel={() => {
|
|
setModalOpen(false)
|
|
refocusButton()
|
|
}}
|
|
onSubmit={handleSubmit}
|
|
/>
|
|
</section>
|
|
)
|
|
}
|
|
|
|
export { Feedback }
|