mirror of
https://github.com/supabase/supabase.git
synced 2026-10-15 14:19:11 +03:00
Alaister YoungandAlaister Young
29af5308f3
Copy/export of selected rows in the Table Editor refetches full values for cells truncated in the grid (via `getCellValue`), but that refetch was bypassing role impersonation. The main grid query respects the impersonated role; the truncated-cell hydration didn't, so the copy could fetch as the service role even when "View as <role>" was active – an inconsistency, since the UI still indicates the impersonated role is in effect. Threads `roleImpersonationState` through `hydrateTruncatedRows` → `getCellValue`, and wraps the SQL in `wrapWithRoleImpersonation` (matching how `getTableRows` does it). Addresses FE-3493. **Changed:** - `getCellValue` accepts an optional `roleImpersonationState` and wraps its SQL with `wrapWithRoleImpersonation` + flags `isRoleImpersonationEnabled` on `executeSql` - `hydrateTruncatedRows` threads `roleImpersonationState` through to `getCellValue` - `Header.tsx`'s `onCopyRows` passes the in-scope `roleImpersonationState` into `hydrateTruncatedRows` ## To test 1. Open the Table Editor on a table with a row containing a large/truncated string value and a primary key 2. Enable role impersonation → "View as role" → pick any role with read access to the table 3. Select the row, then `Copy → Copy as JSON` (also try CSV / SQL) 4. The copy should succeed and contain the full (non-truncated) value 5. Inspect the SQL request – it should now be wrapped with the impersonation context, matching how the main grid query is wrapped Co-authored-by: Alaister Young <10985857+alaister@users.noreply.github.com>
78 lines
2.1 KiB
TypeScript
78 lines
2.1 KiB
TypeScript
import { ident } from '@supabase/pg-meta'
|
|
import { Query } from '@supabase/pg-meta/src/query'
|
|
import { useMutation } from '@tanstack/react-query'
|
|
import { toast } from 'sonner'
|
|
|
|
import { executeSql } from '@/data/sql/execute-sql-query'
|
|
import { RoleImpersonationState, wrapWithRoleImpersonation } from '@/lib/role-impersonation'
|
|
import { isRoleImpersonationEnabled } from '@/state/role-impersonation-state'
|
|
import type { ResponseError, UseCustomMutationOptions } from '@/types'
|
|
|
|
export type GetCellValueVariables = {
|
|
projectRef: string
|
|
connectionString?: string | null
|
|
table: { schema: string; name: string }
|
|
column: string
|
|
pkMatch: { [key: string]: any }
|
|
roleImpersonationState?: RoleImpersonationState
|
|
}
|
|
|
|
export function getCellValueSql({
|
|
table,
|
|
column,
|
|
pkMatch,
|
|
}: Pick<GetCellValueVariables, 'table' | 'column' | 'pkMatch'>) {
|
|
return new Query()
|
|
.from(table.name, table.schema ?? undefined)
|
|
.select(ident(column))
|
|
.match(pkMatch)
|
|
.toSql()
|
|
}
|
|
|
|
export async function getCellValue({
|
|
projectRef,
|
|
connectionString,
|
|
table,
|
|
column,
|
|
pkMatch,
|
|
roleImpersonationState,
|
|
}: GetCellValueVariables) {
|
|
const sql = wrapWithRoleImpersonation(
|
|
getCellValueSql({ table, column, pkMatch }),
|
|
roleImpersonationState
|
|
)
|
|
const { result } = await executeSql({
|
|
projectRef,
|
|
connectionString,
|
|
sql,
|
|
isRoleImpersonationEnabled: isRoleImpersonationEnabled(roleImpersonationState?.role),
|
|
})
|
|
return result?.[0][column]
|
|
}
|
|
|
|
type TableRowCreateData = Awaited<ReturnType<typeof getCellValue>>
|
|
|
|
export const useGetCellValueMutation = ({
|
|
onSuccess,
|
|
onError,
|
|
...options
|
|
}: Omit<
|
|
UseCustomMutationOptions<TableRowCreateData, ResponseError, GetCellValueVariables>,
|
|
'mutationFn'
|
|
> = {}) => {
|
|
return useMutation<TableRowCreateData, ResponseError, GetCellValueVariables>({
|
|
mutationFn: (vars) => getCellValue(vars),
|
|
async onSuccess(data, variables, context) {
|
|
await onSuccess?.(data, variables, context)
|
|
},
|
|
async onError(data, variables, context) {
|
|
if (onError === undefined) {
|
|
toast.error(data.message)
|
|
} else {
|
|
onError(data, variables, context)
|
|
}
|
|
},
|
|
...options,
|
|
})
|
|
}
|