Saxon FletcherandClaude Opus 5
2327acf7a7
MDXEditor's markdownShortcutPlugin reads match[1] from Lexical's code fence regex. Lexical 0.48 added a capture group for the fence itself, shifting the language to match[2], so typing ```sql set the code block language to the literal fence. MDXEditor 4.1.0 adopted 0.48 without updating the index; it is still wrong on 4.2.3 and on main upstream. The patch fixed this with a one-character change, but a patched dependency is a lot of weight for the symptom. Only the typing shortcut is affected -- markdown import goes through MdastCodeVisitor and reads mdastNode.lang -- so normalizing a bare fence to an unset language in getCodeBlockLanguage covers it. Typing ```sql now yields a plain text block that the existing language picker can change. Narrow the guard to fences rather than falling back for every unknown language, so a genuine ```python block still shows its own name instead of being relabeled as plain text. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
UI Testing Notes
Rules
-
All tests should be run consistently (avoid situations whereby tests fails "sometimes")
-
Group tests in folders based on the feature they are testing. Avoid file/folder based folder names since those can change and we will forget to update the tests.
Examples: /logs /reports /projects /database-settings /auth
Custom Render and Custom Render Hook
customRender and customRenderHook are wrappers around render and renderHook that add some necessary providers like QueryClientProvider, TooltipProvider and NuqsTestingAdapter.
Generally use those instead of the default render and renderHook functions.
import { customRender, customRenderHook } from 'tests/lib/custom-render'
customRender(<MyComponent />)
customRenderHook(() => useMyHook())
Mocking API Requests
To mock API requests, we use the msw library.
Global mocks can be found in tests/lib/msw-global-api-mocks.ts.
To mock an endpoint you can use the addAPIMock function. Make sure to add the mock in the beforeEach hook. It won't work with beforeAll if you have many tests.
beforeEach(() => {
addAPIMock({
method: 'get',
path: '/api/my-endpoint',
response: {
data: { foo: 'bar' },
},
})
})
API Mocking Tips:
- Keep mocks in the same folder as the tests that use them
- Add a test to verify the mock is working
This will make debugging and updating the mocks easier.
test('mock is working', async () => {
const response = await fetch('/api/my-endpoint')
expect(response.json()).resolves.toEqual({ data: { foo: 'bar' } })
})
Mocking Nuqs URL Parameters
To render a component that uses Nuqs with some predefined query parameters, you can use customRender with the nuqs prop.
customRender(<MyComponent />, {
nuqs: {
searchParams: {
search: 'hello world',
},
},
})
<Popover> vs <Dropdown>
When simulating clicks on these components, do the following:
// for Popovers
import userEvent from '@testing-library/user-event'
await userEvent.click('Hello world')
// for Dropdowns
import clickDropdown from 'tests/helpers'
clickDropdown('Hello world')