Files
supabase/apps/studio/components/layouts/AppLayout/AdvisorButton.test.tsx
Danny White d067e81a69 fix(ui): align primary colours across text, buttons, and controls (#50697)
## Problem

Primary colour serves readable text and selected controls, but those
uses need different shades. Light mode needs darker text, while dark
mode needs a deeper button fill. Fixed brand green on interactive chrome
also prevents a custom primary hue from carrying through the interface.
Some slider tracks and selected text are hard to read.

## Solution

- Keep `--primary` for accessible text and small selected indicators.
Use `--primary-solid` for button fills, which need a deeper shade in
dark mode.
- Add `--primary-bright` for focus rings, selected control chrome, chart
accents, and other interactive highlights. It follows `--primary-hue`;
`brand-*` stays fixed for Supabase identity.
- Make slider troughs clearer and text selection translucent with theme
foreground text.
- Document the split in the design-system colour guide.

| Before | After |
| --- | --- |
| <img width="980" height="244" alt="Before: light mode primary
controls"
src="https://github.com/user-attachments/assets/dfae325d-0dfe-4231-8bcd-3f89c4b9d793"
/> | <img width="982" height="204" alt="After: light mode primary
controls"
src="https://github.com/user-attachments/assets/5fdcb531-a6e3-4549-8a13-9d9a5ebe6e20"
/> |
| <img width="610" height="120" alt="Before: slider track"
src="https://github.com/user-attachments/assets/04f768e0-51e8-4d06-9b97-c52f4a34f122"
/> | <img width="622" height="126" alt="After: slider track"
src="https://github.com/user-attachments/assets/95127f4e-13dc-4f0f-b63c-cf5d70a28b42"
/> |
| <img width="652" height="512" alt="Before: dark mode controls"
src="https://github.com/user-attachments/assets/3f88de66-90cc-40ee-8cf1-b5f4eb87b09a"
/> | <img width="658" height="498" alt="After: dark mode controls"
src="https://github.com/user-attachments/assets/906bec30-6ca1-4614-9fb3-6cf5e5feec22"
/> |

## Review instructions

1. Compare light and dark mode in the [colour usage
guide](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#primary-and-brand-colors).
Check primary ink, primary-solid, primary-bright, and fixed brand
swatches.
2. In Studio, open the ‘new table’ sheet in [Table
Editor](https://studio-staging-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/dashboard/project/_/editor).
Tab through the new table sheet's fields and toggles. Check the focus
rings, selected controls, and the sheet's edges in both themes. You do
not need to save a table.
3. Select text in Studio in both themes, including a link or
primary-coloured label. The selection and text should remain legible.
4. Check the
[Field](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/field)
Price Range slider: the unused track should remain visible in both
themes. The selected field card border should follow primary-bright.
5. Check the
[Button](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/button)
and [Radio
Group](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/radio-group)
previews. In dark mode, `primary` button fill should be deeper than
primary
[text](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#text);
selected radios should remain readable.
2026-09-24 09:56:31 +10:00

160 lines
4.5 KiB
TypeScript

import { screen } from '@testing-library/react'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { AdvisorButton } from '@/components/layouts/AppLayout/AdvisorButton'
import { render } from '@/tests/helpers'
const {
mockUseProjectLintsQuery,
mockUseNotificationsV2Query,
mockUseAdvisorSignals,
mockToggleSidebar,
} = vi.hoisted(() => ({
mockUseProjectLintsQuery: vi.fn(),
mockUseNotificationsV2Query: vi.fn(),
mockUseAdvisorSignals: vi.fn(),
mockToggleSidebar: vi.fn(),
}))
vi.mock('@/data/lint/lint-query', () => ({
useProjectLintsQuery: mockUseProjectLintsQuery,
}))
vi.mock('@/data/notifications/notifications-v2-query', () => ({
useNotificationsV2Query: mockUseNotificationsV2Query,
}))
vi.mock('@/components/ui/AdvisorPanel/useAdvisorSignals', () => ({
useAdvisorSignals: mockUseAdvisorSignals,
}))
vi.mock('@/lib/constants', async (importOriginal) => ({
...(await importOriginal<typeof import('@/lib/constants')>()),
IS_PLATFORM: true,
}))
vi.mock('@/state/sidebar-manager-state', () => ({
useSidebarManagerSnapshot: () => ({
toggleSidebar: mockToggleSidebar,
activeSidebar: undefined,
}),
}))
describe('AdvisorButton', () => {
beforeEach(() => {
mockUseProjectLintsQuery.mockReturnValue({ data: [], isPending: false, isError: false })
mockUseNotificationsV2Query.mockReturnValue({
data: { pages: [[]] },
isPending: false,
isError: false,
})
mockUseAdvisorSignals.mockReturnValue({
data: [],
isPending: false,
isError: false,
dismissSignal: vi.fn(),
})
})
it('shows a warning dot when advisor signals are present', () => {
mockUseAdvisorSignals.mockReturnValue({
data: [
{
id: 'signal-1',
fingerprint: 'signal:banned-ip:203.0.113.10:v1',
source: 'signal',
signalType: 'banned-ip',
severity: 'warning',
tab: 'security',
title: 'Banned IP address',
description: 'Signal',
actions: [],
sourceData: {
type: 'banned-ip',
ip: '203.0.113.10',
},
},
],
isPending: false,
isError: false,
dismissSignal: vi.fn(),
})
const { container } = render(<AdvisorButton projectRef="project-ref" />)
expect(container.querySelector('.bg-warning')).toBeInTheDocument()
expect(container.querySelector('.bg-destructive')).not.toBeInTheDocument()
expect(container.querySelector('.bg-primary-bright')).not.toBeInTheDocument()
})
it('keeps the destructive dot when a critical issue is present', () => {
mockUseProjectLintsQuery.mockReturnValue({
data: [
{
cache_key: 'lint-1',
name: 'unknown_lint',
detail: 'Critical lint detail',
description: 'Description',
level: 'ERROR',
categories: ['SECURITY'],
metadata: {},
},
],
isPending: false,
isError: false,
})
mockUseAdvisorSignals.mockReturnValue({
data: [
{
id: 'signal-1',
fingerprint: 'signal:banned-ip:203.0.113.10:v1',
source: 'signal',
signalType: 'banned-ip',
severity: 'warning',
tab: 'security',
title: 'Banned IP address',
description: 'Signal',
actions: [],
sourceData: {
type: 'banned-ip',
ip: '203.0.113.10',
},
},
],
isPending: false,
isError: false,
dismissSignal: vi.fn(),
})
const { container } = render(<AdvisorButton projectRef="project-ref" />)
expect(container.querySelector('.bg-destructive')).toBeInTheDocument()
expect(container.querySelector('.bg-warning')).not.toBeInTheDocument()
})
it('falls back to the brand dot for unread notifications when there are no issues', () => {
mockUseNotificationsV2Query.mockReturnValue({
data: {
pages: [
[
{
id: 'notif-1',
status: 'new',
priority: 'Info',
},
],
],
},
isPending: false,
isError: false,
})
const { container } = render(<AdvisorButton projectRef="project-ref" />)
expect(container.querySelector('.bg-primary-bright')).toBeInTheDocument()
expect(container.querySelector('.bg-warning')).not.toBeInTheDocument()
expect(container.querySelector('.bg-destructive')).not.toBeInTheDocument()
expect(screen.getByRole('button')).toBeInTheDocument()
})
})