mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 18:05:11 +03:00
Alaister YoungandAlaister Young
2f1ad03640
The www build saves failed GitHub star requests as zero, which the navigation displays as `0K`. This passes `GITHUB_TOKEN` through Turbo's build environment and preserves a valid previously generated count when a request fails. If there is no valid previous count, the navigation displays “GitHub” and the homepage contribution graphic omits the number. Cached fallback is available only when the previous generated content exists; rate limiting is a possible cause of the original failure, but has not been confirmed from deployment logs. ## To test - Run `pnpm --filter www exec vitest run scripts/lib/githubStars.test.ts` — all 16 tests pass, covering authenticated and anonymous requests, rate limiting, malformed responses, and missing or invalid cached content. - Build with a valid `GITHUB_TOKEN` and check that the navigation and homepage graphic show the star count. - Simulate a failed GitHub request with and without existing generated content. Confirm that a valid previous count is retained, or that no zero count appears when none is available. Verified locally: live GitHub fetch through the new loader, Turbo dry run with strict environment filtering and `GITHUB_TOKEN` allowed, Prettier, and ESLint (one existing default-export warning). Full build and browser checks have not been run. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - GitHub star counts are now displayed only when valid; otherwise, the interface shows a clear fallback label. - Star counts can fall back to cached data when GitHub is unavailable or returns invalid results. - Builds without GitHub data now complete gracefully instead of failing. - **Tests** - Added coverage for authenticated and unauthenticated requests, cached fallbacks, invalid responses, and clean builds. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Alaister Young <10985857+alaister@users.noreply.github.com>
56 lines
2.9 KiB
TypeScript
56 lines
2.9 KiB
TypeScript
import staticContent from '.generated/staticContent/_index.json'
|
|
import { useSendTelemetryEvent } from '~/lib/telemetry'
|
|
import { Button } from 'ui'
|
|
|
|
export const kFormatter = (num: number) => {
|
|
const kFormat = Math.floor(num / 1000)
|
|
const lastTwoDigits = num % 1000
|
|
|
|
const decimalPart = Math.floor((lastTwoDigits % 100) / 10)
|
|
const hundreds = Math.floor(lastTwoDigits / 100)
|
|
|
|
const isAlmostNextThousand = decimalPart >= 8 && hundreds >= 9
|
|
|
|
const showDecimals =
|
|
(!isAlmostNextThousand && hundreds >= 1) || (hundreds === 0 && decimalPart >= 8)
|
|
|
|
return showDecimals
|
|
? `${kFormat}.${decimalPart >= 8 ? hundreds + 1 : hundreds}K`
|
|
: `${isAlmostNextThousand ? kFormat + 1 : kFormat}K`
|
|
}
|
|
|
|
const GitHubButton = () => {
|
|
const sendTelemetryEvent = useSendTelemetryEvent()
|
|
const githubStars = staticContent.githubStars
|
|
|
|
return (
|
|
<Button
|
|
className="hidden group lg:flex text-foreground-light hover:text-foreground in-data-nav-transparent:text-foreground"
|
|
variant="text"
|
|
asChild
|
|
onClick={() => sendTelemetryEvent({ action: 'homepage_github_button_clicked' })}
|
|
>
|
|
<a type={undefined} href="https://github.com/supabase/supabase" target="_blank">
|
|
<span className="flex items-center gap-1">
|
|
<svg
|
|
className="w-6 h-6"
|
|
viewBox="0 0 17 16"
|
|
fill="none"
|
|
xmlns="http://www.w3.org/2000/svg"
|
|
>
|
|
<path
|
|
fillRule="evenodd"
|
|
clipRule="evenodd"
|
|
d="M8.5 2.22168C5.23312 2.22168 2.58496 4.87398 2.58496 8.14677C2.58496 10.7642 4.27962 12.9853 6.63026 13.7684C6.92601 13.8228 7.03366 13.6401 7.03366 13.4827C7.03366 13.3425 7.02893 12.9693 7.02597 12.4754C5.38041 12.8333 5.0332 11.681 5.0332 11.681C4.76465 10.996 4.37663 10.8139 4.37663 10.8139C3.83954 10.4471 4.41744 10.4542 4.41744 10.4542C5.01072 10.4956 5.32303 11.0647 5.32303 11.0647C5.85065 11.9697 6.70774 11.7082 7.04431 11.5568C7.09873 11.1741 7.25134 10.9132 7.42051 10.7654C6.10737 10.6157 4.72621 10.107 4.72621 7.83683C4.72621 7.19031 4.95689 6.66092 5.33486 6.24686C5.27394 6.09721 5.07105 5.49447 5.39283 4.67938C5.39283 4.67938 5.88969 4.51967 7.01947 5.28626C7.502 5.15466 7.99985 5.08763 8.5 5.08692C9.00278 5.08929 9.50851 5.15495 9.98113 5.28626C11.1103 4.51967 11.606 4.67879 11.606 4.67879C11.9289 5.49447 11.7255 6.09721 11.6651 6.24686C12.0437 6.66092 12.2732 7.19031 12.2732 7.83683C12.2732 10.1129 10.8897 10.6139 9.5724 10.7606C9.78475 10.9434 9.97344 11.3048 9.97344 11.8579C9.97344 12.6493 9.96634 13.2887 9.96634 13.4827C9.96634 13.6413 10.0728 13.8258 10.3733 13.7678C11.5512 13.3728 12.5751 12.6175 13.3003 11.6089C14.0256 10.6002 14.4155 9.38912 14.415 8.14677C14.415 4.87398 11.7663 2.22168 8.5 2.22168Z"
|
|
fill="currentColor"
|
|
/>
|
|
</svg>
|
|
{typeof githubStars === 'number' && githubStars > 0 ? kFormatter(githubStars) : 'GitHub'}
|
|
</span>
|
|
</a>
|
|
</Button>
|
|
)
|
|
}
|
|
|
|
export default GitHubButton
|