Files
supabase/apps/studio/pages/500.tsx
Danny White 1131e3e2ce fix(ui): default Button variant to default instead of primary (#50160)
## What kind of change does this PR introduce?

Bug fix / design-system alignment for the legacy `Button` from `ui`.

## What is the current behavior?

Omitting `variant` on the legacy `Button` falls back to brand-green
`primary`. That makes accidental greens easy, and it is hard to spot the
real main action on busy pages.

## What is the new behavior?

- Legacy `Button` now defaults to neutral `default`
- Intentional primary CTAs (create, save, submit, marketing CTAs, and
matching `ButtonTooltip` usages) now set `variant="primary"` so their
appearance is unchanged
- Neutral actions that previously relied on the old fallback (cancel,
close, back, dashboard nav, and similar) become grey/white
- Design-system docs updated; regression tests cover the new default

`Button_Shadcn_` is unchanged. It already uses its own CVA default.

This is PR 1 of 2 in a stack. PR 2 drops now-redundant
`variant="default"` props.

## To test

Studio (http://localhost:8082):

- `/sign-in`: Sign in stays green
- Open a project → Database → Tables: New table stays green
- Auth → Users → Invite: Invite user stays green; Cancel / dismiss
controls stay neutral
- Project Settings → General: edit a field so Cancel and Save appear.
Cancel is neutral, Save is green

Design system (http://localhost:3003):

- Components → Button: default demo is neutral; primary demo is green;
featured preview is the default variant

Marketing (optional):

- www header: Start your project stays green; logged-in Dashboard is
neutral

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Style**
- Buttons now default to a neutral style, while primary actions across
Studio, documentation, marketing pages, forms, dialogs, and error states
use prominent primary styling.
- Updated button examples and previews clarify the distinction between
default and primary variants.
  - Event registration now includes a directional arrow icon.

- **Tests**
- Added coverage confirming default button styling and explicit primary
styling behave as expected.
- Updated related test fixtures to use primary styling where
appropriate.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-09-10 11:23:17 +10:00

79 lines
2.6 KiB
TypeScript

import { NextPage } from 'next'
import { useTheme } from 'next-themes'
import Image from 'next/legacy/image'
import Link from 'next/link'
import { useRouter } from 'next/router'
import { Button } from 'ui'
import { SupportLink } from '@/components/interfaces/Support/SupportLink'
import { useLastVisitedOrganization } from '@/hooks/misc/useLastVisitedOrganization'
import { useSignOut } from '@/lib/auth'
const Error500: NextPage = () => {
const router = useRouter()
const signOut = useSignOut()
const { resolvedTheme } = useTheme()
const { lastVisitedOrganization } = useLastVisitedOrganization()
const onClickLogout = async () => {
await signOut()
await router.push('/sign-in')
router.reload()
}
return (
<div className="relative mx-auto flex flex-1 w-full flex-col items-center justify-center space-y-6">
<div className="absolute top-0 mx-auto w-full max-w-7xl px-8 pt-6 sm:px-6 lg:px-8">
<nav className="relative flex items-center justify-between sm:h-10">
<div className="flex shrink-0 grow items-center lg:grow-0">
<div className="flex w-full items-center justify-between md:w-auto">
<Link href="/projects">
<Image
src={
resolvedTheme?.includes('dark')
? `${router.basePath}/img/supabase-dark.svg`
: `${router.basePath}/img/supabase-light.svg`
}
alt=""
height={24}
width={120}
/>
</Link>
</div>
</div>
</nav>
</div>
<div className="flex w-[320px] flex-col items-center justify-center space-y-3">
<h4 className="text-lg">Something went wrong 🤕</h4>
<p className="text-center">
Sorry about that, please try again later or feel free to reach out to us if the problem
persists.
</p>
</div>
<div className="flex items-center space-x-4">
{router.pathname !== '/organizations' ? (
<Button variant="primary" asChild>
<Link
href={
!!lastVisitedOrganization ? `/org/${lastVisitedOrganization}` : '/organizations'
}
>
Head back
</Link>
</Button>
) : (
<Button variant="primary" onClick={onClickLogout}>
Head back
</Button>
)}
<Button variant="secondary" asChild>
<SupportLink>Submit a support request</SupportLink>
</Button>
</div>
</div>
)
}
export default Error500