Files
supabase/apps/studio/components/layouts/LogsLayout/LogsSidebarMenuV2.tsx
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

338 lines
10 KiB
TypeScript

import { IS_PLATFORM, useParams } from 'common'
import { ChevronRight, Plus } from 'lucide-react'
import Link from 'next/link'
import { useRouter } from 'next/router'
import React, { useState } from 'react'
import { Button, cn, Collapsible, CollapsibleContent, CollapsibleTrigger, Separator } from 'ui'
import {
InnerSideBarEmptyPanel,
InnerSideBarFilters,
InnerSideBarFilterSearchInput,
InnerSideMenuItem,
} from 'ui-patterns/InnerSideMenu'
import { GenericSkeletonLoader } from 'ui-patterns/ShimmeringLoader'
import { FeaturePreviewSidebarPanel } from '../../ui/FeaturePreviewSidebarPanel'
import { useIsETLPrivateAlpha } from '@/components/interfaces/Database/Replication/useIsETLPrivateAlpha'
import { LOG_DRAIN_TYPES } from '@/components/interfaces/LogDrains/LogDrains.constants'
import { SavedQueriesItem } from '@/components/interfaces/Settings/Logs/Logs.SavedQueriesItem'
import { LogsSidebarItem } from '@/components/interfaces/Settings/Logs/SidebarV2/SidebarItem'
import { UnifiedLogsBanner } from '@/components/interfaces/UnifiedLogs/UnifiedLogsBanner'
import { ButtonTooltip } from '@/components/ui/ButtonTooltip'
import { useContentQuery } from '@/data/content/content-query'
import { useReplicationSourcesQuery } from '@/data/replication/sources-query'
import { useCheckEntitlements } from '@/hooks/misc/useCheckEntitlements'
import { useIsFeatureEnabled } from '@/hooks/misc/useIsFeatureEnabled'
import { useShowMultigresLogs } from '@/hooks/misc/useShowMultigresLogs'
import { useShowPostgresUpgradeLogs } from '@/hooks/misc/useShowPostgresUpgradeLogs'
export function SidebarCollapsible({
children,
title,
defaultOpen,
}: {
children: React.ReactNode
title: string
defaultOpen?: boolean
}) {
return (
<Collapsible defaultOpen={defaultOpen}>
<CollapsibleTrigger className="flex items-center gap-x-2 px-4 [&[data-state=open]>svg]:rotate-90! pb-2">
<ChevronRight
size={16}
className={'text-foreground-light transition-transform duration-200'}
/>
<span className="text-foreground-light font-mono text-sm uppercase">{title}</span>
</CollapsibleTrigger>
<CollapsibleContent>{children}</CollapsibleContent>
</Collapsible>
)
}
export function LogsSidebarMenuV2() {
const router = useRouter()
const { ref } = useParams() as { ref: string }
const [searchText, setSearchText] = useState('')
const {
projectAuthAll: authEnabled,
projectStorageAll: storageEnabled,
realtimeAll: realtimeEnabled,
logsTemplates: templatesEnabled,
logsCollections: collectionsEnabled,
} = useIsFeatureEnabled([
'project_storage:all',
'project_auth:all',
'realtime:all',
'logs:templates',
'logs:collections',
])
const enablePgReplicate = useIsETLPrivateAlpha()
const { data: etlData, isPending: isETLLoading } = useReplicationSourcesQuery(
{
projectRef: ref,
},
{
enabled: enablePgReplicate,
retry: false,
refetchOnMount: false,
refetchOnWindowFocus: false,
}
)
// [Jordi] We only want to show ETL logs if the user has the feature enabled AND they're using the feature aka they've created a source.
const showETLLogs = enablePgReplicate && (etlData?.sources?.length ?? 0) > 0 && !isETLLoading
const { hasAccess: hasDedicatedPooler } = useCheckEntitlements('dedicated_pooler')
const showMultigresLogs = useShowMultigresLogs()
const showPostgresUpgradeLogs = useShowPostgresUpgradeLogs()
const { data: savedQueriesRes, isPending: savedQueriesLoading } = useContentQuery({
projectRef: ref,
type: 'log_sql',
})
const savedQueries = [...(savedQueriesRes?.content ?? [])]
.filter((c) => c.type === 'log_sql')
.sort((a, b) => a.name.localeCompare(b.name))
function isActive(path: string) {
return router.asPath.includes(path)
}
const BASE_COLLECTIONS = [
{
name: 'API Gateway',
key: 'edge-logs',
url: `/project/${ref}/logs/edge-logs`,
items: [],
},
{
name: 'Postgres',
key: 'postgres-logs',
url: `/project/${ref}/logs/postgres-logs`,
items: [],
},
{
name: 'PostgREST',
key: 'postgrest-logs',
url: `/project/${ref}/logs/postgrest-logs`,
items: [],
},
IS_PLATFORM
? {
name: hasDedicatedPooler ? 'Shared Pooler' : 'Pooler',
key: 'pooler-logs',
url: `/project/${ref}/logs/pooler-logs`,
items: [],
}
: null,
hasDedicatedPooler && IS_PLATFORM
? {
name: 'Dedicated Pooler',
key: 'dedicated-pooler-logs',
url: `/project/${ref}/logs/dedicated-pooler-logs`,
items: [],
}
: null,
authEnabled
? {
name: 'Auth',
key: 'auth-logs',
url: `/project/${ref}/logs/auth-logs`,
items: [],
}
: null,
storageEnabled
? {
name: 'Storage',
key: 'storage-logs',
url: `/project/${ref}/logs/storage-logs`,
items: [],
}
: null,
realtimeEnabled
? {
name: 'Realtime',
key: 'realtime-logs',
url: `/project/${ref}/logs/realtime-logs`,
items: [],
}
: null,
{
name: 'Edge Functions',
key: 'edge-functions-logs',
url: `/project/${ref}/logs/edge-functions-logs`,
items: [],
},
{
name: 'Cron',
key: 'pg_cron',
url: `/project/${ref}/logs/pgcron-logs`,
items: [],
},
showETLLogs
? {
name: 'Replication',
key: 'replication_logs',
url: `/project/${ref}/logs/replication-logs`,
items: [],
}
: null,
showMultigresLogs
? {
name: 'Multigres',
key: 'multigres-logs',
url: `/project/${ref}/logs/multigres-logs`,
items: [],
}
: null,
].filter((x) => x !== null)
const OPERATIONAL_COLLECTIONS =
IS_PLATFORM && showPostgresUpgradeLogs
? [
{
name: 'Postgres Version Upgrade',
key: 'pg-upgrade-logs',
url: `/project/${ref}/logs/pg-upgrade-logs`,
items: [],
},
]
: []
const filteredLogs = BASE_COLLECTIONS.filter((collection) => {
return collection?.name.toLowerCase().includes(searchText.toLowerCase())
})
const filteredOperationalLogs = OPERATIONAL_COLLECTIONS.filter((collection) => {
return collection?.name.toLowerCase().includes(searchText.toLowerCase())
})
return (
<div className="pb-4 relative">
<UnifiedLogsBanner />
<div
className={cn(
'flex gap-x-2 items-center sticky top-0 bg-dash-sidebar z-1 px-4',
!templatesEnabled ? 'pt-4' : 'py-4'
)}
>
<InnerSideBarFilters className="w-full p-0 gap-0">
<InnerSideBarFilterSearchInput
name="search-collections"
placeholder="Search collections..."
aria-labelledby="Search collections"
value={searchText}
onChange={(e) => setSearchText(e.target.value)}
/>
</InnerSideBarFilters>
<ButtonTooltip
asChild
icon={<Plus className="text-foreground" />}
className="w-[26px]"
tooltip={{ content: { text: 'New query', side: 'bottom' } }}
>
<Link href={`/project/${ref}/logs/explorer`} />
</ButtonTooltip>
</div>
{templatesEnabled && (
<div className="px-2">
<InnerSideMenuItem
title="Templates"
isActive={isActive(`/project/${ref}/logs/explorer/templates`)}
href={`/project/${ref}/logs/explorer/templates`}
>
Templates
</InnerSideMenuItem>
</div>
)}
<Separator className="my-4" />
{collectionsEnabled && (
<>
<SidebarCollapsible title="Collections" defaultOpen={true}>
{filteredLogs.map((collection) => {
const isItemActive = isActive(collection?.url ?? '')
return (
<LogsSidebarItem
key={collection?.key ?? ''}
isActive={isItemActive}
href={collection?.url ?? ''}
label={collection?.name ?? ''}
/>
)
})}
</SidebarCollapsible>
{OPERATIONAL_COLLECTIONS.length > 0 && (
<>
<Separator className="my-4" />
<SidebarCollapsible title="Database operations" defaultOpen={true}>
{filteredOperationalLogs.map((collection) => (
<LogsSidebarItem
key={collection.key}
isActive={isActive(collection.url)}
href={collection.url}
label={collection.name}
/>
))}
</SidebarCollapsible>
</>
)}
<Separator className="my-4" />
</>
)}
<SidebarCollapsible title="Queries" defaultOpen={true}>
{savedQueriesLoading && (
<div className="p-4">
<GenericSkeletonLoader />
</div>
)}
{savedQueries.length === 0 && (
<InnerSideBarEmptyPanel
className="mx-4"
title="No queries created yet"
description={
IS_PLATFORM ? 'Create and save your queries to use them in the explorer' : undefined
}
actions={
<Button asChild>
<Link href={`/project/${ref}/logs/explorer`}>Create query</Link>
</Button>
}
/>
)}
{savedQueries.map((query) => (
<SavedQueriesItem item={query} key={query.id} />
))}
</SidebarCollapsible>
<Separator className="my-4" />
<FeaturePreviewSidebarPanel
className="mx-4 mt-4"
title="Capture your logs"
description="Send logs to your preferred observability or storage platform."
illustration={
<div className="flex items-center gap-4">
{LOG_DRAIN_TYPES.filter((t) =>
['datadog', 'sentry', 'webhook', 'loki'].includes(t.value)
).map((type) =>
React.cloneElement(type.icon, { key: type.name, height: 20, width: 20 })
)}
</div>
}
actions={
<Button asChild>
<Link href={`/project/${ref}/settings/log-drains`}>Go to Log Drains</Link>
</Button>
}
/>
</div>
)
}