Files
supabase/apps/studio/components/interfaces/BranchManagement/OutOfDateNotice.tsx
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

134 lines
4.3 KiB
TypeScript

import { GitBranchIcon } from 'lucide-react'
import { useState } from 'react'
import {
AlertDialog,
AlertDialogAction,
AlertDialogCancel,
AlertDialogContent,
AlertDialogDescription,
AlertDialogFooter,
AlertDialogHeader,
AlertDialogTitle,
AlertDialogTrigger,
Button,
} from 'ui'
import { Admonition } from 'ui-patterns/Admonition'
import { useSelectedProjectQuery } from '@/hooks/misc/useSelectedProject'
import { useTrack } from '@/lib/telemetry/track'
interface OutOfDateNoticeProps {
isBranchOutOfDateMigrations: boolean
missingMigrationsCount: number
hasMissingFunctions: boolean
missingFunctionsCount: number
hasOutOfDateFunctions: boolean
outOfDateFunctionsCount: number
hasEdgeFunctionModifications: boolean
modifiedFunctionsCount: number
isPushing: boolean
onPush: () => void
}
export const OutOfDateNotice = ({
isBranchOutOfDateMigrations,
missingMigrationsCount,
hasMissingFunctions,
hasOutOfDateFunctions,
hasEdgeFunctionModifications,
modifiedFunctionsCount,
isPushing,
onPush,
}: OutOfDateNoticeProps) => {
const [isDialogOpen, setIsDialogOpen] = useState(false)
const hasOutdatedMigrations = isBranchOutOfDateMigrations && missingMigrationsCount > 0
const { data: project } = useSelectedProjectQuery()
const track = useTrack()
const isBranch = project?.parent_project_ref !== undefined
const parentProjectRef = isBranch ? project?.parent_project_ref : project?.ref
const getTitle = () => {
if (hasOutdatedMigrations && (hasMissingFunctions || hasOutOfDateFunctions)) {
return 'Your database schema and edge functions are out of date'
} else if (hasOutdatedMigrations) {
return 'Your database schema is out of date'
} else if (hasMissingFunctions || hasOutOfDateFunctions) {
return 'Your functions are out of date'
}
return 'Branch is out of date'
}
const getDescription = () => {
return 'Update this branch to get the latest changes from the production branch.'
}
const handleUpdate = (shouldCloseDialog = false) => {
if (shouldCloseDialog) {
setIsDialogOpen(false)
}
track(
'branch_updated',
{
modifiedEdgeFunctions: hasEdgeFunctionModifications,
source: 'out_of_date_notice',
},
{ project: parentProjectRef }
)
onPush()
}
return (
<Admonition type="warning" className="my-4">
<div className="w-full flex items-center justify-between">
<div>
<h3 className="text-sm font-medium">{getTitle()}</h3>
<p className="text-sm text-foreground-light">{getDescription()}</p>
</div>
{hasEdgeFunctionModifications ? (
<AlertDialog open={isDialogOpen} onOpenChange={setIsDialogOpen}>
<AlertDialogTrigger asChild>
<Button
loading={isPushing}
icon={<GitBranchIcon size={16} strokeWidth={1.5} />}
className="shrink-0"
>
{isPushing ? 'Updating...' : 'Update branch'}
</Button>
</AlertDialogTrigger>
<AlertDialogContent>
<AlertDialogHeader>
<AlertDialogTitle>Update branch with modified functions</AlertDialogTitle>
<AlertDialogDescription>
This branch has {modifiedFunctionsCount} modified edge function
{modifiedFunctionsCount !== 1 ? 's' : ''} that will be overwritten when updating
with the latest functions from the production branch. This action cannot be
undone.
</AlertDialogDescription>
</AlertDialogHeader>
<AlertDialogFooter>
<AlertDialogCancel>Cancel</AlertDialogCancel>
<AlertDialogAction variant="warning" onClick={() => handleUpdate(true)}>
Update anyway
</AlertDialogAction>
</AlertDialogFooter>
</AlertDialogContent>
</AlertDialog>
) : (
<Button
loading={isPushing}
onClick={() => handleUpdate()}
icon={<GitBranchIcon size={16} strokeWidth={1.5} />}
className="shrink-0"
>
{isPushing ? 'Updating...' : 'Update branch'}
</Button>
)}
</div>
</Admonition>
)
}